From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B553CE936ED for ; Wed, 4 Oct 2023 23:39:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235458AbjJDXjh (ORCPT ); Wed, 4 Oct 2023 19:39:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230381AbjJDXjf (ORCPT ); Wed, 4 Oct 2023 19:39:35 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 292A1CE for ; Wed, 4 Oct 2023 16:39:31 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B741C433C8; Wed, 4 Oct 2023 23:39:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696462770; bh=XcrEHh7VURvqf+a/pDJhVah/wclnCHtLqyJgoKS2JRw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ygx4Czz/3hK4v/b+Kq43HLoPDxlzdl1EcIydhNPn3vplsq00Otzn0ARDzFbb5H8Kw BVmkSE8EXwl7JdzUdUTTVK5g5vQkx8fwCVIT164+OgUvA30IBN0lkN+kXYgd6tDan3 M1/R+B8onwi7+t6QbAG7z+hJmRk2sVE3rPXFqpreiMXUh7Fb/w8XmIHsvdeHzUyBTd 39mYAdQ47fawhUW6ZK0XwoByt8XS+ZXgCbNoc0XFvQwpAhWUBuYgL67s/60xDgEfXn aVPVrrXVfgOF/+rSSRaQVuT7KgRy68KCDQEwPMWWIklrHPUKmM6j2PipWaCUBTIkNV jGJsySgr4alnQ== Date: Wed, 4 Oct 2023 16:39:29 -0700 From: Jakub Kicinski To: Moshe Shemesh Cc: "David S. Miller" , , Jiri Pirko , Subject: Re: [PATCH net] devlink: Hold devlink lock on health reporter dump get Message-ID: <20231004163929.70977d05@kernel.org> In-Reply-To: <1696173580-222744-1-git-send-email-moshe@nvidia.com> References: <1696173580-222744-1-git-send-email-moshe@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 1 Oct 2023 18:19:40 +0300 Moshe Shemesh wrote: > Devlink health dump get callback should take devlink lock as any other > devlink callback. Add devlink lock to the callback and to any call for > devlink_health_do_dump(). > > As devlink lock is added to any callback of dump, the reporter dump_lock > is now redundant and can be removed. I love the change but it needs more info in the commit message :) 1. what exact / example but real problem are you solving? 2. some words of reassurance that you checked all the drivers and the locking change should be safe (none of them take instance locks in reporter callbacks etc) -- pw-bot: cr