All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: werneazc@gmail.com, jic23@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	lars@metafoo.de
Cc: oe-kbuild-all@lists.linux.dev, devicetree@vger.kernel.org,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andre Werner <andre.werner@systec-electronic.com>
Subject: Re: [PATCH 2/2] iio: adc: ads7038: Add driver support for 12bit ADC
Date: Thu, 5 Oct 2023 02:11:49 +0800	[thread overview]
Message-ID: <202310050120.yV1We3RG-lkp@intel.com> (raw)
In-Reply-To: <20231004102330.3713-2-andre.werner@systec-electronic.com>

Hi,

kernel test robot noticed the following build warnings:

[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on robh/for-next linus/master v6.6-rc4 next-20231004]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/werneazc-gmail-com/iio-adc-ads7038-Add-driver-support-for-12bit-ADC/20231004-182531
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link:    https://lore.kernel.org/r/20231004102330.3713-2-andre.werner%40systec-electronic.com
patch subject: [PATCH 2/2] iio: adc: ads7038: Add driver support for 12bit ADC
config: csky-allmodconfig (https://download.01.org/0day-ci/archive/20231005/202310050120.yV1We3RG-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231005/202310050120.yV1We3RG-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310050120.yV1We3RG-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/iio/adc/ti-ads7038-core.c:46:5: warning: no previous prototype for 'ads7038_read_raw' [-Wmissing-prototypes]
      46 | int ads7038_read_raw(struct iio_dev *indio_dev,
         |     ^~~~~~~~~~~~~~~~


vim +/ads7038_read_raw +46 drivers/iio/adc/ti-ads7038-core.c

    45	
  > 46	int ads7038_read_raw(struct iio_dev *indio_dev,
    47			     struct iio_chan_spec const *chan,
    48			     int *val, int *val2,
    49			     long mask)
    50	{
    51		unsigned int ret;
    52		struct ads7038_ch_meas_result tmp_val;
    53		struct ads7038_data *const data = (struct ads7038_data *)iio_priv(indio_dev);
    54		struct ads7038_info *const info = (struct ads7038_info *)data->info;
    55	
    56		ret = info->read_channel(indio_dev, chan->channel, &tmp_val);
    57	
    58		if (ret < 0) {
    59			dev_err(&indio_dev->dev, "Read channel returned with error %d", ret);
    60			return ret;
    61		}
    62	
    63		switch (mask) {
    64		case IIO_CHAN_INFO_RAW:
    65			*val = tmp_val.raw;
    66	
    67			ret = IIO_VAL_INT;
    68			break;
    69		case IIO_CHAN_INFO_SCALE:
    70			ret = regulator_get_voltage(data->reg);
    71			if (ret < 0)
    72				break;
    73	
    74			*val = ret / 1000;	/* uV -> mV */
    75			*val2 = (1 << chan->scan_type.realbits) - 1;
    76	
    77			ret = IIO_VAL_FRACTIONAL;
    78			break;
    79		default:
    80			ret = -EINVAL;
    81			break;
    82		}
    83	
    84		return ret;
    85	}
    86	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2023-10-04 18:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-04 10:23 [PATCH 1/2] dt-bindings: iio: adc: ti,ads7038: Add description for ADS7038 werneazc
2023-10-04 10:23 ` [PATCH 2/2] iio: adc: ads7038: Add driver support for 12bit ADC werneazc
2023-10-04 18:11   ` kernel test robot [this message]
2023-10-05  2:04   ` kernel test robot
2023-10-04 15:11 ` [PATCH 1/2] dt-bindings: iio: adc: ti,ads7038: Add description for ADS7038 Rob Herring
2023-10-05  3:51   ` werneazc
2023-10-05 15:38     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202310050120.yV1We3RG-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=andre.werner@systec-electronic.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=robh+dt@kernel.org \
    --cc=werneazc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.