From: Christoph Hellwig <hch@lst.de>
To: Kees Cook <keescook@chromium.org>
Cc: James Smart <james.smart@broadcom.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
linux-nvme@lists.infradead.org,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] nvmet-fc: Annotate struct nvmet_fc_tgt_queue with __counted_by
Date: Thu, 5 Oct 2023 10:22:17 +0200 [thread overview]
Message-ID: <20231005082217.GA12575@lst.de> (raw)
In-Reply-To: <20231003232511.work.459-kees@kernel.org>
On Tue, Oct 03, 2023 at 04:25:11PM -0700, Kees Cook wrote:
> struct workqueue_struct *work_q;
> struct kref ref;
> struct rcu_head rcu;
> - struct nvmet_fc_fcp_iod fod[]; /* array of fcp_iods */
> + struct nvmet_fc_fcp_iod fod[] __counted_by(sqsize); /* array of fcp_iods */
Please move the comment up to not spill over the end of the line.
Otherwise this looks good.
prev parent reply other threads:[~2023-10-05 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 23:25 [PATCH] nvmet-fc: Annotate struct nvmet_fc_tgt_queue with __counted_by Kees Cook
2023-10-03 23:41 ` Gustavo A. R. Silva
2023-10-04 6:33 ` Chaitanya Kulkarni
2023-10-05 8:22 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231005082217.GA12575@lst.de \
--to=hch@lst.de \
--cc=gustavoars@kernel.org \
--cc=james.smart@broadcom.com \
--cc=kch@nvidia.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=sagi@grimberg.me \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.