From: Kees Cook <keescook@chromium.org>
To: David Laight <David.Laight@aculab.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"'linux@rasmusvillemoes.dk'" <linux@rasmusvillemoes.dk>,
'Steven Rostedt' <rostedt@goodmis.org>,
"'bvanassche@acm.org'" <bvanassche@acm.org>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Arnd Bergmann <arnd@arndb.de>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 next] compiler.h: Move __is_constexpr() to compiler.h.
Date: Thu, 5 Oct 2023 09:21:59 -0700 [thread overview]
Message-ID: <202310050921.F0B15702D4@keescook> (raw)
In-Reply-To: <2a6680bbe2e84459816a113730426782@AcuMS.aculab.com>
On Thu, Oct 05, 2023 at 11:39:54AM +0000, David Laight wrote:
> Prior to f747e6667ebb2 __is_constexpr() was in its only user minmax.h.
> That commit moved it to const.h - but that file just defines ULL(x) and
> UL(x) so that constants can be defined for .S and .c files.
> So apart from the word 'const' it wasn't really a good location.
> Instead move the definition to compiler.h just before the similar
> is_signed_type() and is_unsigned_type().
> This may not be a good long-term home, but the three definitions
> belong together.
>
> Signed-off-by: David Laight <david.laight@aculab.com>
Yeah, this is what I'd expect (a duplicate move in tools/). Thanks!
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2023-10-05 16:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 11:39 [PATCH v2 next] compiler.h: Move __is_constexpr() to compiler.h David Laight
2023-10-05 16:21 ` Kees Cook [this message]
2023-10-06 8:28 ` David Laight
2023-10-06 15:51 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202310050921.F0B15702D4@keescook \
--to=keescook@chromium.org \
--cc=David.Laight@aculab.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bvanassche@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.