From: Lee Jones <lee@kernel.org>
To: Anjelique Melendez <quic_amelende@quicinc.com>
Cc: pavel@ucw.cz, thierry.reding@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
agross@kernel.org, andersson@kernel.org,
luca.weiss@fairphone.com, konrad.dybcio@linaro.org,
u.kleine-koenig@pengutronix.de, quic_subbaram@quicinc.com,
quic_gurus@quicinc.com, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org,
kernel@quicinc.com
Subject: Re: [PATCH v5 7/7] leds: rgb: Update PM8350C lpg_data to support two-nvmem PPG Scheme
Date: Thu, 5 Oct 2023 14:45:25 +0100 [thread overview]
Message-ID: <20231005134525.GG681678@google.com> (raw)
In-Reply-To: <20230929003901.15086-8-quic_amelende@quicinc.com>
On Thu, 28 Sep 2023, Anjelique Melendez wrote:
> Update the pm8350c lpg_data struct so that pm8350c devices are treated as
> PWM devices that support two-nvmem PPG scheme.
>
> Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com>
> ---
> drivers/leds/rgb/leds-qcom-lpg.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
Reviewed-by: Lee Jones <lee@kernel.org>
> diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c
> index 910c7cf740cc..8962ea13df29 100644
> --- a/drivers/leds/rgb/leds-qcom-lpg.c
> +++ b/drivers/leds/rgb/leds-qcom-lpg.c
> @@ -1800,11 +1800,13 @@ static const struct lpg_data pm8150l_lpg_data = {
> static const struct lpg_data pm8350c_pwm_data = {
> .triled_base = 0xef00,
>
> + .lut_size = 122,
> +
> .num_channels = 4,
> .channels = (const struct lpg_channel_data[]) {
> - { .base = 0xe800, .triled_mask = BIT(7) },
> - { .base = 0xe900, .triled_mask = BIT(6) },
> - { .base = 0xea00, .triled_mask = BIT(5) },
> + { .base = 0xe800, .triled_mask = BIT(7), .sdam_offset = 0x48 },
> + { .base = 0xe900, .triled_mask = BIT(6), .sdam_offset = 0x56 },
> + { .base = 0xea00, .triled_mask = BIT(5), .sdam_offset = 0x64 },
> { .base = 0xeb00 },
> },
> };
> --
> 2.41.0
>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-10-05 14:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 0:38 [PATCH v5 0/7] Add support for LUT PPG Anjelique Melendez
2023-09-29 0:38 ` [PATCH v5 1/7] dt-bindings: soc: qcom: Add qcom,pbs bindings Anjelique Melendez
2023-09-29 0:38 ` [PATCH v5 2/7] dt-bindings: leds: leds-qcom-lpg: Add support for LPG PPG Anjelique Melendez
2023-09-29 0:38 ` [PATCH v5 3/7] soc: qcom: add QCOM PBS driver Anjelique Melendez
2023-09-29 0:38 ` [PATCH v5 4/7] leds: rgb: leds-qcom-lpg: Add support for single SDAM PPG Anjelique Melendez
2023-10-05 13:37 ` Lee Jones
2023-09-29 0:38 ` [PATCH v5 5/7] leds: rgb: leds-qcom-lpg: Update PMI632 lpg_data to support PPG Anjelique Melendez
2023-10-05 13:38 ` Lee Jones
2023-09-29 0:38 ` [PATCH v5 6/7] leds: rgb: leds-qcom-lpg: Include support for PPG with dedicated LUT SDAM Anjelique Melendez
2023-10-05 13:44 ` Lee Jones
2023-09-29 0:39 ` [PATCH v5 7/7] leds: rgb: Update PM8350C lpg_data to support two-nvmem PPG Scheme Anjelique Melendez
2023-10-05 13:45 ` Lee Jones [this message]
2023-10-01 14:15 ` [PATCH v5 0/7] Add support for LUT PPG Luca Weiss
2023-10-12 21:50 ` Anjelique Melendez
2023-10-13 6:35 ` Luca Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231005134525.GG681678@google.com \
--to=lee@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=pavel@ucw.cz \
--cc=quic_amelende@quicinc.com \
--cc=quic_gurus@quicinc.com \
--cc=quic_subbaram@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.