From: Stephen Hemminger <stephen@networkplumber.org>
To: Sam Andrew <samandrew@microsoft.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"ferruh.yigit@amd.com" <ferruh.yigit@amd.com>,
"andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
Long Li <longli@microsoft.com>
Subject: Re: [PATCH v2] net/netvsc: add support for mtu_set
Date: Fri, 6 Oct 2023 13:17:56 -0700 [thread overview]
Message-ID: <20231006131756.43f1bba6@hermes.local> (raw)
In-Reply-To: <MN0PR21MB312032657144AC028C9F0D58B5C9A@MN0PR21MB3120.namprd21.prod.outlook.com>
On Fri, 6 Oct 2023 20:09:09 +0000
Sam Andrew <samandrew@microsoft.com> wrote:
> - }
> + } else
> + VMBUS_LOG(DEBUG, " VMBUS memory mapped at %p",
> + mapaddr);
> return mapaddr;
Checkpatch style guide is that if the if clause has brackets, then else
clause should as well.
next prev parent reply other threads:[~2023-10-06 20:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 23:17 [PATCH] net/netvsc: add support for mtu_set Sam Andrew
2023-10-06 20:09 ` [PATCH v2] " Sam Andrew
2023-10-06 20:17 ` Stephen Hemminger [this message]
2023-10-06 20:22 ` Stephen Hemminger
2023-10-10 15:55 ` Stephen Hemminger
2023-10-10 18:41 ` [PATCH v3] " Sam Andrew
2023-10-10 19:08 ` Long Li
2023-10-11 11:03 ` Ferruh Yigit
2023-10-09 15:17 ` [PATCH] " Stephen Hemminger
2023-10-09 16:41 ` [EXTERNAL] " Sam Andrew
2023-10-10 15:55 ` Stephen Hemminger
2023-10-31 2:16 ` Rahul Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231006131756.43f1bba6@hermes.local \
--to=stephen@networkplumber.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=longli@microsoft.com \
--cc=samandrew@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.