Re: [PATCH v12 7/7] nvmem: core: Expose cells through sysfs

[kernel test robot <lkp@intel.com>]

Hi Miquel,

kernel test robot noticed the following build warnings:

[auto build test WARNING on robh/for-next]
[also build test WARNING on char-misc/char-misc-testing char-misc/char-misc-next char-misc/char-misc-linus linus/master v6.6-rc4 next-20231006]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Miquel-Raynal/of-device-Export-of_device_make_bus_id/20231006-000111
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20231005155907.2701706-8-miquel.raynal%40bootlin.com
patch subject: [PATCH v12 7/7] nvmem: core: Expose cells through sysfs
config: m68k-m5208evb_defconfig (https://download.01.org/0day-ci/archive/20231007/202310070203.rNhXeE2Q-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231007/202310070203.rNhXeE2Q-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310070203.rNhXeE2Q-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from drivers/nvmem/core.c:22:
   drivers/nvmem/internals.h: In function 'nvmem_destroy_layout':
   drivers/nvmem/internals.h:55:47: error: no return statement in function returning non-void [-Werror=return-type]
      55 | static inline int nvmem_destroy_layout(struct nvmem_device *nvmem) { }
         |                                               ^~~~~~~~~~~~
   drivers/nvmem/core.c: In function 'nvmem_register':
>> drivers/nvmem/core.c:1045:1: warning: label 'err_remove_dev' defined but not used [-Wunused-label]
    1045 | err_remove_dev:
         | ^~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/err_remove_dev +1045 drivers/nvmem/core.c

  1040	
  1041		blocking_notifier_call_chain(&nvmem_notifier, NVMEM_ADD, nvmem);
  1042	
  1043		return nvmem;
  1044	
> 1045	err_remove_dev:
  1046		device_del(&nvmem->dev);
  1047	err_destroy_layout:
  1048		nvmem_destroy_layout(nvmem);
  1049	err_remove_cells:
  1050		nvmem_device_remove_all_cells(nvmem);
  1051		if (config->compat)
  1052			nvmem_sysfs_remove_compat(nvmem, config);
  1053	err_put_device:
  1054		put_device(&nvmem->dev);
  1055	
  1056		return ERR_PTR(rval);
  1057	}
  1058	EXPORT_SYMBOL_GPL(nvmem_register);
  1059	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki