From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAD8EE9371B for ; Sat, 7 Oct 2023 07:21:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343677AbjJGHVK (ORCPT ); Sat, 7 Oct 2023 03:21:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343636AbjJGHVJ (ORCPT ); Sat, 7 Oct 2023 03:21:09 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 394BBBD; Sat, 7 Oct 2023 00:21:08 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id A0277809E; Sat, 7 Oct 2023 07:21:07 +0000 (UTC) Date: Sat, 7 Oct 2023 10:21:06 +0300 From: Tony Lindgren To: Dan Carpenter Cc: Tero Kristo , Tero Kristo , Michael Turquette , Stephen Boyd , Dario Binacchi , linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] clk: ti: fix double free in of_ti_divider_clk_setup() Message-ID: <20231007072106.GV34982@atomide.com> References: <6d36eeec-6c8a-4f11-a579-aa3cd7c38749@moroto.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6d36eeec-6c8a-4f11-a579-aa3cd7c38749@moroto.mountain> Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org * Dan Carpenter [231002 10:04]: > The "div" pointer is freed in _register_divider() and again in > of_ti_divider_clk_setup(). Delete the free in _register_divider() Reviewed-by: Tony Lindgren