From: Greg KH <gregkh@linuxfoundation.org>
To: "Maciej Żenczykowski" <maze@google.com>
Cc: Sasha Levin <sashal@kernel.org>, Patrick Rohr <prohr@google.com>,
stable@vger.kernel.org, Lorenzo Colitti <lorenzo@google.com>
Subject: Re: [PATCH 6.1 0/3] net: add sysctl accept_ra_min_lft
Date: Sat, 7 Oct 2023 11:48:46 +0200 [thread overview]
Message-ID: <2023100719-scouts-diabetic-37e2@gregkh> (raw)
In-Reply-To: <2023100703-configure-smudge-8204@gregkh>
On Sat, Oct 07, 2023 at 11:30:41AM +0200, Greg KH wrote:
> On Fri, Oct 06, 2023 at 12:40:36PM -0700, Maciej Żenczykowski wrote:
> > > >> > > Was this rejected?
> > > >> > > Any resolution on this (ACK or NAK) would be useful. Thanks!
> > > >> >
> > > >> > They are in our "to get to" queue, which is very long still due to
> > > >> > multiple conferences and travel.
> > > >> >
> > > >> > But I will note, you didn't put the git id of the patches in the patches
> > > >> > themselves, so it will take me extra work to add them there when
> > > >> > applying.
> > > >> >
> > > >> > Also, why just 6.1? What about newer stable kernels? You can't update
> > > >> > and have a regression, right?
> > > >>
> > > >> Note, because of this, we can not take these patches now at all anyway :(
> > > >
> > > >Because without any knowledge of whether these patches would even be
> > > >accepted into stable, or whether they would need to go in via ACK,
> > > >preparing them for more trees seemed like pointless busywork...
> > >
> > > FWIW, the above just means that we get to do the busywork rather than
> > > the submitter...
> >
> > We're certainly willing to do the work, but we're not entirely sure
> > what you want,
> > and whether you will indeed even accept these patches...
> > We're just trying to be mindful of everyone's time...
> >
> > For example as a reviewer myself I know that in many cases it is
> > simply easier to do the
> > clean (!) cherrypick yourself (you presumably have scripts that
> > automate the entire thing),
> > rather than try to verify that someone else's cherrypick is actually
> > indeed clean.
> >
> > These patches cleanly cherry pick, build, and pass our tests on
> > current 6.5 and 6.1 LTS.
> >
> > git checkout remotes/linux-stable/v6.5.6 && git cherry-pick
> > 1671bcfd76fdc0b9e65153cf759153083755fe4c && git cherry-pick
> > 5027d54a9c30bc7ec808360378e2b4753f053f25 && git cherry-pick
> > 5cb249686e67dbef3ffe53887fa725eefc5a7144 && run_uml_ack_net_test
> >
> > (and same thing with 6.1.56)
> >
> > Do you simply want the upstream sha1s?
>
> For things that cherry-pick cleanly, yes, that's easiest.
And I've cherry-picked these for 6.1.y and 6.5.y now. If you all want
them in older kernels, please send working backports.
thanks,
greg k-h
prev parent reply other threads:[~2023-10-07 9:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 21:10 [PATCH 6.1 0/3] net: add sysctl accept_ra_min_lft Patrick Rohr
2023-09-25 21:10 ` [PATCH 6.1 1/3] net: add sysctl accept_ra_min_rtr_lft Patrick Rohr
2023-09-25 21:10 ` [PATCH 6.1 2/3] net: change accept_ra_min_rtr_lft to affect all RA lifetimes Patrick Rohr
2023-09-25 21:10 ` [PATCH 6.1 3/3] net: release reference to inet6_dev pointer Patrick Rohr
2023-10-05 21:37 ` [PATCH 6.1 0/3] net: add sysctl accept_ra_min_lft Patrick Rohr
2023-10-06 5:52 ` Greg KH
2023-10-06 6:21 ` Greg KH
2023-10-06 7:06 ` Maciej Żenczykowski
2023-10-06 7:53 ` Greg KH
2023-10-06 12:17 ` Sasha Levin
2023-10-06 19:40 ` Maciej Żenczykowski
2023-10-07 9:30 ` Greg KH
2023-10-07 9:48 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023100719-scouts-diabetic-37e2@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=lorenzo@google.com \
--cc=maze@google.com \
--cc=prohr@google.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.