All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Adam Duskett <adam.duskett@amarulasolutions.com>
Cc: Antoine Tenart <atenart@kernel.org>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/2] package/refpolicy/Config.in: force merged usr when selecting upstream
Date: Sat, 7 Oct 2023 21:34:22 +0200	[thread overview]
Message-ID: <20231007193422.GG2552@scaer> (raw)
In-Reply-To: <20231007181926.7115-1-adam.duskett@amarulasolutions.com>

Adam, All,

On 2023-10-07 20:19 +0200, Adam Duskett spake thusly:
> Refpolicy contexts expect a merged /usr file system. In fact, there
> are no references to /bin, /sbin, /lib, or /lib64 at all. However, if a user
> wants to go through the trouble of creating a policy that works with a
> non-merged system, they should be free to do so. As such, only select
> BR2_ROOTFS_MERGED_USR if using BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION
> 
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
> ---
>  package/refpolicy/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/refpolicy/Config.in b/package/refpolicy/Config.in
> index 0e72b895df..f1f3c7e64d 100644
> --- a/package/refpolicy/Config.in
> +++ b/package/refpolicy/Config.in
> @@ -36,6 +36,7 @@ choice
>  
>  config BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION
>  	bool "Upstream version"
> +	select BR2_ROOTFS_MERGED_USR

I wonder if this is the proper solution. I would have rather though of
depends on rather than select:

    diff --git a/package/refpolicy/Config.in b/package/refpolicy/Config.in
    index 0e72b895df..c413c1244b 100644
    --- a/package/refpolicy/Config.in
    +++ b/package/refpolicy/Config.in
    @@ -32,13 +32,17 @@ if BR2_PACKAGE_REFPOLICY

     choice
     	prompt "Refpolicy version"
     -	default BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION
     +	default BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION if BR2_ROOTFS_MERGED_USR

     config BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION
     	bool "Upstream version"
    +	depends on BR2_ROOTFS_MERGED_USR
     	help
     	  Use the refpolicy as provided by Buildroot.

    +comment "upstream refpolicy needs merged /usr"
    +	depends on !BR2_ROOTFS_MERGED_USR
    +
     config BR2_PACKAGE_REFPOLICY_CUSTOM_GIT
     	bool "Custom git repository"
     	help

Not totally sure either ways, though...

Regards,
Yann E. MORIN.

>  	help
>  	  Use the refpolicy as provided by Buildroot.
>  
> -- 
> 2.41.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2023-10-07 19:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-07 18:19 [Buildroot] [PATCH v2 1/2] package/refpolicy/Config.in: force merged usr when selecting upstream Adam Duskett
2023-10-07 18:19 ` [Buildroot] [PATCH v2 2/2] package/refpolicy: bump version to 2.20221101 Adam Duskett
2023-10-07 19:34 ` Yann E. MORIN [this message]
2023-10-08  9:40   ` [Buildroot] [PATCH v2 1/2] package/refpolicy/Config.in: force merged usr when selecting upstream Arnout Vandecappelle via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231007193422.GG2552@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=adam.duskett@amarulasolutions.com \
    --cc=atenart@kernel.org \
    --cc=buildroot@buildroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.