From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD9E0E95A92 for ; Sun, 8 Oct 2023 12:29:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344743AbjJHMTk (ORCPT ); Sun, 8 Oct 2023 08:19:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230303AbjJHMTi (ORCPT ); Sun, 8 Oct 2023 08:19:38 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11D50B9; Sun, 8 Oct 2023 05:19:35 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qpSkW-0002mQ-QP; Sun, 08 Oct 2023 14:19:08 +0200 Date: Sun, 8 Oct 2023 14:19:08 +0200 From: Florian Westphal To: xiaolinkui Cc: Jozsef Kadlecsik , Florian Westphal , Pablo Neira Ayuso , David Miller , edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, justinstitt@google.com, kuniyu@amazon.com, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Linkui Xiao Subject: Re: [PATCH] netfilter: ipset: wait for xt_recseq on all cpus Message-ID: <20231008121908.GA29696@breakpoint.cc> References: <20231005115022.12902-1-xiaolinkui@126.com> <20231005123107.GB9350@breakpoint.cc> <2c9efd36-f1f6-b77b-d4eb-f65932cfaba@netfilter.org> <6ed069d2-0201-a2c0-de92-bd6fc8f33ed7@126.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6ed069d2-0201-a2c0-de92-bd6fc8f33ed7@126.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org xiaolinkui wrote: > crash> struct seqcount_t ffff8003fff3bf88 > struct seqcount_t { > sequence = 804411271 > } > > The seqcount of CPU7 is odd, xt_replace_table should have waited, but it > didn't. Likely missing backport of 175e476b8cdf ("netfilter: x_tables: Use correct memory barriers.")?