From: John Clark <inindev@gmail.com>
To: u-boot@lists.denx.de
Cc: John Clark <inindev@gmail.com>,
Chris Morgan <macromorgan@hotmail.com>,
Eugen Hristev <eugen.hristev@collabora.com>,
FUKAUMI Naoki <naoki@radxa.com>, Jagan Teki <jagan@edgeble.ai>,
Johan Jonker <jbx6244@gmail.com>, Jonas Karlman <jonas@kwiboo.se>,
Kever Yang <kever.yang@rock-chips.com>,
Michal Simek <michal.simek@amd.com>,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
Philipp Tomsich <philipp.tomsich@theobroma-systems.com>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Simon Glass <sjg@chromium.org>,
Stefan Bosch <stefan_b@posteo.net>
Subject: [PATCH v2 0/1] board: rockchip: add FriendlyElec NanoPC-T6 rk3588 board
Date: Sun, 8 Oct 2023 18:46:32 +0000 [thread overview]
Message-ID: <20231008184805.5088-1-inindev@gmail.com> (raw)
Jonas, thank you for your detailed review. The explanations for each of config change recommendations were especially helpful.
As for the CFG_IRAM_BASE / BROM_LAST_BOOTSOURCE issue, I have made a step forward, but expect I will be getting feedback as to a better approach.
Note: This patchset is based on Kever's most recent pull request "u-boot-rockchip-20231007" which, as of this writing, has yet to be merged upstream.
Finally, I would appreciate any insight as to FriendlyElec vs FriendlyARM naming. Currently, I have documented this as the "FriendlyARM NanoPC-T6" but it would seem that it could also be called the "FriendlyElec NanoPC-T6" and be equally correct. It is worth noting that u-boot currently contains support for the "FriendlyARM NanoPi2" board/friendlyarm/nanopi2 and thus my use of FriendlyARM.
Changes in v2:
- resync dt from:
https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/plain/arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dts?h=for-next
- config changes:
-CONFIG_PCI_INIT_R=y
-CONFIG_SYS_SPI_U_BOOT_OFFS=0x100000
+CONFIG_SYS_SPI_U_BOOT_OFFS=0x60000
-CONFIG_REGULATOR_PWM=y
-# CONFIG_USB_XHCI_DWC3_OF_SIMPLE is not set
-CONFIG_SPL_USB_DWC3_GENERIC=y
- added board files:
create mode 100644 board/friendlyarm/nanopct6-rk3588/Kconfig
create mode 100644 board/friendlyarm/nanopct6-rk3588/MAINTAINERS
create mode 100644 board/friendlyarm/nanopct6-rk3588/Makefile
create mode 100644 board/friendlyarm/nanopct6-rk3588/nanopct6-rk3588.c
create mode 100644 include/configs/nanopct6-rk3588.h
- improved BROM_LAST_BOOTSOURCE handling for SPI NOR:
if (CONFIG_IS_ENABLED(TARGET_NANOPCT6_RK3588) && bootdevice_brom_id == 4)
bootdevice_ofpath = boot_devices[BROM_BOOTSOURCE_SPINOR];
else
bootdevice_ofpath = boot_devices[bootdevice_brom_id];
--
2.42.0
next reply other threads:[~2023-10-08 18:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-08 18:46 John Clark [this message]
2023-10-08 18:46 ` [PATCH v2 1/1] board: rockchip: add FriendlyElec NanoPC-T6 rk3588 board John Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231008184805.5088-1-inindev@gmail.com \
--to=inindev@gmail.com \
--cc=eugen.hristev@collabora.com \
--cc=frattaroli.nicolas@gmail.com \
--cc=jagan@edgeble.ai \
--cc=jbx6244@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kever.yang@rock-chips.com \
--cc=macromorgan@hotmail.com \
--cc=michal.simek@amd.com \
--cc=naoki@radxa.com \
--cc=philipp.tomsich@theobroma-systems.com \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=stefan_b@posteo.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.