From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Yury Norov <yury.norov@gmail.com>
Cc: linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <davidgow@google.com>,
Hans de Goede <hdegoede@redhat.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
James Seo <james@equiv.tech>, Jason Baron <jbaron@akamai.com>,
Kees Cook <keescook@chromium.org>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Marco Elver <elver@google.com>, Mark Brown <broonie@kernel.org>,
Ming Lei <ming.lei@redhat.com>,
Petr Tesarik <petr.tesarik.ext@huawei.com>,
Rae Moar <rmoar@google.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/2] lib/bitmap: move bitmap allocators for device to linux/device.h
Date: Sun, 8 Oct 2023 06:53:49 +0200 [thread overview]
Message-ID: <2023100855-railroad-wrecking-25af@gregkh> (raw)
In-Reply-To: <20231007233510.2097166-2-yury.norov@gmail.com>
On Sat, Oct 07, 2023 at 04:35:09PM -0700, Yury Norov wrote:
> The allocators are simple wrappers around bitmap_{alloc,free}().
> So move them from bitmap to device sources.
No, they belong in the bitmap.h file, as they are devm_* versions of the
same functions in this file. They don't belong in the device.h file.
> Similarly to other device wrappers, turn them to static inlines
> and place in header.
Why do these need to be inline functions?
thanks,
greg k-h
next prev parent reply other threads:[~2023-10-08 5:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-07 23:35 [PATCH 0/2] lib: unload lib/bitmap.c Yury Norov
2023-10-07 23:35 ` [PATCH 1/2] lib/bitmap: move bitmap allocators for device to linux/device.h Yury Norov
2023-10-08 4:53 ` Greg Kroah-Hartman [this message]
2023-10-08 15:39 ` Yury Norov
2023-10-08 16:31 ` Greg Kroah-Hartman
2023-10-07 23:35 ` [PATCH 2/2] lib/bitmap: split-out string-related operations to a separate files Yury Norov
2023-10-15 2:32 ` [PATCH 0/2] lib: unload lib/bitmap.c Yury Norov
2023-10-16 18:38 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023100855-railroad-wrecking-25af@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brendan.higgins@linux.dev \
--cc=broonie@kernel.org \
--cc=davidgow@google.com \
--cc=elver@google.com \
--cc=hdegoede@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=james@equiv.tech \
--cc=jbaron@akamai.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=ming.lei@redhat.com \
--cc=petr.tesarik.ext@huawei.com \
--cc=rafael@kernel.org \
--cc=rmoar@google.com \
--cc=tglx@linutronix.de \
--cc=wangkefeng.wang@huawei.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.