From: Brian Kloppenborg <bkloppenborg@gmail.com>
To: Johan Hovold <johan@kernel.org>, linux-usb@vger.kernel.org
Cc: Brian Kloppenborg <brian@kloppenborg.net>
Subject: [PATCH 0/2] Enable modem line status events on cp210x, add support for PPS on RI pin
Date: Sun, 8 Oct 2023 20:34:23 -0600 [thread overview]
Message-ID: <20231009023425.366783-1-brian@kloppenborg.net> (raw)
Dear Johan,
This is my first patch to the Linux kernel.
Patch 1 enables support for modem line status changes to the cp210x driver. This is required to receive pulse-per-second (PPS) signals from GPS receivers. Support for this feature exists in the FTDI driver, but is not present in cp210x. The patch is implemented through (1) enabling the device's event mode by default when the port is opened or closed, and (2) registering the CTS, DSR, RI, and DCD changes with the kernel through conventional means.
Patch 2 enables support for GPS PPS signals on the RI pin. While most GPS devices typically expose this signal on the DCD pin, the Adafruit Ultimate GPS with USB-C placed it on the RI pin instead. So this patch is highly focused on that specific device. From what I can tell, the usb_serial_handle_dcd_change function is used exclusively to register PPS signals with the kernel, so calling it from the RI block shouldn't result in unexpected behavior.
Please let me know if you require any further information.
Regards
Brian Kloppenborg
Signed-off-by: Brian Kloppenborg <brian@kloppenborg.net>
Brian Kloppenborg (2):
Make cp210x respond to modem status changes (CTS, DSR, RI, DCD) by
default.
Make cp210x register GPS PPS signals on the RI pin.
drivers/usb/serial/cp210x.c | 71 +++++++++++++++++++++++++++++++------
1 file changed, 60 insertions(+), 11 deletions(-)
--
2.34.1
next reply other threads:[~2023-10-09 2:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 2:34 Brian Kloppenborg [this message]
2023-10-09 2:34 ` [PATCH 1/2] Make cp210x respond to modem status changes (CTS, DSR, RI, DCD) by default Brian Kloppenborg
2023-10-09 8:59 ` Greg KH
2023-10-09 9:00 ` Greg KH
2023-10-09 2:34 ` [PATCH 2/2] Make cp210x register GPS PPS signals on the RI pin Brian Kloppenborg
2023-10-09 9:00 ` Greg KH
2023-12-15 13:02 ` [PATCH 0/2] Enable modem line status events on cp210x, add support for PPS on " Johan Hovold
2023-12-16 1:40 ` Brian Kloppenborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231009023425.366783-1-brian@kloppenborg.net \
--to=bkloppenborg@gmail.com \
--cc=brian@kloppenborg.net \
--cc=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.