From: Jakub Kicinski <kuba@kernel.org>
To: Chengfeng Ye <dg573847474@gmail.com>
Cc: 3chas3@gmail.com, davem@davemloft.net, horms@kernel.org,
linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] atm: solos-pci: Fix potential deadlock on &cli_queue_lock
Date: Mon, 9 Oct 2023 08:17:50 -0700 [thread overview]
Message-ID: <20231009081750.2073013d@kernel.org> (raw)
In-Reply-To: <CAAo+4rUE=+9Kp8CvMH3w15dJotkX03h=5YMV+hu-YSobkwj1NA@mail.gmail.com>
On Sat, 7 Oct 2023 23:58:36 +0800 Chengfeng Ye wrote:
> > and irqsave here. I think you're right that it's just softirq (== bh)
> > that may deadlock, so no need to take the irqsave() version in process
> > context.
>
> Yes, spin_lock_bh() is enough.
>
> I just found spin_lock_irqsave() is more frequently used in this file, so I
> also used spin_lock_irqsave() here for uniformity consideration at that time.
>
> Should I send a new patch series to change this to spin_lock_bh()? That's
> better for performance consideration.
Yes, performance is one reason and another is that the code will
be easier to understand if the locking matches the requirements.
next prev parent reply other threads:[~2023-10-09 15:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 7:48 [PATCH v2 1/2] atm: solos-pci: Fix potential deadlock on &cli_queue_lock Chengfeng Ye
2023-10-06 23:28 ` Jakub Kicinski
2023-10-07 15:58 ` Chengfeng Ye
2023-10-09 15:17 ` Jakub Kicinski [this message]
2023-12-07 12:37 ` Chengfeng Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231009081750.2073013d@kernel.org \
--to=kuba@kernel.org \
--cc=3chas3@gmail.com \
--cc=davem@davemloft.net \
--cc=dg573847474@gmail.com \
--cc=horms@kernel.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.