From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
qemu-devel@nongnu.org, zhenzhong.duan@intel.com,
alex.williamson@redhat.com, clg@redhat.com, jgg@nvidia.com,
nicolinc@nvidia.com, joao.m.martins@oracle.com,
peterx@redhat.com, kevin.tian@intel.com, yi.l.liu@intel.com,
yi.y.sun@intel.com, chao.p.peng@intel.com,
mjrosato@linux.ibm.com, aik@ozlabs.ru
Subject: [PATCH v5 11/15] vfio/common: Move VFIO reset handler registration to a group agnostic function
Date: Mon, 9 Oct 2023 11:09:13 +0200 [thread overview]
Message-ID: <20231009091035.433329-12-eric.auger@redhat.com> (raw)
In-Reply-To: <20231009091035.433329-1-eric.auger@redhat.com>
From: Zhenzhong Duan <zhenzhong.duan@intel.com>
Move the reset handler registration/unregistration to a place that is not
group specific. vfio_[get/put]_address_space are the best places for that
purpose.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Yi Liu <yi.l.liu@intel.com>
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
---
hw/vfio/common.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index 56cfe94d97..019da387d2 100644
--- a/hw/vfio/common.c
+++ b/hw/vfio/common.c
@@ -1909,6 +1909,10 @@ static VFIOAddressSpace *vfio_get_address_space(AddressSpace *as)
space->as = as;
QLIST_INIT(&space->containers);
+ if (QLIST_EMPTY(&vfio_address_spaces)) {
+ qemu_register_reset(vfio_reset_handler, NULL);
+ }
+
QLIST_INSERT_HEAD(&vfio_address_spaces, space, list);
return space;
@@ -1920,6 +1924,9 @@ static void vfio_put_address_space(VFIOAddressSpace *space)
QLIST_REMOVE(space, list);
g_free(space);
}
+ if (QLIST_EMPTY(&vfio_address_spaces)) {
+ qemu_unregister_reset(vfio_reset_handler, NULL);
+ }
}
/*
@@ -2385,10 +2392,6 @@ static VFIOGroup *vfio_get_group(int groupid, AddressSpace *as, Error **errp)
goto close_fd_exit;
}
- if (QLIST_EMPTY(&vfio_group_list)) {
- qemu_register_reset(vfio_reset_handler, NULL);
- }
-
QLIST_INSERT_HEAD(&vfio_group_list, group, next);
return group;
@@ -2417,10 +2420,6 @@ static void vfio_put_group(VFIOGroup *group)
trace_vfio_put_group(group->fd);
close(group->fd);
g_free(group);
-
- if (QLIST_EMPTY(&vfio_group_list)) {
- qemu_unregister_reset(vfio_reset_handler, NULL);
- }
}
struct vfio_device_info *vfio_get_device_info(int fd)
--
2.41.0
next prev parent reply other threads:[~2023-10-09 9:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 9:09 [PATCH v5 00/15] Prerequisite changes for IOMMUFD support Eric Auger
2023-10-09 9:09 ` [PATCH v5 01/15] scripts/update-linux-headers: Add iommufd.h Eric Auger
2023-10-09 9:09 ` [PATCH v5 02/15] linux-headers: " Eric Auger
2023-10-09 9:09 ` [PATCH v5 03/15] vfio/common: Move IOMMU agnostic helpers to a separate file Eric Auger
2023-10-09 9:09 ` [PATCH v5 04/15] vfio/common: Propagate KVM_SET_DEVICE_ATTR error if any Eric Auger
2023-10-09 9:09 ` [PATCH v5 05/15] vfio/common: Introduce vfio_container_add|del_section_window() Eric Auger
2023-10-09 9:09 ` [PATCH v5 06/15] vfio/common: Extract out vfio_kvm_device_[add/del]_fd Eric Auger
2023-10-09 9:09 ` [PATCH v5 07/15] vfio/pci: Introduce vfio_[attach/detach]_device Eric Auger
2023-10-11 1:33 ` Duan, Zhenzhong
2023-10-11 20:11 ` Eric Auger
2023-10-09 9:09 ` [PATCH v5 08/15] vfio/platform: Use vfio_[attach/detach]_device Eric Auger
2023-10-09 9:09 ` [PATCH v5 09/15] vfio/ap: " Eric Auger
2023-10-09 9:09 ` [PATCH v5 10/15] vfio/ccw: " Eric Auger
2023-10-09 9:09 ` Eric Auger [this message]
2023-10-09 9:09 ` [PATCH v5 12/15] vfio/common: Introduce a per container device list Eric Auger
2023-10-09 9:09 ` [PATCH v5 13/15] vfio/common: Store the parent container in VFIODevice Eric Auger
2023-10-09 9:09 ` [PATCH v5 14/15] vfio/common: Introduce a global VFIODevice list Eric Auger
2023-10-09 9:09 ` [PATCH v5 15/15] vfio/common: Move legacy VFIO backend code into separate container.c Eric Auger
2023-10-09 12:58 ` [PATCH v5 00/15] Prerequisite changes for IOMMUFD support Cédric Le Goater
2023-10-09 13:38 ` Eric Auger
2023-10-09 13:53 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231009091035.433329-12-eric.auger@redhat.com \
--to=eric.auger@redhat.com \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=chao.p.peng@intel.com \
--cc=clg@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=jgg@nvidia.com \
--cc=joao.m.martins@oracle.com \
--cc=kevin.tian@intel.com \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yi.l.liu@intel.com \
--cc=yi.y.sun@intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.