All of lore.kernel.org
 help / color / mirror / Atom feed
From: Justin Tee <justintee8345@gmail.com>
To: linux-scsi@vger.kernel.org
Cc: jsmart2021@gmail.com, justin.tee@broadcom.com,
	Justin Tee <justintee8345@gmail.com>
Subject: [PATCH 1/6] lpfc: Remove unnecessary zero return code assignment in lpfc_sli4_hba_setup
Date: Mon,  9 Oct 2023 09:18:07 -0700	[thread overview]
Message-ID: <20231009161812.97232-2-justintee8345@gmail.com> (raw)
In-Reply-To: <20231009161812.97232-1-justintee8345@gmail.com>

In order to enter the !rc if statement block in question, rc had to have
been zero to begin with.  Thus, the rc = 0 assignment is unnecessary and
can be removed.

Signed-off-by: Justin Tee <justin.tee@broadcom.com>
---
 drivers/scsi/lpfc/lpfc_sli.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index 4dfadf254a72..9386e7b44750 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -8571,12 +8571,10 @@ lpfc_sli4_hba_setup(struct lpfc_hba *phba)
 	 * is not fatal as the driver will use generic values.
 	 */
 	rc = lpfc_parse_vpd(phba, vpd, vpd_size);
-	if (unlikely(!rc)) {
+	if (unlikely(!rc))
 		lpfc_printf_log(phba, KERN_ERR, LOG_TRACE_EVENT,
 				"0377 Error %d parsing vpd. "
 				"Using defaults.\n", rc);
-		rc = 0;
-	}
 	kfree(vpd);
 
 	/* Save information as VPD data */
-- 
2.38.0


  reply	other threads:[~2023-10-09 16:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-09 16:18 [PATCH 0/6] lpfc: Update lpfc to revision 14.2.0.15 Justin Tee
2023-10-09 16:18 ` Justin Tee [this message]
2023-10-09 16:18 ` [PATCH 2/6] lpfc: Treat IOERR_SLI_DOWN I/O completion status the same as pci offline Justin Tee
2023-10-09 16:18 ` [PATCH 3/6] lpfc: Reject received PRLIs with only initiator fcn role for NPIV ports Justin Tee
2023-10-09 16:18 ` [PATCH 4/6] lpfc: Validate ELS LS_ACC completion payload Justin Tee
2023-10-09 16:18 ` [PATCH 5/6] lpfc: Introduce LOG_NODE_VERBOSE messaging flag Justin Tee
2023-10-09 16:18 ` [PATCH 6/6] lpfc: Update lpfc version to 14.2.0.15 Justin Tee
2023-10-13 21:01 ` [PATCH 0/6] lpfc: Update lpfc to revision 14.2.0.15 Martin K. Petersen
2023-10-17  1:11 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231009161812.97232-2-justintee8345@gmail.com \
    --to=justintee8345@gmail.com \
    --cc=jsmart2021@gmail.com \
    --cc=justin.tee@broadcom.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.