From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2765DE95A91 for ; Mon, 9 Oct 2023 14:28:04 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BB243E76; Mon, 9 Oct 2023 16:27:11 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BB243E76 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1696861681; bh=ljxI79VSLdpuEWZfBxqV1cAB7oJH2+DiQSs7TZlu8+Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=bO8WdSQg5ixCow0IG8UXLoE87nf5YGsafXDAFw72oyf+3duQj6PJ034Zt8X4U/5Pb hlovbTEgXZuHp1rI9KgrK444ar/5ufSIADu/e7BzMohHyxBbgSjLOzDMjcVfmNQeYg 8A2WcLefD4PbPmfJxLymYlzJk/2y4OqxkOoQrsdQ= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2C366F80553; Mon, 9 Oct 2023 16:26:50 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 9BC09F802BE; Mon, 9 Oct 2023 16:26:50 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A4FC4F802BE; Mon, 9 Oct 2023 16:26:46 +0200 (CEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 60B97F80130 for ; Mon, 9 Oct 2023 16:26:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 60B97F80130 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=ptdUM/7c Received: by mail.gandi.net (Postfix) with ESMTPSA id 2E7FF60003; Mon, 9 Oct 2023 14:26:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1696861598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=92a8cVu3f6Pk3ndmVwnkeBH7DnuU13PZsLWlEFgkb+8=; b=ptdUM/7cMSJVYbBrfF6v7pOBngBBoqD2a0R/MUuEMeanPcoDEjfHKfSoM8A8bH79+drPz+ rV97RU0p5QyeWtYFPXNPPjzGoSwoAmb7zdtM9zta8Rt3qazcKpntePvK1epyDuMN8Yy2hm c/19/YApYNnYXqqPcSlzxHZDNltzGOFF0avCXI1W6tyEQLx7YzapC/yKZuEgCSulDYhE2G tiyCi8WMCoTIVnh6t72FOyCiEhCyW0D3+DoI+D5rSdROAfpCBAIJTfQNC5r7tEla35zU7C xa3pdnMAu7WiFZoTgbzZKx+vu0/qFQeygmLxg4z1lzB3Rw48ksl43ELSnmswNA== Date: Mon, 9 Oct 2023 16:26:32 +0200 From: Herve Codina To: Jakub Kicinski Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Andrew Lunn , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Simon Horman , Christophe JAILLET , Thomas Petazzoni Subject: Re: [PATCH v7 10/30] net: wan: Add support for QMC HDLC Message-ID: <20231009162632.7f11a6d9@bootlin.com> In-Reply-To: <20231006144702.778c165e@kernel.org> References: <20230928070652.330429-1-herve.codina@bootlin.com> <20230928070652.330429-11-herve.codina@bootlin.com> <20231006144702.778c165e@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com Message-ID-Hash: AKSRLKIX5PJMKWTLWK4EGYCTUPH7HHZV X-Message-ID-Hash: AKSRLKIX5PJMKWTLWK4EGYCTUPH7HHZV X-MailFrom: herve.codina@bootlin.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Jakub, On Fri, 6 Oct 2023 14:47:02 -0700 Jakub Kicinski wrote: > On Thu, 28 Sep 2023 09:06:28 +0200 Herve Codina wrote: > > +static int qmc_hdlc_close(struct net_device *netdev) > > +{ > > + struct qmc_hdlc *qmc_hdlc = netdev_to_qmc_hdlc(netdev); > > + struct qmc_hdlc_desc *desc; > > + int i; > > + > > + netif_stop_queue(netdev); > > + > > + qmc_chan_stop(qmc_hdlc->qmc_chan, QMC_CHAN_ALL); > > + qmc_chan_reset(qmc_hdlc->qmc_chan, QMC_CHAN_ALL); > > stopping the queue looks a bit racy, a completion may come in > and restart the queue Indeed, qmc_hdlc_xmit_complete() completion can restart the queue. I will call netif_stop_queue() after calling qmc_chan_stop/reset(). This is the simple way to fix that without adding an internal flag. Thanks for pointing that. Best regards, Hervé > > > + for (i = 0; i < ARRAY_SIZE(qmc_hdlc->tx_descs); i++) { > > + desc = &qmc_hdlc->tx_descs[i]; > > + if (!desc->skb) > > + continue; > > + dma_unmap_single(qmc_hdlc->dev, desc->dma_addr, desc->dma_size, > > + DMA_TO_DEVICE); > > + kfree_skb(desc->skb); > > + desc->skb = NULL; > > + } > > + > > + for (i = 0; i < ARRAY_SIZE(qmc_hdlc->rx_descs); i++) { > > + desc = &qmc_hdlc->rx_descs[i]; > > + if (!desc->skb) > > + continue; > > + dma_unmap_single(qmc_hdlc->dev, desc->dma_addr, desc->dma_size, > > + DMA_FROM_DEVICE); > > + kfree_skb(desc->skb); > > + desc->skb = NULL; > > + } > > + > > + hdlc_close(netdev); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CABC1E95A8E for ; Mon, 9 Oct 2023 14:27:39 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=ptdUM/7c; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4S41Zy3QVsz3dFL for ; Tue, 10 Oct 2023 01:27:38 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=ptdUM/7c; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=217.70.183.195; helo=relay3-d.mail.gandi.net; envelope-from=herve.codina@bootlin.com; receiver=lists.ozlabs.org) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4S41Yy4FDJz2yts for ; Tue, 10 Oct 2023 01:26:44 +1100 (AEDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 2E7FF60003; Mon, 9 Oct 2023 14:26:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1696861598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=92a8cVu3f6Pk3ndmVwnkeBH7DnuU13PZsLWlEFgkb+8=; b=ptdUM/7cMSJVYbBrfF6v7pOBngBBoqD2a0R/MUuEMeanPcoDEjfHKfSoM8A8bH79+drPz+ rV97RU0p5QyeWtYFPXNPPjzGoSwoAmb7zdtM9zta8Rt3qazcKpntePvK1epyDuMN8Yy2hm c/19/YApYNnYXqqPcSlzxHZDNltzGOFF0avCXI1W6tyEQLx7YzapC/yKZuEgCSulDYhE2G tiyCi8WMCoTIVnh6t72FOyCiEhCyW0D3+DoI+D5rSdROAfpCBAIJTfQNC5r7tEla35zU7C xa3pdnMAu7WiFZoTgbzZKx+vu0/qFQeygmLxg4z1lzB3Rw48ksl43ELSnmswNA== Date: Mon, 9 Oct 2023 16:26:32 +0200 From: Herve Codina To: Jakub Kicinski Subject: Re: [PATCH v7 10/30] net: wan: Add support for QMC HDLC Message-ID: <20231009162632.7f11a6d9@bootlin.com> In-Reply-To: <20231006144702.778c165e@kernel.org> References: <20230928070652.330429-1-herve.codina@bootlin.com> <20230928070652.330429-11-herve.codina@bootlin.com> <20231006144702.778c165e@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , alsa-devel@alsa-project.org, Thomas Petazzoni , Xiubo Li , Linus Walleij , Liam Girdwood , Eric Dumazet , Krzysztof Kozlowski , Fabio Estevam , Qiang Zhao , Shengjiu Wang , Paolo Abeni , devicetree@vger.kernel.org, Conor Dooley , linux-kernel@vger.kernel.org, Nicolin Chen , linux-gpio@vger.kernel.org, Rob Herring , Christophe JAILLET , Jaroslav Kysela , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Randy Dunlap , Takashi Iwai , Li Yang , Mark Brown , Simon Horman , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Jakub, On Fri, 6 Oct 2023 14:47:02 -0700 Jakub Kicinski wrote: > On Thu, 28 Sep 2023 09:06:28 +0200 Herve Codina wrote: > > +static int qmc_hdlc_close(struct net_device *netdev) > > +{ > > + struct qmc_hdlc *qmc_hdlc = netdev_to_qmc_hdlc(netdev); > > + struct qmc_hdlc_desc *desc; > > + int i; > > + > > + netif_stop_queue(netdev); > > + > > + qmc_chan_stop(qmc_hdlc->qmc_chan, QMC_CHAN_ALL); > > + qmc_chan_reset(qmc_hdlc->qmc_chan, QMC_CHAN_ALL); > > stopping the queue looks a bit racy, a completion may come in > and restart the queue Indeed, qmc_hdlc_xmit_complete() completion can restart the queue. I will call netif_stop_queue() after calling qmc_chan_stop/reset(). This is the simple way to fix that without adding an internal flag. Thanks for pointing that. Best regards, Hervé > > > + for (i = 0; i < ARRAY_SIZE(qmc_hdlc->tx_descs); i++) { > > + desc = &qmc_hdlc->tx_descs[i]; > > + if (!desc->skb) > > + continue; > > + dma_unmap_single(qmc_hdlc->dev, desc->dma_addr, desc->dma_size, > > + DMA_TO_DEVICE); > > + kfree_skb(desc->skb); > > + desc->skb = NULL; > > + } > > + > > + for (i = 0; i < ARRAY_SIZE(qmc_hdlc->rx_descs); i++) { > > + desc = &qmc_hdlc->rx_descs[i]; > > + if (!desc->skb) > > + continue; > > + dma_unmap_single(qmc_hdlc->dev, desc->dma_addr, desc->dma_size, > > + DMA_FROM_DEVICE); > > + kfree_skb(desc->skb); > > + desc->skb = NULL; > > + } > > + > > + hdlc_close(netdev); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6B62E95A8E for ; Mon, 9 Oct 2023 14:27:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CjIH5bhDM6EtQrk6QR+MuiwQ8tf4kNYrl8vYxw5pYD4=; b=sdpEQBuPlFOjft 7EOOWjBjT9+p1N6C2up/RBkoqrUDzVRVcjHkjvWOPVZlX+duM+DnL0USxQ5SYhbJnoHgspIcTpQMC L30g3b3ZUdBcApNfPFmzo0Ft1KJqw5t3zYxPYJBMJ13YXaVHohjUeKCpyuujo8iNVDGwH6w4O4kh4 jIjUEuoik8oCVoHQZmNfTEXDSpL1fZza2LMdTjln7t/3+cNAovx+FjsLsk4vAReGyaAr67xxjPlZG zcppM0rtnLnOrZd8sOakj2VUVsAn4LSC4QK6TgP4QcHVKJkZibXQZNE5d9hSltQsoDOLrzgpZDZbC 3ZZxHv0YIcrwPVgNQ8ZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qprDb-00AvU3-0X; Mon, 09 Oct 2023 14:26:47 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qprDY-00AvSh-1g for linux-arm-kernel@lists.infradead.org; Mon, 09 Oct 2023 14:26:46 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 2E7FF60003; Mon, 9 Oct 2023 14:26:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1696861598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=92a8cVu3f6Pk3ndmVwnkeBH7DnuU13PZsLWlEFgkb+8=; b=ptdUM/7cMSJVYbBrfF6v7pOBngBBoqD2a0R/MUuEMeanPcoDEjfHKfSoM8A8bH79+drPz+ rV97RU0p5QyeWtYFPXNPPjzGoSwoAmb7zdtM9zta8Rt3qazcKpntePvK1epyDuMN8Yy2hm c/19/YApYNnYXqqPcSlzxHZDNltzGOFF0avCXI1W6tyEQLx7YzapC/yKZuEgCSulDYhE2G tiyCi8WMCoTIVnh6t72FOyCiEhCyW0D3+DoI+D5rSdROAfpCBAIJTfQNC5r7tEla35zU7C xa3pdnMAu7WiFZoTgbzZKx+vu0/qFQeygmLxg4z1lzB3Rw48ksl43ELSnmswNA== Date: Mon, 9 Oct 2023 16:26:32 +0200 From: Herve Codina To: Jakub Kicinski Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Andrew Lunn , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Simon Horman , Christophe JAILLET , Thomas Petazzoni Subject: Re: [PATCH v7 10/30] net: wan: Add support for QMC HDLC Message-ID: <20231009162632.7f11a6d9@bootlin.com> In-Reply-To: <20231006144702.778c165e@kernel.org> References: <20230928070652.330429-1-herve.codina@bootlin.com> <20230928070652.330429-11-herve.codina@bootlin.com> <20231006144702.778c165e@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: herve.codina@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231009_072644_863853_725B0092 X-CRM114-Status: GOOD ( 14.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgSmFrdWIsCgpPbiBGcmksIDYgT2N0IDIwMjMgMTQ6NDc6MDIgLTA3MDAKSmFrdWIgS2ljaW5z a2kgPGt1YmFAa2VybmVsLm9yZz4gd3JvdGU6Cgo+IE9uIFRodSwgMjggU2VwIDIwMjMgMDk6MDY6 MjggKzAyMDAgSGVydmUgQ29kaW5hIHdyb3RlOgo+ID4gK3N0YXRpYyBpbnQgcW1jX2hkbGNfY2xv c2Uoc3RydWN0IG5ldF9kZXZpY2UgKm5ldGRldikKPiA+ICt7Cj4gPiArCXN0cnVjdCBxbWNfaGRs YyAqcW1jX2hkbGMgPSBuZXRkZXZfdG9fcW1jX2hkbGMobmV0ZGV2KTsKPiA+ICsJc3RydWN0IHFt Y19oZGxjX2Rlc2MgKmRlc2M7Cj4gPiArCWludCBpOwo+ID4gKwo+ID4gKwluZXRpZl9zdG9wX3F1 ZXVlKG5ldGRldik7Cj4gPiArCj4gPiArCXFtY19jaGFuX3N0b3AocW1jX2hkbGMtPnFtY19jaGFu LCBRTUNfQ0hBTl9BTEwpOwo+ID4gKwlxbWNfY2hhbl9yZXNldChxbWNfaGRsYy0+cW1jX2NoYW4s IFFNQ19DSEFOX0FMTCk7ICAKPiAKPiBzdG9wcGluZyB0aGUgcXVldWUgbG9va3MgYSBiaXQgcmFj eSwgYSBjb21wbGV0aW9uIG1heSBjb21lIGluIAo+IGFuZCByZXN0YXJ0IHRoZSBxdWV1ZQoKSW5k ZWVkLCBxbWNfaGRsY194bWl0X2NvbXBsZXRlKCkgY29tcGxldGlvbiBjYW4gcmVzdGFydCB0aGUg cXVldWUuCgpJIHdpbGwgY2FsbCBuZXRpZl9zdG9wX3F1ZXVlKCkgYWZ0ZXIgY2FsbGluZyBxbWNf Y2hhbl9zdG9wL3Jlc2V0KCkuClRoaXMgaXMgdGhlIHNpbXBsZSB3YXkgdG8gZml4IHRoYXQgd2l0 aG91dCBhZGRpbmcgYW4gaW50ZXJuYWwgZmxhZy4KClRoYW5rcyBmb3IgcG9pbnRpbmcgdGhhdC4K CkJlc3QgcmVnYXJkcywKSGVydsOpCgo+IAo+ID4gKwlmb3IgKGkgPSAwOyBpIDwgQVJSQVlfU0la RShxbWNfaGRsYy0+dHhfZGVzY3MpOyBpKyspIHsKPiA+ICsJCWRlc2MgPSAmcW1jX2hkbGMtPnR4 X2Rlc2NzW2ldOwo+ID4gKwkJaWYgKCFkZXNjLT5za2IpCj4gPiArCQkJY29udGludWU7Cj4gPiAr CQlkbWFfdW5tYXBfc2luZ2xlKHFtY19oZGxjLT5kZXYsIGRlc2MtPmRtYV9hZGRyLCBkZXNjLT5k bWFfc2l6ZSwKPiA+ICsJCQkJIERNQV9UT19ERVZJQ0UpOwo+ID4gKwkJa2ZyZWVfc2tiKGRlc2Mt PnNrYik7Cj4gPiArCQlkZXNjLT5za2IgPSBOVUxMOwo+ID4gKwl9Cj4gPiArCj4gPiArCWZvciAo aSA9IDA7IGkgPCBBUlJBWV9TSVpFKHFtY19oZGxjLT5yeF9kZXNjcyk7IGkrKykgewo+ID4gKwkJ ZGVzYyA9ICZxbWNfaGRsYy0+cnhfZGVzY3NbaV07Cj4gPiArCQlpZiAoIWRlc2MtPnNrYikKPiA+ ICsJCQljb250aW51ZTsKPiA+ICsJCWRtYV91bm1hcF9zaW5nbGUocW1jX2hkbGMtPmRldiwgZGVz Yy0+ZG1hX2FkZHIsIGRlc2MtPmRtYV9zaXplLAo+ID4gKwkJCQkgRE1BX0ZST01fREVWSUNFKTsK PiA+ICsJCWtmcmVlX3NrYihkZXNjLT5za2IpOwo+ID4gKwkJZGVzYy0+c2tiID0gTlVMTDsKPiA+ ICsJfQo+ID4gKwo+ID4gKwloZGxjX2Nsb3NlKG5ldGRldik7ICAKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBs aXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK