From: Denys Dmytriyenko <denis@denix.org>
To: r-gunasekaran@ti.com
Cc: meta-ti@lists.yoctoproject.org, reatmon@ti.com, praneeth@ti.com,
srk@ti.com, afd@ti.com
Subject: Re: [meta-ti] [kirkstone][PATCH v3 1/2] preuth-fw: Remove packaging of PRU-ICSSM firmwares
Date: Mon, 9 Oct 2023 16:20:27 -0400 [thread overview]
Message-ID: <20231009202027.GD2408@denix.org> (raw)
In-Reply-To: <20231009070926.21629-2-r-gunasekaran@ti.com>
On Mon, Oct 09, 2023 at 12:39:25PM +0530, Ravi Gunasekaran via lists.yoctoproject.org wrote:
> PRU-ICSS on AM33x, AM43x, supports different ethernet modes such
> as Ethernet, HSR and PRP by means of different firmwares and the
> driver loads one of the these firmware. The PRU-ICSS linux driver
> may not be available for all kernel versions.
>
> So add an .inc file that avoids the packaging of such firmwares
> in the SDK, so that it can be referenced by kernel recipes that
> don't support PRU-ICSS.
>
> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
> ---
> meta-ti-bsp/recipes-kernel/linux/prueth-fw.inc | 3 +++
> 1 file changed, 3 insertions(+)
> create mode 100644 meta-ti-bsp/recipes-kernel/linux/prueth-fw.inc
>
> diff --git a/meta-ti-bsp/recipes-kernel/linux/prueth-fw.inc b/meta-ti-bsp/recipes-kernel/linux/prueth-fw.inc
> new file mode 100644
> index 00000000..6698c9ed
> --- /dev/null
> +++ b/meta-ti-bsp/recipes-kernel/linux/prueth-fw.inc
> @@ -0,0 +1,3 @@
> +# Do not package firmwares for kernels that don't support PRUETH
> +RDEPENDS:${KERNEL_PACKAGE_NAME}-base:remove:ti43x = " prueth-fw pruhsr-fw pruprp-fw"
> +RDEPENDS:${KERNEL_PACKAGE_NAME}-base:remove:ti33x = " prueth-fw pruhsr-fw pruprp-fw"
This is asking for trouble - there's no way to un-do :remove downstream (e.g.
any of the Distro, SDK, Product Line or Customer layers)
It is not recommended to use :remove (and :append to a lesser degree) on a
regular basis when it can be done differently.
Moreover, what is a difference from v2? It is a more convoluted way to drop
those FW images from getting installed, but it is still done unconditionally
here in meta-ti - are there any benefits of doing it this way?
--
Denys
next prev parent reply other threads:[~2023-10-09 20:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 7:09 [kirkstone][PATCH v3 0/2] Remove PRU Ethernet firmwares for legacy devices Ravi Gunasekaran
2023-10-09 7:09 ` [kirkstone][PATCH v3 1/2] preuth-fw: Remove packaging of PRU-ICSSM firmwares Ravi Gunasekaran
2023-10-09 20:20 ` Denys Dmytriyenko [this message]
2023-10-09 21:25 ` [meta-ti] " Ryan Eatmon
2023-10-09 21:33 ` Andrew Davis
2023-10-10 4:23 ` Ravi Gunasekaran
2023-10-20 22:20 ` Ryan Eatmon
2023-10-23 4:49 ` Ravi Gunasekaran
2023-10-23 13:56 ` Ryan Eatmon
2023-10-09 7:09 ` [kirkstone][PATCH v3 2/2] linux-ti-staging_6.1: " Ravi Gunasekaran
2023-10-09 17:23 ` [kirkstone][PATCH v3 0/2] Remove PRU Ethernet firmwares for legacy devices Bajjuri, Praneeth
2023-10-09 20:03 ` [meta-ti] " Denys Dmytriyenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231009202027.GD2408@denix.org \
--to=denis@denix.org \
--cc=afd@ti.com \
--cc=meta-ti@lists.yoctoproject.org \
--cc=praneeth@ti.com \
--cc=r-gunasekaran@ti.com \
--cc=reatmon@ti.com \
--cc=srk@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.