From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32BA4E9371F for ; Mon, 9 Oct 2023 23:30:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378152AbjJIXa6 (ORCPT ); Mon, 9 Oct 2023 19:30:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379010AbjJIXa6 (ORCPT ); Mon, 9 Oct 2023 19:30:58 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9DDF9D for ; Mon, 9 Oct 2023 16:30:56 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C95BC433C8; Mon, 9 Oct 2023 23:30:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1696894256; bh=R+MmYalGD/xqmAWQd2+ffAjpt9fsU21QPY3DJMzXVUM=; h=Date:To:From:Subject:From; b=ZGEtzer4NTF4kZE1EUvUD5jIkThF3j+ylGHiQ6Fb+0hL64OLGDR2AfOed8tXWunB6 cOtHJI+hMITGuH4FwvhFi528XNFIzxu/SXCTyXR0pR32RCxlslZ0tPPcvGnSGIrng4 EftqUUsu+FhTvEaJbDolxxXST9EkO7t1LhThIEsk= Date: Mon, 09 Oct 2023 16:30:45 -0700 To: mm-commits@vger.kernel.org, shuah@kernel.org, hughd@google.com, adobriyan@gmail.com, swarupkotikalapudi@gmail.com, akpm@linux-foundation.org From: Andrew Morton Subject: + selftests-proc-add-proc-pid-statm-output-validation.patch added to mm-nonmm-unstable branch Message-Id: <20231009233054.7C95BC433C8@smtp.kernel.org> Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org The patch titled Subject: selftests:proc add /proc/$(pid)/statm output validation has been added to the -mm mm-nonmm-unstable branch. Its filename is selftests-proc-add-proc-pid-statm-output-validation.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/selftests-proc-add-proc-pid-statm-output-validation.patch This patch will later appear in the mm-nonmm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Swarup Laxman Kotiaklapudi Subject: selftests:proc add /proc/$(pid)/statm output validation Date: Tue, 10 Oct 2023 00:50:10 +0530 Add /proc/${pid}/statm validation /proc/$(pid)/statm output is expected to be: "0 0 0 * 0 0 0\n" Here * can be any value Read output of /proc/$(pid)/statm and check except for 4th position, all other positions have value zero. Link: https://lkml.kernel.org/r/20231009192010.10456-1-swarupkotikalapudi@gmail.com Fixes: 5bc73bb3451b (proc: test how it holds up with mapping'less process) Signed-off-by: Swarup Laxman Kotiaklapudi Cc: Alexey Dobriyan Cc: Hugh Dickins Cc: Shuah Khan Signed-off-by: Andrew Morton --- tools/testing/selftests/proc/proc-empty-vm.c | 60 +++++++++++++++-- 1 file changed, 55 insertions(+), 5 deletions(-) --- a/tools/testing/selftests/proc/proc-empty-vm.c~selftests-proc-add-proc-pid-statm-output-validation +++ a/tools/testing/selftests/proc/proc-empty-vm.c @@ -38,6 +38,8 @@ #include #include +#include "../kselftest.h" + #ifdef __amd64__ #define TEST_VSYSCALL #endif @@ -303,6 +305,57 @@ static int test_proc_pid_smaps_rollup(pi } } +static int test_proc_pid_statm(pid_t pid) +{ + char buf[4096]; + char *tok; + char *string, *p; + int non_zero_value_indx = 4; + int i = 1, len; + size_t left; + + snprintf(buf, sizeof(buf), "/proc/%u/statm", pid); + + /* + * Output can be "0 0 0 2 0 0 0\n" where "2" can be anything. + */ + int fd = open(buf, O_RDONLY); + + if (fd == -1) { + if (errno == ENOENT) { + return EXIT_SUCCESS; + } + perror("open /proc/${pid}/statm"); + return EXIT_FAILURE; + } else { + memset(buf, 0, sizeof(buf)); + left = ARRAY_SIZE(buf); + p = buf; + while ((len = read(fd, p, left)) > 0) { + p += len; + left -= len; + } + close(fd); + string = buf; + + while ((tok = strsep(&string, " ")) != NULL) { + if (i == non_zero_value_indx) { + if (!strncmp(tok, "0", 1)) + goto err_statm; + } else { + if (strncmp(tok, "0", 1)) + goto err_statm; + } + i++; + } + } + + return EXIT_SUCCESS; + +err_statm: + assert(0); +} + int main(void) { int rv = EXIT_SUCCESS; @@ -389,11 +442,8 @@ int main(void) if (rv == EXIT_SUCCESS) { rv = test_proc_pid_smaps_rollup(pid); } - /* - * TODO test /proc/${pid}/statm, task_statm() - * ->start_code, ->end_code aren't updated by munmap(). - * Output can be "0 0 0 2 0 0 0\n" where "2" can be anything. - */ + if (rv == EXIT_SUCCESS) + rv = test_proc_pid_statm(pid); /* Cut the rope. */ int wstatus; _ Patches currently in -mm which might be from swarupkotikalapudi@gmail.com are selftests-proc-add-proc-pid-statm-output-validation.patch