From: Shawn Guo <shawnguo@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH 1/2] ARM: mxs: Add serial: Search for specific ocotp nodes
Date: Tue, 10 Oct 2023 10:44:04 +0800 [thread overview]
Message-ID: <20231010024404.GP819755@dragon> (raw)
In-Reply-To: <20231009173740.3535167-1-festevam@gmail.com>
On Mon, Oct 09, 2023 at 02:37:39PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> Per mxs-ocotp.yaml, "fsl,ocotp" is not a valid entry.
>
> "fsl,ocotp" is only used to indicate the location of the
> struct device_node that points to the ocotp node.
>
> Search for the specific "fsl,imx28-ocotp" and "fsl,imx23-ocotp"
> instead and remove the undocumented "fsl,ocotp" fallback.
Since the compatible is being used, can we document it instead?
Shawn
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> arch/arm/mach-mxs/mach-mxs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-mxs/mach-mxs.c b/arch/arm/mach-mxs/mach-mxs.c
> index 3faf9a1e3e36..d16e638990da 100644
> --- a/arch/arm/mach-mxs/mach-mxs.c
> +++ b/arch/arm/mach-mxs/mach-mxs.c
> @@ -94,7 +94,9 @@ static const u32 *mxs_get_ocotp(void)
> if (once)
> return ocotp_words;
>
> - np = of_find_compatible_node(NULL, NULL, "fsl,ocotp");
> + np = of_find_compatible_node(NULL, NULL, "fsl,imx28-ocotp");
> + if (!np)
> + np = of_find_compatible_node(NULL, NULL, "fsl,imx23-ocotp");
> ocotp_base = of_iomap(np, 0);
> WARN_ON(!ocotp_base);
>
> --
> 2.34.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-10-10 2:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 17:37 [PATCH 1/2] ARM: mxs: Add serial: Search for specific ocotp nodes Fabio Estevam
2023-10-09 17:37 ` [PATCH 2/2] ARM: dts: mxs: Remove fsl,ocotp Fabio Estevam
2023-10-10 2:44 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231010024404.GP819755@dragon \
--to=shawnguo@kernel.org \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.