From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51E62CD68F9 for ; Tue, 10 Oct 2023 08:01:28 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 546D8103A; Tue, 10 Oct 2023 10:00:36 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 546D8103A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1696924886; bh=AN7ELeTSudhhQMwXqFObqw5NBfIIZyn8BBnr1/0eo2Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=dkOS4ZW4yV0oRoTfLVMkqA34eNI+JaRhXKhYGzSZ2oiSd8gk6WPlgIqQvXnYhVIqc QrgzCECCoEldUsVSNbXQ7NVCNfywoWpg3Hk7gG16XCH/ZInQs8rO8B5O10bkXsEvKW 2SVyJxman5/qJ+R5ZBuY2KjO7lPWCAL7FxFBuTMo= Received: by alsa1.perex.cz (Postfix, from userid 50401) id A6510F80536; Tue, 10 Oct 2023 10:00:25 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id BFD3AF802BE; Tue, 10 Oct 2023 10:00:23 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6E369F802BE; Tue, 10 Oct 2023 09:57:51 +0200 (CEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::226]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id F2BC8F80166 for ; Tue, 10 Oct 2023 09:57:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz F2BC8F80166 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=UAlqB76M Received: by mail.gandi.net (Postfix) with ESMTPSA id D7D45C0017; Tue, 10 Oct 2023 07:57:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1696924659; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8HGCDW6dA/uAJ0GZAXHKMPSuwZNEP4AsO/ZK/lFHFUk=; b=UAlqB76MFympUYcFakSns2mIOgF13pHihMAEYgL1b92u9tsMq8XEVIkpDSc2USgjXn29Dj teMJY1lY51yixmRurzbAu6X/It5Prspi6Id1Wa32QHK/EHhiboyV1E/GwksW+XgJBr/BD+ gMzW3HEboeZULdc0q/po4tOFO145hK5LVo9/hA9YMl3NC5d4IgxP0MpIywwHIVhWpcYl7C 742U/PmD0Bnm2nlDzGfyngXvb5P5pZawz1yZlpNRIWYKL94NO72XcNjZfdd26znmNKgahB ft3/z9/2lF6GWH7GXWiTQEQSVY54kM8V13b7SYnq1pYaTJi9zxGcx8zm4m1HJA== Date: Tue, 10 Oct 2023 09:57:33 +0200 From: Herve Codina To: Jakub Kicinski Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Andrew Lunn , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Simon Horman , Christophe JAILLET , Thomas Petazzoni Subject: Re: [PATCH v7 24/30] net: wan: Add framer framework support Message-ID: <20231010095733.6899abbb@bootlin.com> In-Reply-To: <20231006150810.09e2c1a9@kernel.org> References: <20230928070652.330429-1-herve.codina@bootlin.com> <20230928070652.330429-25-herve.codina@bootlin.com> <20231006150810.09e2c1a9@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com Message-ID-Hash: OTH3PY4MW5XWUMQTHAJ5QR5MH4NKUI4K X-Message-ID-Hash: OTH3PY4MW5XWUMQTHAJ5QR5MH4NKUI4K X-MailFrom: herve.codina@bootlin.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Jakub On Fri, 6 Oct 2023 15:08:10 -0700 Jakub Kicinski wrote: > On Thu, 28 Sep 2023 09:06:42 +0200 Herve Codina wrote: > > +menu "Framer Subsystem" > > + > > +config GENERIC_FRAMER > > + bool "Framer Core" > > + help > > + Generic Framer support. > > + A framer is a component in charge of an E1/T1 line interface. > > + Connected usually to a TDM bus, it converts TDM frames to/from E1/T1 > > + frames. It also provides information related to the E1/T1 line. > > + Used with HDLC, the network can be reached through the E1/T1 line. > > + > > + This framework is designed to provide a generic interface for framer > > + devices present in the kernel. This layer will have the generic > > + API by which framer drivers can create framer using the framer > > + framework and framer users can obtain reference to the framer. > > + All the users of this framework should select this config. > > maybe make the menu a menuconfig with info about framers but hide > the GENERIC_FRAMER symbol? The driver 'select' it anyway, what's > the point of prompting the user.. Yes, I will change in the next iteration. > > > + if (WARN_ON(!dev)) > > + return ERR_PTR(-EINVAL); > > no defensive programming, let the kernel crash Will be changed. > > > + ret = framer_pm_runtime_get_sync(framer); > > + if (ret < 0 && ret != -EOPNOTSUPP) > > + goto err_pm_sync; > > + > > + ret = 0; /* Override possible ret == -EOPNOTSUPP */ > > This looks pointless given that ret is either overwritten or not used > later on Indeed. Will be removed in the next iteration. > > > + mutex_lock(&framer->mutex); > > + if (framer->power_count == 0 && framer->ops->power_on) { > > + ret = framer->ops->power_on(framer); > > + if (ret < 0) { > > + dev_err(&framer->dev, "framer poweron failed --> %d\n", ret); > > + goto err_pwr_on; > > + } > > + } > > + ++framer->power_count; > > + mutex_unlock(&framer->mutex); > > + return 0; Best regards, Hervé From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 516F3CD68F9 for ; Tue, 10 Oct 2023 07:58:45 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=UAlqB76M; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4S4Svl33Kmz3cX7 for ; Tue, 10 Oct 2023 18:58:43 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=UAlqB76M; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=2001:4b98:dc4:8::226; helo=relay6-d.mail.gandi.net; envelope-from=herve.codina@bootlin.com; receiver=lists.ozlabs.org) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::226]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4S4Stn408jz2xdY for ; Tue, 10 Oct 2023 18:57:50 +1100 (AEDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id D7D45C0017; Tue, 10 Oct 2023 07:57:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1696924659; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8HGCDW6dA/uAJ0GZAXHKMPSuwZNEP4AsO/ZK/lFHFUk=; b=UAlqB76MFympUYcFakSns2mIOgF13pHihMAEYgL1b92u9tsMq8XEVIkpDSc2USgjXn29Dj teMJY1lY51yixmRurzbAu6X/It5Prspi6Id1Wa32QHK/EHhiboyV1E/GwksW+XgJBr/BD+ gMzW3HEboeZULdc0q/po4tOFO145hK5LVo9/hA9YMl3NC5d4IgxP0MpIywwHIVhWpcYl7C 742U/PmD0Bnm2nlDzGfyngXvb5P5pZawz1yZlpNRIWYKL94NO72XcNjZfdd26znmNKgahB ft3/z9/2lF6GWH7GXWiTQEQSVY54kM8V13b7SYnq1pYaTJi9zxGcx8zm4m1HJA== Date: Tue, 10 Oct 2023 09:57:33 +0200 From: Herve Codina To: Jakub Kicinski Subject: Re: [PATCH v7 24/30] net: wan: Add framer framework support Message-ID: <20231010095733.6899abbb@bootlin.com> In-Reply-To: <20231006150810.09e2c1a9@kernel.org> References: <20230928070652.330429-1-herve.codina@bootlin.com> <20230928070652.330429-25-herve.codina@bootlin.com> <20231006150810.09e2c1a9@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , alsa-devel@alsa-project.org, Thomas Petazzoni , Xiubo Li , Linus Walleij , Liam Girdwood , Eric Dumazet , Krzysztof Kozlowski , Fabio Estevam , Qiang Zhao , Shengjiu Wang , Paolo Abeni , devicetree@vger.kernel.org, Conor Dooley , linux-kernel@vger.kernel.org, Nicolin Chen , linux-gpio@vger.kernel.org, Rob Herring , Christophe JAILLET , Jaroslav Kysela , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Randy Dunlap , Takashi Iwai , Li Yang , Mark Brown , Simon Horman , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Jakub On Fri, 6 Oct 2023 15:08:10 -0700 Jakub Kicinski wrote: > On Thu, 28 Sep 2023 09:06:42 +0200 Herve Codina wrote: > > +menu "Framer Subsystem" > > + > > +config GENERIC_FRAMER > > + bool "Framer Core" > > + help > > + Generic Framer support. > > + A framer is a component in charge of an E1/T1 line interface. > > + Connected usually to a TDM bus, it converts TDM frames to/from E1/T1 > > + frames. It also provides information related to the E1/T1 line. > > + Used with HDLC, the network can be reached through the E1/T1 line. > > + > > + This framework is designed to provide a generic interface for framer > > + devices present in the kernel. This layer will have the generic > > + API by which framer drivers can create framer using the framer > > + framework and framer users can obtain reference to the framer. > > + All the users of this framework should select this config. > > maybe make the menu a menuconfig with info about framers but hide > the GENERIC_FRAMER symbol? The driver 'select' it anyway, what's > the point of prompting the user.. Yes, I will change in the next iteration. > > > + if (WARN_ON(!dev)) > > + return ERR_PTR(-EINVAL); > > no defensive programming, let the kernel crash Will be changed. > > > + ret = framer_pm_runtime_get_sync(framer); > > + if (ret < 0 && ret != -EOPNOTSUPP) > > + goto err_pm_sync; > > + > > + ret = 0; /* Override possible ret == -EOPNOTSUPP */ > > This looks pointless given that ret is either overwritten or not used > later on Indeed. Will be removed in the next iteration. > > > + mutex_lock(&framer->mutex); > > + if (framer->power_count == 0 && framer->ops->power_on) { > > + ret = framer->ops->power_on(framer); > > + if (ret < 0) { > > + dev_err(&framer->dev, "framer poweron failed --> %d\n", ret); > > + goto err_pwr_on; > > + } > > + } > > + ++framer->power_count; > > + mutex_unlock(&framer->mutex); > > + return 0; Best regards, Hervé From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9B56CD68F9 for ; Tue, 10 Oct 2023 07:58:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Zf/1IeYM9ABs8o0ah3aU2wa/SVbEXJyR8LrO+w8C1Wo=; b=uZuVw9QyNKdF5x hXXtulf0/U7U7wmYOROWcFjbJBmwctFAIzMqrGf9xvSUTbnqrzoUSH8OEKWMJTvaD9pn1CxPV0BRz XxxKpy1P9345b8eq3TMeVh/nynqY5VQgNDnEEk/t/Cmn/6Wa3lpm+2TtccAvYdDzNtCkSlYAFgskm MDu6ZNmHPQSVcAFfE8gYA8B4URYqM6nb82TVFeqkrjtbAsXagMwG8+SDsbHH4dB01gWy+qZE3ARmE bSOpiv3udJ6ZZVdzpeg0ZBFOk+FnNsBU9WrU/QGFOmNlkXCa82eVfwDhQHD1MPIyQlQXv1+SBVHsx xBtBErTCVNDGTrqgzuew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qq7ci-00CmHl-0T; Tue, 10 Oct 2023 07:57:48 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qq7ce-00CmG0-2H for linux-arm-kernel@lists.infradead.org; Tue, 10 Oct 2023 07:57:46 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id D7D45C0017; Tue, 10 Oct 2023 07:57:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1696924659; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8HGCDW6dA/uAJ0GZAXHKMPSuwZNEP4AsO/ZK/lFHFUk=; b=UAlqB76MFympUYcFakSns2mIOgF13pHihMAEYgL1b92u9tsMq8XEVIkpDSc2USgjXn29Dj teMJY1lY51yixmRurzbAu6X/It5Prspi6Id1Wa32QHK/EHhiboyV1E/GwksW+XgJBr/BD+ gMzW3HEboeZULdc0q/po4tOFO145hK5LVo9/hA9YMl3NC5d4IgxP0MpIywwHIVhWpcYl7C 742U/PmD0Bnm2nlDzGfyngXvb5P5pZawz1yZlpNRIWYKL94NO72XcNjZfdd26znmNKgahB ft3/z9/2lF6GWH7GXWiTQEQSVY54kM8V13b7SYnq1pYaTJi9zxGcx8zm4m1HJA== Date: Tue, 10 Oct 2023 09:57:33 +0200 From: Herve Codina To: Jakub Kicinski Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Andrew Lunn , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Simon Horman , Christophe JAILLET , Thomas Petazzoni Subject: Re: [PATCH v7 24/30] net: wan: Add framer framework support Message-ID: <20231010095733.6899abbb@bootlin.com> In-Reply-To: <20231006150810.09e2c1a9@kernel.org> References: <20230928070652.330429-1-herve.codina@bootlin.com> <20230928070652.330429-25-herve.codina@bootlin.com> <20231006150810.09e2c1a9@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: herve.codina@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231010_005745_033563_4E869B42 X-CRM114-Status: GOOD ( 20.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgSmFrdWIKCk9uIEZyaSwgNiBPY3QgMjAyMyAxNTowODoxMCAtMDcwMApKYWt1YiBLaWNpbnNr aSA8a3ViYUBrZXJuZWwub3JnPiB3cm90ZToKCj4gT24gVGh1LCAyOCBTZXAgMjAyMyAwOTowNjo0 MiArMDIwMCBIZXJ2ZSBDb2RpbmEgd3JvdGU6Cj4gPiArbWVudSAiRnJhbWVyIFN1YnN5c3RlbSIK PiA+ICsKPiA+ICtjb25maWcgR0VORVJJQ19GUkFNRVIKPiA+ICsJYm9vbCAiRnJhbWVyIENvcmUi Cj4gPiArCWhlbHAKPiA+ICsJICBHZW5lcmljIEZyYW1lciBzdXBwb3J0Lgo+ID4gKwkgIEEgZnJh bWVyIGlzIGEgY29tcG9uZW50IGluIGNoYXJnZSBvZiBhbiBFMS9UMSBsaW5lIGludGVyZmFjZS4K PiA+ICsJICBDb25uZWN0ZWQgdXN1YWxseSB0byBhIFRETSBidXMsIGl0IGNvbnZlcnRzIFRETSBm cmFtZXMgdG8vZnJvbSBFMS9UMQo+ID4gKwkgIGZyYW1lcy4gSXQgYWxzbyBwcm92aWRlcyBpbmZv cm1hdGlvbiByZWxhdGVkIHRvIHRoZSBFMS9UMSBsaW5lLgo+ID4gKwkgIFVzZWQgd2l0aCBIRExD LCB0aGUgbmV0d29yayBjYW4gYmUgcmVhY2hlZCB0aHJvdWdoIHRoZSBFMS9UMSBsaW5lLgo+ID4g Kwo+ID4gKwkgIFRoaXMgZnJhbWV3b3JrIGlzIGRlc2lnbmVkIHRvIHByb3ZpZGUgYSBnZW5lcmlj IGludGVyZmFjZSBmb3IgZnJhbWVyCj4gPiArCSAgZGV2aWNlcyBwcmVzZW50IGluIHRoZSBrZXJu ZWwuIFRoaXMgbGF5ZXIgd2lsbCBoYXZlIHRoZSBnZW5lcmljCj4gPiArCSAgQVBJIGJ5IHdoaWNo IGZyYW1lciBkcml2ZXJzIGNhbiBjcmVhdGUgZnJhbWVyIHVzaW5nIHRoZSBmcmFtZXIKPiA+ICsJ ICBmcmFtZXdvcmsgYW5kIGZyYW1lciB1c2VycyBjYW4gb2J0YWluIHJlZmVyZW5jZSB0byB0aGUg ZnJhbWVyLgo+ID4gKwkgIEFsbCB0aGUgdXNlcnMgb2YgdGhpcyBmcmFtZXdvcmsgc2hvdWxkIHNl bGVjdCB0aGlzIGNvbmZpZy4gIAo+IAo+IG1heWJlIG1ha2UgdGhlIG1lbnUgYSBtZW51Y29uZmln IHdpdGggaW5mbyBhYm91dCBmcmFtZXJzIGJ1dCBoaWRlIAo+IHRoZSBHRU5FUklDX0ZSQU1FUiBz eW1ib2w/IFRoZSBkcml2ZXIgJ3NlbGVjdCcgaXQgYW55d2F5LCB3aGF0J3MKPiB0aGUgcG9pbnQg b2YgcHJvbXB0aW5nIHRoZSB1c2VyLi4KClllcywgSSB3aWxsIGNoYW5nZSBpbiB0aGUgbmV4dCBp dGVyYXRpb24uCgo+IAo+ID4gKwlpZiAoV0FSTl9PTighZGV2KSkKPiA+ICsJCXJldHVybiBFUlJf UFRSKC1FSU5WQUwpOyAgCj4gCj4gbm8gZGVmZW5zaXZlIHByb2dyYW1taW5nLCBsZXQgdGhlIGtl cm5lbCBjcmFzaAoKV2lsbCBiZSBjaGFuZ2VkLgoKPiAKPiA+ICsJcmV0ID0gZnJhbWVyX3BtX3J1 bnRpbWVfZ2V0X3N5bmMoZnJhbWVyKTsKPiA+ICsJaWYgKHJldCA8IDAgJiYgcmV0ICE9IC1FT1BO T1RTVVBQKQo+ID4gKwkJZ290byBlcnJfcG1fc3luYzsKPiA+ICsKPiA+ICsJcmV0ID0gMDsgLyog T3ZlcnJpZGUgcG9zc2libGUgcmV0ID09IC1FT1BOT1RTVVBQICovICAKPiAKPiBUaGlzIGxvb2tz IHBvaW50bGVzcyBnaXZlbiB0aGF0IHJldCBpcyBlaXRoZXIgb3ZlcndyaXR0ZW4gb3Igbm90IHVz ZWQKPiBsYXRlciBvbgoKSW5kZWVkLiBXaWxsIGJlIHJlbW92ZWQgaW4gdGhlIG5leHQgaXRlcmF0 aW9uLgoKPiAKPiA+ICsJbXV0ZXhfbG9jaygmZnJhbWVyLT5tdXRleCk7Cj4gPiArCWlmIChmcmFt ZXItPnBvd2VyX2NvdW50ID09IDAgJiYgZnJhbWVyLT5vcHMtPnBvd2VyX29uKSB7Cj4gPiArCQly ZXQgPSBmcmFtZXItPm9wcy0+cG93ZXJfb24oZnJhbWVyKTsKPiA+ICsJCWlmIChyZXQgPCAwKSB7 Cj4gPiArCQkJZGV2X2VycigmZnJhbWVyLT5kZXYsICJmcmFtZXIgcG93ZXJvbiBmYWlsZWQgLS0+ ICVkXG4iLCByZXQpOwo+ID4gKwkJCWdvdG8gZXJyX3B3cl9vbjsKPiA+ICsJCX0KPiA+ICsJfQo+ ID4gKwkrK2ZyYW1lci0+cG93ZXJfY291bnQ7Cj4gPiArCW11dGV4X3VubG9jaygmZnJhbWVyLT5t dXRleCk7Cj4gPiArCXJldHVybiAwOyAgCgpCZXN0IHJlZ2FyZHMsCkhlcnbDqQoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=