From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alexander Graf <graf@amazon.com>
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>,
Herbert Xu <herbert@gondor.apana.org.au>,
Olivia Mackall <olivia@selenic.com>,
Petre Eftime <petre.eftime@gmail.com>,
Erdem Meydanlli <meydanli@amazon.nl>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
David Woodhouse <dwmw@amazon.co.uk>,
"Michael S . Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Kyunghwan Kwon <k@mononn.com>
Subject: Re: [PATCH v4 1/2] Import CBOR library
Date: Tue, 10 Oct 2023 08:13:02 +0200 [thread overview]
Message-ID: <2023101010-overwrite-parakeet-91d5@gregkh> (raw)
In-Reply-To: <20231009212053.2007-2-graf@amazon.com>
On Mon, Oct 09, 2023 at 09:20:52PM +0000, Alexander Graf wrote:
> To fully support the Nitro Secure Module communication protocol, we need
> to encode and decode CBOR binary data. Import an MIT licensed library
> from https://github.com/libmcu/cbor (commit f3d1696f886) so that we can
> easily consume CBOR data.
What is "CBOR"? I don't see a description of it here.
And I guess you are going to keep this in sync with upstream? Or do you
really need the full library here (you #ifdef the float stuff out), does
your module really need all of the functionality and complexity of this
library, or can it use just a much smaller one instead?
> On top of the upstream code base, I added kernel module as well as
> kernel header path awareness and made checkpatch happy.
If only the one module needs this, why not put it in the directory for
the module itself, and then when/if anyone else needs it, it could be
moved?
thanks,
greg k-h
next prev parent reply other threads:[~2023-10-10 6:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 21:20 [PATCH v4 0/2] Add Nitro Secure Module support Alexander Graf
2023-10-09 21:20 ` [PATCH v4 1/2] Import CBOR library Alexander Graf
2023-10-10 6:13 ` Greg Kroah-Hartman [this message]
2023-10-10 7:55 ` Alexander Graf
2023-10-10 8:03 ` Greg Kroah-Hartman
2023-10-10 8:08 ` Alexander Graf
2023-10-10 8:27 ` Greg Kroah-Hartman
2023-10-11 12:24 ` Arnd Bergmann
2023-10-11 17:46 ` Greg Kroah-Hartman
2023-10-11 19:01 ` Alexander Graf
2023-10-11 20:48 ` Petre Eftime
2023-10-11 20:56 ` Greg Kroah-Hartman
2023-10-09 21:20 ` [PATCH v4 2/2] misc: Add Nitro Secure Module driver Alexander Graf
2023-10-10 6:15 ` Greg Kroah-Hartman
2023-10-13 15:43 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023101010-overwrite-parakeet-91d5@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=dwmw@amazon.co.uk \
--cc=graf@amazon.com \
--cc=herbert@gondor.apana.org.au \
--cc=jasowang@redhat.com \
--cc=k@mononn.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=meydanli@amazon.nl \
--cc=mst@redhat.com \
--cc=olivia@selenic.com \
--cc=petre.eftime@gmail.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.