From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0643CD6907 for ; Tue, 10 Oct 2023 08:31:50 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7DEAE1060; Tue, 10 Oct 2023 10:30:56 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7DEAE1060 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1696926706; bh=p+T1Q0rqoGClJy+72BMBs9BUZqEcavRypdOwHINOMe4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=cspcqbzL/F2gD+fgZpyEOLlC0y0RQiVJjwovOLydisSb4G14zSIpQclDs8hbrmK9m RQLa1CipBdWKn6eikn/FxfDMwEyonxkSeK7oNmBlsuJwPWSOcIRk3/aadtMHQ4OkPw GFe+gcXzF891Z8pkNVxWIXEVGVCo8gYLGa3DivN0= Received: by alsa1.perex.cz (Postfix, from userid 50401) id CC323F80557; Tue, 10 Oct 2023 10:30:18 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id E924AF8027B; Tue, 10 Oct 2023 10:30:17 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id AE380F80130; Tue, 10 Oct 2023 10:30:11 +0200 (CEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::224]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 61577F80166 for ; Tue, 10 Oct 2023 10:30:02 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 61577F80166 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=d2/GYvHB Received: by mail.gandi.net (Postfix) with ESMTPSA id 182D9E0008; Tue, 10 Oct 2023 08:29:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1696926600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NaOw8PSc0VULjmhxAa6nnKNT5QXhrjoUDdxFuVyTpCM=; b=d2/GYvHBSkcMRXi9pmcOlLcCOzYlqnrIh22gZ99/gFbL/M7ys56o4fhkMnDPId8GrsjWCC 5ouyZmnYSGtztbw5b3KORr9N47KIDYuaBQUiGc3Xf/ZDdUH8+/jT/SFGq05ljDkT54hN13 hx19s0wFiBqyB6uDlurPSlGYgMd3j25Og2nZrBv+EZ8JoEtmpYOsJTJFZCGD6qgRxTFCDK FZ/Gn35OaUtNi/MGYMXczmwjExd6qASdYRlrPa0Xtf0BY5UrQHKeqALrbgvp/3zYz4JUyV QEMOADOF32CCiQH10GW8t3f+hFHXxsyHOaUNrGK7QRLSZ6PLjrkZyGoU9RNvDQ== Date: Tue, 10 Oct 2023 10:29:45 +0200 From: Herve Codina To: Jakub Kicinski Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Andrew Lunn , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Simon Horman , Christophe JAILLET , Thomas Petazzoni Subject: Re: [PATCH v7 26/30] net: wan: framer: Add support for the Lantiq PEF2256 framer Message-ID: <20231010102945.39c27b1d@bootlin.com> In-Reply-To: <20231006150252.6d45be95@kernel.org> References: <20230928070652.330429-1-herve.codina@bootlin.com> <20230928070652.330429-27-herve.codina@bootlin.com> <20231006150252.6d45be95@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com Message-ID-Hash: BUZENCHFHLMX7SFG7Q7GG2VMGZSYGNQQ X-Message-ID-Hash: BUZENCHFHLMX7SFG7Q7GG2VMGZSYGNQQ X-MailFrom: herve.codina@bootlin.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Jakub, On Fri, 6 Oct 2023 15:02:52 -0700 Jakub Kicinski wrote: > On Thu, 28 Sep 2023 09:06:44 +0200 Herve Codina wrote: > > + for (i = 0; i < count; i++) { > > + (audio_devs + i)->name = "framer-codec"; > > + (audio_devs + i)->of_compatible = compatible; > > + (audio_devs + i)->id = i; > > Why not array notation? Will be change in the next iteration. > > > + } > > + > > + ret = mfd_add_devices(pef2256->dev, 0, audio_devs, count, NULL, 0, NULL); > > Should Lee be CCed for the MFD part? Will be added to the CC list. Best regards, Hervé From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03224CD68FE for ; Tue, 10 Oct 2023 08:30:58 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=d2/GYvHB; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4S4Tcx4hWWz3cCC for ; Tue, 10 Oct 2023 19:30:57 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=d2/GYvHB; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=217.70.183.196; helo=relay4-d.mail.gandi.net; envelope-from=herve.codina@bootlin.com; receiver=lists.ozlabs.org) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4S4Tby4F7cz2xdT for ; Tue, 10 Oct 2023 19:30:05 +1100 (AEDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 182D9E0008; Tue, 10 Oct 2023 08:29:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1696926600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NaOw8PSc0VULjmhxAa6nnKNT5QXhrjoUDdxFuVyTpCM=; b=d2/GYvHBSkcMRXi9pmcOlLcCOzYlqnrIh22gZ99/gFbL/M7ys56o4fhkMnDPId8GrsjWCC 5ouyZmnYSGtztbw5b3KORr9N47KIDYuaBQUiGc3Xf/ZDdUH8+/jT/SFGq05ljDkT54hN13 hx19s0wFiBqyB6uDlurPSlGYgMd3j25Og2nZrBv+EZ8JoEtmpYOsJTJFZCGD6qgRxTFCDK FZ/Gn35OaUtNi/MGYMXczmwjExd6qASdYRlrPa0Xtf0BY5UrQHKeqALrbgvp/3zYz4JUyV QEMOADOF32CCiQH10GW8t3f+hFHXxsyHOaUNrGK7QRLSZ6PLjrkZyGoU9RNvDQ== Date: Tue, 10 Oct 2023 10:29:45 +0200 From: Herve Codina To: Jakub Kicinski Subject: Re: [PATCH v7 26/30] net: wan: framer: Add support for the Lantiq PEF2256 framer Message-ID: <20231010102945.39c27b1d@bootlin.com> In-Reply-To: <20231006150252.6d45be95@kernel.org> References: <20230928070652.330429-1-herve.codina@bootlin.com> <20230928070652.330429-27-herve.codina@bootlin.com> <20231006150252.6d45be95@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , alsa-devel@alsa-project.org, Thomas Petazzoni , Xiubo Li , Linus Walleij , Liam Girdwood , Eric Dumazet , Krzysztof Kozlowski , Fabio Estevam , Qiang Zhao , Shengjiu Wang , Paolo Abeni , devicetree@vger.kernel.org, Conor Dooley , linux-kernel@vger.kernel.org, Nicolin Chen , linux-gpio@vger.kernel.org, Rob Herring , Christophe JAILLET , Jaroslav Kysela , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Randy Dunlap , Takashi Iwai , Li Yang , Mark Brown , Simon Horman , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Jakub, On Fri, 6 Oct 2023 15:02:52 -0700 Jakub Kicinski wrote: > On Thu, 28 Sep 2023 09:06:44 +0200 Herve Codina wrote: > > + for (i = 0; i < count; i++) { > > + (audio_devs + i)->name = "framer-codec"; > > + (audio_devs + i)->of_compatible = compatible; > > + (audio_devs + i)->id = i; > > Why not array notation? Will be change in the next iteration. > > > + } > > + > > + ret = mfd_add_devices(pef2256->dev, 0, audio_devs, count, NULL, 0, NULL); > > Should Lee be CCed for the MFD part? Will be added to the CC list. Best regards, Hervé From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D40F7CD6907 for ; Tue, 10 Oct 2023 08:30:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2TbTFzOPcCsTg5vJFQh2KmqGrTZbGLfirUhqtiwl0hU=; b=fadAr1Vuj8Em7/ qc54yIBL/1FlAowmTE9VJH41STvZdJ3HoKyn9QyUDPFRT3W5a3nFMwyequARvHoJGH3Wwreb+/e6Z K+uPUCYja8BLkndT0wqBMGQvz/sLL4XZryu2zGZuHUhQiop1752dRnCdjEzUKGqXi89jAR+Wxmf6x MkYIps1kTbX3RrcxYj0DCH/369sy/KkjPlsQf72585J4aTtO/M1rqUubqlJUFNuMsPhX1XpQhLVbU +rEvJln0jT++rUbkrCqfxK6GTwVExO70cch55uYAD0ooo+nLh6SPdZ4rac5qFQtihrS/9tUiGwrGa 3h5ccTrseTPEVQAlAMKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qq87y-00CqEE-0T; Tue, 10 Oct 2023 08:30:06 +0000 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qq87w-00CqCr-0O for linux-arm-kernel@lists.infradead.org; Tue, 10 Oct 2023 08:30:05 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 182D9E0008; Tue, 10 Oct 2023 08:29:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1696926600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NaOw8PSc0VULjmhxAa6nnKNT5QXhrjoUDdxFuVyTpCM=; b=d2/GYvHBSkcMRXi9pmcOlLcCOzYlqnrIh22gZ99/gFbL/M7ys56o4fhkMnDPId8GrsjWCC 5ouyZmnYSGtztbw5b3KORr9N47KIDYuaBQUiGc3Xf/ZDdUH8+/jT/SFGq05ljDkT54hN13 hx19s0wFiBqyB6uDlurPSlGYgMd3j25Og2nZrBv+EZ8JoEtmpYOsJTJFZCGD6qgRxTFCDK FZ/Gn35OaUtNi/MGYMXczmwjExd6qASdYRlrPa0Xtf0BY5UrQHKeqALrbgvp/3zYz4JUyV QEMOADOF32CCiQH10GW8t3f+hFHXxsyHOaUNrGK7QRLSZ6PLjrkZyGoU9RNvDQ== Date: Tue, 10 Oct 2023 10:29:45 +0200 From: Herve Codina To: Jakub Kicinski Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Andrew Lunn , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Qiang Zhao , Li Yang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Christophe Leroy , Randy Dunlap , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Simon Horman , Christophe JAILLET , Thomas Petazzoni Subject: Re: [PATCH v7 26/30] net: wan: framer: Add support for the Lantiq PEF2256 framer Message-ID: <20231010102945.39c27b1d@bootlin.com> In-Reply-To: <20231006150252.6d45be95@kernel.org> References: <20230928070652.330429-1-herve.codina@bootlin.com> <20230928070652.330429-27-herve.codina@bootlin.com> <20231006150252.6d45be95@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: herve.codina@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231010_013004_310417_9AD02E29 X-CRM114-Status: GOOD ( 11.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgSmFrdWIsCgpPbiBGcmksIDYgT2N0IDIwMjMgMTU6MDI6NTIgLTA3MDAKSmFrdWIgS2ljaW5z a2kgPGt1YmFAa2VybmVsLm9yZz4gd3JvdGU6Cgo+IE9uIFRodSwgMjggU2VwIDIwMjMgMDk6MDY6 NDQgKzAyMDAgSGVydmUgQ29kaW5hIHdyb3RlOgo+ID4gKwlmb3IgKGkgPSAwOyBpIDwgY291bnQ7 IGkrKykgewo+ID4gKwkJKGF1ZGlvX2RldnMgKyBpKS0+bmFtZSA9ICJmcmFtZXItY29kZWMiOwo+ ID4gKwkJKGF1ZGlvX2RldnMgKyBpKS0+b2ZfY29tcGF0aWJsZSA9IGNvbXBhdGlibGU7Cj4gPiAr CQkoYXVkaW9fZGV2cyArIGkpLT5pZCA9IGk7ICAKPiAKPiBXaHkgbm90IGFycmF5IG5vdGF0aW9u PwoKV2lsbCBiZSBjaGFuZ2UgaW4gdGhlIG5leHQgaXRlcmF0aW9uLgoKPiAKPiA+ICsJfQo+ID4g Kwo+ID4gKwlyZXQgPSBtZmRfYWRkX2RldmljZXMocGVmMjI1Ni0+ZGV2LCAwLCBhdWRpb19kZXZz LCBjb3VudCwgTlVMTCwgMCwgTlVMTCk7ICAKPiAKPiBTaG91bGQgTGVlIGJlIENDZWQgZm9yIHRo ZSBNRkQgcGFydD8KCldpbGwgYmUgYWRkZWQgdG8gdGhlIENDIGxpc3QuCgpCZXN0IHJlZ2FyZHMs CkhlcnbDqQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtYXJtLWtlcm5lbAo=