All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Borislav Petkov <bp@alien8.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Andrey Ryabinin <ryabinin.a.a@gmail.com>,
	Alexander Potapenko <glider@google.com>,
	Andrey Konovalov <andreyknvl@gmail.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org,
	Fei Yang <fei.yang@intel.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH] x86/alternatives: Disable KASAN on text_poke_early() in apply_alternatives()
Date: Tue, 10 Oct 2023 13:24:25 +0200	[thread overview]
Message-ID: <20231010112425.GJ377@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20231010102537.qkrfcna2fwfkzgir@box.shutemov.name>

On Tue, Oct 10, 2023 at 01:25:37PM +0300, Kirill A. Shutemov wrote:

> > That said, I don't particularly like the patch, I think it should, at
> > the veyr least, cover all of apply_alternatives, not just
> > text_poke_early().
> 
> I can do this, if it is the only stopper.
> 
> Do you want it disabled on caller side or inside apply_alternatives()?

Inside probably, covering the whole for()-loop thingy. Ideally with a
comment explaining how KASAN doesn't like partial LA57 patching.

  reply	other threads:[~2023-10-10 11:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-10  5:37 [PATCH] x86/alternatives: Disable KASAN on text_poke_early() in apply_alternatives() Kirill A. Shutemov
2023-10-10  8:19 ` Borislav Petkov
2023-10-10  8:40   ` Kirill A. Shutemov
2023-10-10  9:12     ` Borislav Petkov
2023-10-10 10:24       ` Kirill A. Shutemov
2023-10-10 10:10   ` Peter Zijlstra
2023-10-10 10:16     ` Peter Zijlstra
2023-10-10 10:30       ` Kirill A. Shutemov
2023-10-10 10:25     ` Kirill A. Shutemov
2023-10-10 11:24       ` Peter Zijlstra [this message]
2023-10-10 13:10     ` Borislav Petkov
2023-10-10 13:54       ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231010112425.GJ377@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=andreyknvl@gmail.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=dvyukov@google.com \
    --cc=fei.yang@intel.com \
    --cc=glider@google.com \
    --cc=hpa@zytor.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=ryabinin.a.a@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=vincenzo.frascino@arm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.