From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [Intel-xe] [CI 09/11] drm/gpuvm: Local fixes
Date: Tue, 10 Oct 2023 14:48:37 +0200 [thread overview]
Message-ID: <20231010124839.7948-9-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20231010124839.7948-1-thomas.hellstrom@linux.intel.com>
Fixes to v6 where we anticipate change.
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
drivers/gpu/drm/drm_gpuvm.c | 14 +++++++-------
drivers/gpu/drm/xe/xe_vm.c | 2 +-
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c
index c0d41ad236a5..e089d030d771 100644
--- a/drivers/gpu/drm/drm_gpuvm.c
+++ b/drivers/gpu/drm/drm_gpuvm.c
@@ -1068,8 +1068,10 @@ drm_gpuvm_prepare_objects_locked(struct drm_gpuvm *gpuvm,
if (ret)
break;
- if (vm_bo->evicted)
+ if (vm_bo->evicted) {
drm_gpuvm_bo_list_add(vm_bo, evict, false);
+ vm_bo->evicted = false;
+ }
}
return ret;
@@ -1387,7 +1389,7 @@ drm_gpuvm_resv_add_fence(struct drm_gpuvm *gpuvm,
dma_resv_assert_held(obj->resv);
dma_resv_add_fence(obj->resv, fence,
drm_gpuvm_is_extobj(gpuvm, obj) ?
- private_usage : extobj_usage);
+ extobj_usage : private_usage);
}
}
EXPORT_SYMBOL_GPL(drm_gpuvm_resv_add_fence);
@@ -1626,11 +1628,9 @@ drm_gpuvm_bo_evict(struct drm_gpuvm_bo *vm_bo, bool evict)
dma_resv_assert_held(obj->resv);
- if (drm_gpuvm_is_extobj(gpuvm, obj)) {
- vm_bo->evicted = evict;
-
- if (!lock)
- return;
+ if (evict && !lock && drm_gpuvm_is_extobj(gpuvm, obj)) {
+ vm_bo->evicted = true;
+ return;
}
if (evict)
diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index e22f1705b46c..2e07573055cb 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -1235,7 +1235,7 @@ struct xe_vm *xe_vm_create(struct xe_device *xe, u32 flags)
goto err_no_resv;
}
- drm_gpuvm_init(&vm->gpuvm, vm_resv_obj, "Xe VM", 0, 0, vm->size,
+ drm_gpuvm_init(&vm->gpuvm, vm_resv_obj, "Xe VM", 0, vm->size,
0, 0,
&gpuvm_ops);
--
2.41.0
next prev parent reply other threads:[~2023-10-10 12:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 12:48 [Intel-xe] [CI 01/11] drm/gpuvm: add common dma-resv per struct drm_gpuvm Thomas Hellström
2023-10-10 12:48 ` [Intel-xe] [CI 02/11] drm/xe: Adjust to "drm/gpuvm: add common dma-resv per struct drm_gpuvm" Thomas Hellström
2023-10-10 12:48 ` [Intel-xe] [CI 03/11] drm/gpuvm: add drm_gpuvm_flags to drm_gpuvm Thomas Hellström
2023-10-10 12:48 ` [Intel-xe] [CI 04/11] drm/xe: Adjust to commit "drm/gpuvm: add drm_gpuvm_flags to drm_gpuvm" Thomas Hellström
2023-10-10 12:48 ` [Intel-xe] [CI 05/11] drm/gpuvm: add an abstraction for a VM / BO combination Thomas Hellström
2023-10-10 12:48 ` [Intel-xe] [CI 06/11] drm/xe: Adjust to commit "drm/gpuvm: add an abstraction for a VM/BO combination" Thomas Hellström
2023-10-10 12:48 ` [Intel-xe] [CI 07/11] drm/gpuvm: track/lock/validate external/evicted objects Thomas Hellström
2023-10-10 12:48 ` [Intel-xe] [CI 08/11] drm/xe: Adapt to GPUVM tracking of external / evicted objects Thomas Hellström
2023-10-10 12:48 ` Thomas Hellström [this message]
2023-10-10 12:48 ` [Intel-xe] [CI 10/11] drm/xe: Use DRM_GPUVM_RESV_PROTECTED for gpuvm Thomas Hellström
2023-10-10 12:48 ` [Intel-xe] [CI 11/11] drm/nouveau: make use of the GPUVM's shared dma-resv Thomas Hellström
2023-10-10 15:01 ` [Intel-xe] ✓ CI.Patch_applied: success for series starting with [CI,01/11] drm/gpuvm: add common dma-resv per struct drm_gpuvm Patchwork
2023-10-10 15:01 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-10-10 15:03 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-10-10 15:10 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-10-10 15:10 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-10-10 15:11 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-10-11 10:49 ` [Intel-xe] ✗ CI.Patch_applied: failure for series starting with [CI,01/11] drm/gpuvm: add common dma-resv per struct drm_gpuvm (rev2) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-10-11 20:06 [Intel-xe] [CI 01/11] drm/gpuvm: add common dma-resv per struct drm_gpuvm Thomas Hellström
2023-10-11 20:07 ` [Intel-xe] [CI 09/11] drm/gpuvm: Local fixes Thomas Hellström
2023-10-11 14:44 [Intel-xe] [CI 01/11] drm/gpuvm: add common dma-resv per struct drm_gpuvm Thomas Hellström
2023-10-11 14:44 ` [Intel-xe] [CI 09/11] drm/gpuvm: Local fixes Thomas Hellström
2023-10-10 11:07 [Intel-xe] [CI 01/11] drm/gpuvm: add common dma-resv per struct drm_gpuvm Thomas Hellström
2023-10-10 11:07 ` [Intel-xe] [CI 09/11] drm/gpuvm: Local fixes Thomas Hellström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231010124839.7948-9-thomas.hellstrom@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.