Re: [RFC PATCH 2/2] fork, procfs: Introduce /proc/self/interpreter symlink

[kernel test robot <lkp@intel.com>]

Hi Guilherme,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on akpm-mm/mm-everything]
[also build test WARNING on pcmoore-audit/next linus/master v6.6-rc5]
[cannot apply to kees/for-next/execve next-20231009]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Guilherme-G-Piccoli/binfmt_misc-fork-proc-Introduce-flag-to-expose-the-interpreted-binary-in-procfs/20230908-044529
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20230907204256.3700336-3-gpiccoli%40igalia.com
patch subject: [RFC PATCH 2/2] fork, procfs: Introduce /proc/self/interpreter symlink
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231010/202310101349.prZqmt5R-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231010/202310101349.prZqmt5R-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310101349.prZqmt5R-lkp@intel.com/

All warnings (new ones prefixed by >>):

   kernel/fork.c:641: warning: Function parameter or member 'mm' not described in '__get_mm_exe_or_interp_file'
   kernel/fork.c:641: warning: Function parameter or member 'prefer_interp' not described in '__get_mm_exe_or_interp_file'
   kernel/fork.c:1445: warning: Function parameter or member 'mm' not described in 'set_mm_exe_file'
   kernel/fork.c:1445: warning: Function parameter or member 'new_exe_file' not described in 'set_mm_exe_file'
   kernel/fork.c:1445: warning: Function parameter or member 'new_interpreted_file' not described in 'set_mm_exe_file'
   kernel/fork.c:1498: warning: Function parameter or member 'mm' not described in 'replace_mm_exe_file'
   kernel/fork.c:1498: warning: Function parameter or member 'new_exe_file' not described in 'replace_mm_exe_file'
   kernel/fork.c:1551: warning: Function parameter or member 'task' not described in 'get_task_exe_file'
   kernel/fork.c:1551: warning: Function parameter or member 'prefer_interpreted' not described in 'get_task_exe_file'
>> kernel/fork.c:1581: warning: Function parameter or member 'task' not described in 'get_task_interpreter_file'
   kernel/fork.c:1607: warning: Function parameter or member 'task' not described in 'get_task_mm'
   kernel/fork.c:2182: warning: bad line: 
   kernel/fork.c:2203: warning: Function parameter or member 'ret' not described in '__pidfd_prepare'
   kernel/fork.c:2203: warning: Excess function parameter 'pidfd' description in '__pidfd_prepare'
   kernel/fork.c:2252: warning: Function parameter or member 'ret' not described in 'pidfd_prepare'
   kernel/fork.c:2252: warning: Excess function parameter 'pidfd' description in 'pidfd_prepare'
   kernel/fork.c:3261: warning: expecting prototype for clone3(). Prototype was for sys_clone3() instead


vim +1581 kernel/fork.c

  1570	
  1571	/**
  1572	 * get_task_interpreter_file - acquire a reference to the task's *interpreter*
  1573	 * executable (which is in fact the exe_file on mm_struct!). This is used in
  1574	 * order to expose /proc/self/interpreter, if we're under an interpreted
  1575	 * scenario (like binfmt_misc).
  1576	 *
  1577	 * Returns %NULL if exe_file is not an interpreter (i.e., it is the truly
  1578	 * running binary indeed).
  1579	 */
  1580	struct file *get_task_interpreter_file(struct task_struct *task)
> 1581	{
  1582		struct file *interpreter_file = NULL;
  1583		struct mm_struct *mm;
  1584	
  1585		task_lock(task);
  1586	
  1587		mm = task->mm;
  1588		if (mm && mm->has_interpreter) {
  1589			if (!(task->flags & PF_KTHREAD))
  1590				interpreter_file = get_mm_exe_file(mm);
  1591		}
  1592	
  1593		task_unlock(task);
  1594		return interpreter_file;
  1595	}
  1596	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki