From: Rob Herring <robh@kernel.org>
To: Dmitry Rokosov <ddrokosov@salutedevices.com>
Cc: lee@kernel.org, pavel@ucw.cz, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, andy.shevchenko@gmail.com,
kernel@sberdevices.ru, rockosov@gmail.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v1 02/11] dt-bindings: leds: aw200xx: fix led dt node pattern
Date: Tue, 10 Oct 2023 09:11:18 -0500 [thread overview]
Message-ID: <20231010141118.GA686993-robh@kernel.org> (raw)
In-Reply-To: <20231006160437.15627-3-ddrokosov@salutedevices.com>
On Fri, Oct 06, 2023 at 07:04:28PM +0300, Dmitry Rokosov wrote:
> AW200XX controllers have the capability to declare more than 0xf LEDs,
> therefore, it is necessary to accept LED names using an appropriate
> regex pattern.
>
> Fixes: e338a05e76ca ("dt-bindings: leds: Add binding for AW200xx")
> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com>
> ---
> Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml b/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml
> index feb5febaf361..73b81f7a7258 100644
> --- a/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml
> +++ b/Documentation/devicetree/bindings/leds/awinic,aw200xx.yaml
> @@ -42,7 +42,7 @@ properties:
> Leds matrix size
>
> patternProperties:
> - "^led@[0-9a-f]$":
> + "^led@[0-9a-f]+$":
There should be some updated constraints on 'reg' too. Actually, looks
like they were missing altogether. Please add.
> type: object
> $ref: common.yaml#
> unevaluatedProperties: false
> --
> 2.36.0
>
next prev parent reply other threads:[~2023-10-10 14:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 16:04 [PATCH v1 00/11] leds: aw200xx: several driver updates Dmitry Rokosov
2023-10-06 16:04 ` [PATCH v1 01/11] leds: aw200xx: fix write to DIM parameter Dmitry Rokosov
2023-10-06 16:04 ` [PATCH v1 02/11] dt-bindings: leds: aw200xx: fix led dt node pattern Dmitry Rokosov
2023-10-10 14:11 ` Rob Herring [this message]
2023-10-06 16:04 ` [PATCH v1 03/11] leds: aw200xx: support HWEN hardware control Dmitry Rokosov
2023-10-06 17:57 ` Andy Shevchenko
2023-10-09 13:09 ` Dmitry Rokosov
2023-10-06 16:04 ` [PATCH v1 04/11] dt-bindings: leds: aw200xx: introduce optional hwen-gpio property Dmitry Rokosov
2023-10-10 14:13 ` Rob Herring
2023-10-10 14:57 ` Dmitry Rokosov
2023-10-06 16:04 ` [PATCH v1 05/11] leds: aw200xx: calculate dts property display_rows in driver Dmitry Rokosov
2023-10-06 17:59 ` Andy Shevchenko
2023-10-09 13:20 ` Dmitry Rokosov
2023-10-16 23:30 ` George Stark
2023-10-06 16:04 ` [PATCH v1 06/11] dt-bindings: leds: aw200xx: remove property "awinic,display-rows" Dmitry Rokosov
2023-10-10 14:15 ` Rob Herring
2023-10-06 16:04 ` [PATCH v1 07/11] leds: aw200xx: add delay after software reset Dmitry Rokosov
2023-10-06 18:01 ` Andy Shevchenko
2023-10-09 13:14 ` Dmitry Rokosov
2023-10-06 16:04 ` [PATCH v1 08/11] leds: aw200xx: enable disable_locking flag in regmap config Dmitry Rokosov
2023-10-06 16:04 ` [PATCH v1 09/11] leds: aw200xx: improve autodim calculation method Dmitry Rokosov
2023-10-06 18:03 ` Andy Shevchenko
2023-10-09 13:18 ` Dmitry Rokosov
2023-10-09 14:02 ` Dmitry Rokosov
2023-10-16 21:22 ` George Stark
2023-10-06 16:04 ` [PATCH v1 10/11] leds: aw200xx: add support for aw20108 device Dmitry Rokosov
2023-10-06 16:04 ` [PATCH v1 11/11] dt-bindings: leds: Add binding for AW20108 led driver Dmitry Rokosov
2023-10-10 14:17 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231010141118.GA686993-robh@kernel.org \
--to=robh@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=conor+dt@kernel.org \
--cc=ddrokosov@salutedevices.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@sberdevices.ru \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rockosov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.