All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: andersson@kernel.org, agross@kernel.org,
	konrad.dybcio@linaro.org, mturquette@baylibre.com,
	sboyd@kernel.org, dmitry.baryshkov@linaro.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	jonathan@marek.ca, quic_tdas@quicinc.com,
	vladimir.zapolskiy@linaro.org, linux-arm-msm@vger.kernel.org,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] media: dt-bindings: media: camss: Add qcom,sc8280xp-camss binding
Date: Tue, 10 Oct 2023 10:13:55 -0500	[thread overview]
Message-ID: <20231010151355.GB870095-robh@kernel.org> (raw)
In-Reply-To: <20231010122539.1768825-3-bryan.odonoghue@linaro.org>

On Tue, Oct 10, 2023 at 01:25:38PM +0100, Bryan O'Donoghue wrote:
> Add bindings for qcom,sc8280xp-camss in order to support the camera
> subsystem for sc8280xp as found in the Lenovo x13s Laptop.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  .../bindings/media/qcom,sc8280xp-camss.yaml   | 582 ++++++++++++++++++
>  1 file changed, 582 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> new file mode 100644
> index 000000000000..5b0481d8bd07
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml
> @@ -0,0 +1,582 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/qcom,sc8280xp-camss.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm SC8280XP Camera Subsystem (CAMSS)
> +
> +maintainers:
> +  - Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> +
> +description: |
> +  The CAMSS IP is a CSI decoder and ISP present on Qualcomm platforms.
> +
> +properties:
> +  compatible:
> +    const: qcom,sc8280xp-camss
> +
> +  clocks:
> +    maxItems: 63
> +
> +  clock-names:
> +    items:
> +      - const: camnoc_axi
> +      - const: camnoc_axi_src
> +      - const: cpas_ahb
> +      - const: cphy_rx_src
> +      - const: csiphy0
> +      - const: csiphy0_timer_src
> +      - const: csiphy0_timer
> +      - const: csiphy1
> +      - const: csiphy1_timer_src
> +      - const: csiphy1_timer
> +      - const: csiphy2
> +      - const: csiphy2_timer_src
> +      - const: csiphy2_timer
> +      - const: csiphy3
> +      - const: csiphy3_timer_src
> +      - const: csiphy3_timer
> +      - const: vfe0_axi
> +      - const: vfe0_src
> +      - const: vfe0
> +      - const: vfe0_cphy_rx
> +      - const: vfe0_csid_src
> +      - const: vfe0_csid
> +      - const: vfe1_axi
> +      - const: vfe1_src
> +      - const: vfe1
> +      - const: vfe1_cphy_rx
> +      - const: vfe1_csid_src
> +      - const: vfe1_csid
> +      - const: vfe2_axi
> +      - const: vfe2_src
> +      - const: vfe2
> +      - const: vfe2_cphy_rx
> +      - const: vfe2_csid_src
> +      - const: vfe2_csid
> +      - const: vfe3_axi
> +      - const: vfe3_src
> +      - const: vfe3
> +      - const: vfe3_cphy_rx
> +      - const: vfe3_csid_src
> +      - const: vfe3_csid
> +      - const: vfe_lite0_src
> +      - const: vfe_lite0
> +      - const: vfe_lite0_cphy_rx
> +      - const: vfe_lite0_csid_src
> +      - const: vfe_lite0_csid
> +      - const: vfe_lite1_src
> +      - const: vfe_lite1
> +      - const: vfe_lite1_cphy_rx
> +      - const: vfe_lite1_csid_src
> +      - const: vfe_lite1_csid
> +      - const: vfe_lite2_src
> +      - const: vfe_lite2
> +      - const: vfe_lite2_cphy_rx
> +      - const: vfe_lite2_csid_src
> +      - const: vfe_lite2_csid
> +      - const: vfe_lite3_src
> +      - const: vfe_lite3
> +      - const: vfe_lite3_cphy_rx
> +      - const: vfe_lite3_csid_src
> +      - const: vfe_lite3_csid
> +      - const: gcc_axi_hf
> +      - const: gcc_axi_sf
> +      - const: slow_ahb_src
> +
> +  interrupts:
> +    maxItems: 20
> +
> +  interrupt-names:
> +    items:
> +      - const: csid1_lite
> +      - const: vfe_lite1
> +      - const: csiphy3
> +      - const: csid0
> +      - const: vfe0
> +      - const: csid1
> +      - const: vfe1
> +      - const: csid0_lite
> +      - const: vfe_lite0
> +      - const: csiphy0
> +      - const: csiphy1
> +      - const: csiphy2
> +      - const: csid2
> +      - const: vfe2
> +      - const: csid3_lite
> +      - const: csid2_lite
> +      - const: vfe_lite3
> +      - const: vfe_lite2
> +      - const: csid3
> +      - const: vfe3
> +
> +  iommus:
> +    maxItems: 16
> +
> +  interconnects:
> +    maxItems: 4
> +
> +  interconnect-names:
> +    items:
> +      - const: cam_ahb
> +      - const: cam_hf_mnoc
> +      - const: cam_sf_mnoc
> +      - const: cam_sf_icp_mnoc
> +
> +  power-domains:
> +    items:
> +      - description: IFE0 GDSC - Image Front End, Global Distributed Switch Controller.
> +      - description: IFE1 GDSC - Image Front End, Global Distributed Switch Controller.
> +      - description: IFE2 GDSC - Image Front End, Global Distributed Switch Controller.
> +      - description: IFE3 GDSC - Image Front End, Global Distributed Switch Controller.
> +      - description: Titan Top GDSC - Titan ISP Block, Global Distributed Switch Controller.
> +
> +  power-domain-names:
> +    items:
> +      - const: ife0
> +      - const: ife1
> +      - const: ife2
> +      - const: ife3
> +      - const: top
> +
> +  ports:
> +    $ref: /schemas/graph.yaml#/properties/ports
> +
> +    description:
> +      CSI input ports.
> +
> +    properties:
> +      port@0:
> +        $ref: /schemas/graph.yaml#/$defs/port-base
> +        unevaluatedProperties: false
> +        description:
> +          Input port for receiving CSI data.
> +
> +        properties:
> +          endpoint:
> +            $ref: video-interfaces.yaml#
> +            unevaluatedProperties: false
> +
> +            properties:
> +              clock-lanes:
> +                maxItems: 1
> +
> +              data-lanes:
> +                minItems: 1
> +                maxItems: 4
> +
> +            required:
> +              - clock-lanes
> +              - data-lanes
> +
> +      port@1:
> +        $ref: /schemas/graph.yaml#/$defs/port-base
> +        unevaluatedProperties: false
> +        description:
> +          Input port for receiving CSI data.
> +
> +        properties:
> +          endpoint:
> +            $ref: video-interfaces.yaml#
> +            unevaluatedProperties: false
> +
> +            properties:
> +              clock-lanes:
> +                maxItems: 1
> +
> +              data-lanes:
> +                minItems: 1
> +                maxItems: 4
> +
> +            required:
> +              - clock-lanes
> +              - data-lanes
> +
> +      port@2:
> +        $ref: /schemas/graph.yaml#/$defs/port-base
> +        unevaluatedProperties: false
> +        description:
> +          Input port for receiving CSI data.
> +
> +        properties:
> +          endpoint:
> +            $ref: video-interfaces.yaml#
> +            unevaluatedProperties: false
> +
> +            properties:
> +              clock-lanes:
> +                maxItems: 1
> +
> +              data-lanes:
> +                minItems: 1
> +                maxItems: 4
> +
> +            required:
> +              - clock-lanes
> +              - data-lanes
> +
> +      port@3:
> +        $ref: /schemas/graph.yaml#/$defs/port-base
> +        unevaluatedProperties: false
> +        description:
> +          Input port for receiving CSI data.

Every port has the same description. You need to define how they 
correlate to the h/w. 0-3 is what in the hardware?

Rob

  parent reply	other threads:[~2023-10-10 15:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-10 12:25 [PATCH v2 0/3] Add sc8280xp CCI and CAMSS core dtsi Bryan O'Donoghue
2023-10-10 12:25 ` [PATCH v2 1/3] arm64: dts: qcom: sc8280xp: camss: Add CCI definitions Bryan O'Donoghue
2023-10-10 12:25 ` [PATCH v2 2/3] media: dt-bindings: media: camss: Add qcom,sc8280xp-camss binding Bryan O'Donoghue
2023-10-10 13:25   ` Rob Herring
2023-10-10 13:56     ` Bryan O'Donoghue
2023-10-10 15:09       ` Rob Herring
2023-10-10 15:13   ` Rob Herring [this message]
2023-10-10 12:25 ` [PATCH v2 3/3] arm64: dts: qcom: sc8280xp: camss: Add CAMSS block definition Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231010151355.GB870095-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=jonathan@marek.ca \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=quic_tdas@quicinc.com \
    --cc=sboyd@kernel.org \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.