From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E6DECD98CD for ; Tue, 10 Oct 2023 23:28:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id EA32D41E2E; Tue, 10 Oct 2023 23:28:23 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org EA32D41E2E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1696980504; bh=RAnWTTTv/4cIhIByJwjxFESMuubtp/C11oczWK7uow4=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=5mXSbLJhLvZwyvCpmB5Lg1Rmex2uTCIHnC20/BxKGo/J8ZBvv1eCCm8GY13q2p7wY bXbsujndeCflTEVRFIiO9RWmVtOOIC+ZpXVWjCOowRPJ09Sic0KK71axMcxgAhPy0m iFm7k+O+bOfFBMzRUtAJFeMeyPJFOGBzSmdOo8O8zfl6StVpTD+HBd/E80uHeoDFBF NFDoSPP24CAlvuO1GnIMjpfnO4EFwy+uFBgqlYWnYFryxkiVKK6XiampOZpDossqd1 TF88S2QhHitt3CYP1Vx8KEw+ylpS8sDwhc2Je/JsVOdNKQbYXvQ9GmPtzoBNxC9SDD YBAeo0GoYP0RA== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T-IbS4B9f-HV; Tue, 10 Oct 2023 23:28:22 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 9137441E30; Tue, 10 Oct 2023 23:28:22 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 9137441E30 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id A0AA91BF83C for ; Tue, 10 Oct 2023 23:28:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 7858B82311 for ; Tue, 10 Oct 2023 23:28:20 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 7858B82311 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WfBDPkYUCF8X for ; Tue, 10 Oct 2023 23:28:19 +0000 (UTC) Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by smtp1.osuosl.org (Postfix) with ESMTPS id 4108B82305 for ; Tue, 10 Oct 2023 23:28:19 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4108B82305 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1c5c91bec75so43066305ad.3 for ; Tue, 10 Oct 2023 16:28:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696980498; x=1697585298; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3ffyVmDvObFUQGm01LEbnK2a/NNSPjFeJ8aUijmhJtI=; b=Q2rBKcAFlWK2l4V9LouFsYyHig/9LGt6tmn5UgyvukaMB93X09ZBj2J6xdvZopxjU3 mKXGUKl3Wd8hvhQFlsaUykKFKafOiC4kMdEwfF0jfglOOmZaAw3zlgvkHpUsXTCMYGOg wFsOGEW7xIU0X5R9zHAH+QcbpKMuceHsBUw6ip2ANnJwZSfEwj//QbXrauQQWdClzLW3 GZ2aOSFZbzPabMCAzf0PY1MRNSC56co9id+olR+XdWFn8ZkyKtWdR5uPxlmfq6UozG/z utcl2Haw7NmlrBcolckmPc+8yzSPzYP+jDU5B7CibKvxv011PGAZsMUdaO8ytP8MznNb tFTg== X-Gm-Message-State: AOJu0Yx/aGo9tn0kHskSnYmnrFnnLDApcm7Lwdw7593dQdzkWU3Zj6ML 5PxeP2MX87MZ0eE9zbUMNv5p5Q== X-Google-Smtp-Source: AGHT+IEiG6MkiUeUM4CjFtvjNc39SCT6bmkPmjD94V4ggCDiykYfKvAabgK71CDQRK5wtqaWRWjRvw== X-Received: by 2002:a17:90a:ab87:b0:27b:258f:2843 with SMTP id n7-20020a17090aab8700b0027b258f2843mr12673716pjq.7.1696980498575; Tue, 10 Oct 2023 16:28:18 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id s15-20020a17090a5d0f00b00263cca08d95sm12446269pji.55.2023.10.10.16.28.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 16:28:17 -0700 (PDT) Date: Tue, 10 Oct 2023 16:28:14 -0700 From: Kees Cook To: Justin Stitt Message-ID: <202310101625.175D43E7@keescook> References: <20231010-netdev-replace-strncpy-resend-as-series-v1-0-caf9f0f2f021@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1696980498; x=1697585298; darn=lists.osuosl.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=3ffyVmDvObFUQGm01LEbnK2a/NNSPjFeJ8aUijmhJtI=; b=RQIzSYCk5y1MkwPt3nZ4MJ/50PpT/LBwibRBii0Kh84576wW/P7xoRPG1Z26v87+cX TblfcDuMPKN0T0KREC3CK1mwpc14IcJhaSxB1ZdIl9Z1LVZFC9l8LL+zTdEaIHKE8kOR ufZTRVNX7U6xfZitoxz6VUsCRpDc0fBPgMtxM= X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=RQIzSYCk Subject: Re: [Intel-wired-lan] [PATCH net-next 0/7] net: intel: replace deprecated strncpy uses X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-wired-lan@lists.osuosl.org, Jesse Brandeburg , linux-kernel@vger.kernel.org, Eric Dumazet , Tony Nguyen , linux-hardening@vger.kernel.org, netdev@vger.kernel.org, Jakub Kicinski , Paolo Abeni , "David S. Miller" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" T24gVHVlLCBPY3QgMTAsIDIwMjMgYXQgMDQ6MjI6NDRQTSAtMDcwMCwgSnVzdGluIFN0aXR0IHdy b3RlOgo+IE9uIFR1ZSwgT2N0IDEwLCAyMDIzIGF0IDQ6MTnigK9QTSBKZXNzZSBCcmFuZGVidXJn Cj4gPGplc3NlLmJyYW5kZWJ1cmdAaW50ZWwuY29tPiB3cm90ZToKPiA+Cj4gPiBPbiAxMC8xMC8y MDIzIDM6MjYgUE0sIEp1c3RpbiBTdGl0dCB3cm90ZToKPiA+ID4gSGksCj4gPiA+Cj4gPiA+IFRo aXMgc2VyaWVzIGFpbXMgdG8gZWxpbWluYXRlIHVzZXMgb2Ygc3RybmNweSgpIGFzIGl0IGlzIGEg ZGVwcmVjYXRlZAo+ID4gPiBpbnRlcmZhY2UgWzFdIHdpdGggbWFueSB2aWFibGUgcmVwbGFjZW1l bnRzIGF2YWlsYWJsZS4KPiA+ID4KPiA+ID4gUHJlZG9taW5hbnRseSwgc3Ryc2NweSgpIGlzIHRo ZSBnby10byByZXBsYWNlbWVudCBhcyBpdCBndWFyYW50ZWVzCj4gPiA+IE5VTC10ZXJtaW5hdGlv biBvbiB0aGUgZGVzdGluYXRpb24gYnVmZmVyICh3aGljaCBzdHJuY3B5IGRvZXMgbm90KS4gV2l0 aAo+ID4gPiB0aGF0IGJlaW5nIHNhaWQsIEkgZGlkIG5vdCBpZGVudGlmeSBhbnkgYnVmZmVyIG92 ZXJyZWFkIHByb2JsZW1zIGFzIHRoZQo+ID4gPiBzaXplIGFyZ3VtZW50cyB3ZXJlIGNhcmVmdWxs eSBtZWFzdXJlZCB0byBsZWF2ZSByb29tIGZvciB0cmFpbGluZwo+ID4gPiBOVUwtYnl0ZXMuIE5v bmV0aGVsZXNzLCB3ZSBzaG91bGQgZmF2b3IgbW9yZSByb2J1c3QgYW5kIGxlc3MgYW1iaWd1b3Vz Cj4gPiA+IGludGVyZmFjZXMuCj4gPiA+Cj4gPiA+IFByZXZpb3VzbHksIGVhY2ggb2YgdGhlc2Ug cGF0Y2hlcyB3YXMgc2VudCBpbmRpdmlkdWFsbHkgYXQ6Cj4gPiA+IDEpIGh0dHBzOi8vbG9yZS5r ZXJuZWwub3JnL2FsbC8yMDIzMTAwOS1zdHJuY3B5LWRyaXZlcnMtbmV0LWV0aGVybmV0LWludGVs LWUxMDAtYy12MS0xLWNhMGZmOTY4NjhhM0Bnb29nbGUuY29tLwo+ID4gPiAyKSBodHRwczovL2xv cmUua2VybmVsLm9yZy9hbGwvMjAyMzEwMTAtc3RybmNweS1kcml2ZXJzLW5ldC1ldGhlcm5ldC1p bnRlbC1lMTAwMC1lMTAwMF9tYWluLWMtdjEtMS1iMWQ2NDU4MWY5ODNAZ29vZ2xlLmNvbS8KPiA+ ID4gMykgaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvYWxsLzIwMjMxMDEwLXN0cm5jcHktZHJpdmVy cy1uZXQtZXRoZXJuZXQtaW50ZWwtZm0xMGstZm0xMGtfZXRodG9vbC1jLXYxLTEtZGJkYzQ1NzBj NWE2QGdvb2dsZS5jb20vCj4gPiA+IDQpIGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2FsbC8yMDIz MTAxMC1zdHJuY3B5LWRyaXZlcnMtbmV0LWV0aGVybmV0LWludGVsLWk0MGUtaTQwZV9kZHAtYy12 MS0xLWYwMWEyMzM5NGVhYkBnb29nbGUuY29tLwo+ID4gPiA1KSBodHRwczovL2xvcmUua2VybmVs Lm9yZy9hbGwvMjAyMzEwMTAtc3RybmNweS1kcml2ZXJzLW5ldC1ldGhlcm5ldC1pbnRlbC1pZ2It aWdiX21haW4tYy12MS0xLWQ3OTYyMzRhOGFiZkBnb29nbGUuY29tLwo+ID4gPiA2KSBodHRwczov L2xvcmUua2VybmVsLm9yZy9hbGwvMjAyMzEwMTAtc3RybmNweS1kcml2ZXJzLW5ldC1ldGhlcm5l dC1pbnRlbC1pZ2J2Zi1uZXRkZXYtYy12MS0xLTY5Y2NmYjJjMmFhNUBnb29nbGUuY29tLwo+ID4g PiA3KSBodHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwvMjAyMzEwMTAtc3RybmNweS1kcml2ZXJz LW5ldC1ldGhlcm5ldC1pbnRlbC1pZ2MtaWdjX21haW4tYy12MS0xLWYxZjUwN2VjYzQ3NkBnb29n bGUuY29tLwo+ID4gPgo+ID4gPiBDb25zaWRlciB0aGVzZSBkZWFkIGFzIHRoaXMgc2VyaWVzIGlz IHRoZWlyIG5ldyBob21lIDopCj4gPiA+Cj4gPiA+IEkgZm91bmQgYWxsIHRoZXNlIGluc3RhbmNl cyB3aXRoOiAkIHJnICJzdHJuY3B5XCgiCj4gPiA+Cj4gPiA+IFRoaXMgc2VyaWVzIG1heSBjb2xs aWRlIGluIGEgbm90LXNvLW5pY2Ugd2F5IHdpdGggWzNdLiBUaGlzIHNlcmllcyBjYW4KPiA+ID4g Z28gaW4gYWZ0ZXIgdGhhdCBvbmUgd2l0aCBhIHJlYmFzZS4gSSdsbCBzZW5kIGEgdjIgaWYgbmVj ZXNzYXJ5Lgo+ID4gPgo+ID4gPiBbM106IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL25ldGRldi8y MDIzMTAwMzE4MzYwMy4zODg3NTQ2LTEtamVzc2UuYnJhbmRlYnVyZ0BpbnRlbC5jb20vCj4gPiA+ Cj4gPiA+IExpbms6IGh0dHBzOi8vd3d3Lmtlcm5lbC5vcmcvZG9jL2h0bWwvbGF0ZXN0L3Byb2Nl c3MvZGVwcmVjYXRlZC5odG1sI3N0cm5jcHktb24tbnVsLXRlcm1pbmF0ZWQtc3RyaW5ncyBbMV0K PiA+ID4gTGluazogaHR0cHM6Ly9tYW5wYWdlcy5kZWJpYW4ub3JnL3Rlc3RpbmcvbGludXgtbWFu dWFsLTQuOC9zdHJzY3B5LjkuZW4uaHRtbCBbMl0KPiA+ID4gTGluazogaHR0cHM6Ly9naXRodWIu Y29tL0tTUFAvbGludXgvaXNzdWVzLzkwCj4gPiA+IFNpZ25lZC1vZmYtYnk6IEp1c3RpbiBTdGl0 dCA8anVzdGluc3RpdHRAZ29vZ2xlLmNvbT4KPiA+Cj4gPiBUaGFua3MgSnVzdGluIGZvciBmaXhp bmcgYWxsIHRoZXNlIQo+ID4KPiA+IEZvciB0aGUgc2VyaWVzOgo+ID4gUmV2aWV3ZWQtYnk6IEpl c3NlIEJyYW5kZWJ1cmcgPGplc3NlLmJyYW5kZWJ1cmdAaW50ZWwuY29tPgo+ID4KPiA+IFBTOiBo YXZlIHlvdSBjb25zaWRlcmVkIGFkZGluZyBhIHNjcmlwdCB0byBzY3JpcHRzL2NvY2NpbmVsbGUv YXBpIHdoaWNoCj4gPiBtaWdodCBjYXRjaCBhbmQgdHJ5IHRvIGZpeCBmdXR1cmUgKGFiKXVzZXJz IG9mIHN0cm5jcHk/Cj4gCj4gVGhlcmUgaXMgYSBjaGVja3BhdGNoIHJvdXRpbmUgZm9yIGl0LiBB bHNvLCB0aGUgZG9jcyBhcmUgbGl0dGVyZWQgd2l0aAo+IGF2ZXJzaW9ucyB0byBzdHJuY3B5LiBX aXRoIHRoYXQgYmVpbmcgc2FpZCwgSSB3b3VsZCBub3QgYmUgb3Bwb3NlZAo+IHRvIGFkZGluZyBt b3JlIGNoZWNrcywgdGhvdWdoLgo+IAo+IE9uY2UgSSdtIG1vcmUgY2F1Z2h0IHVwIG9uIGFsbCB0 aGUgb3V0c3RhbmRpbmcgc3RybmNweSB1c2VzLAo+IEknbGwgbG9vayBpbnRvIGFkZGluZyBzb21l IGNvY2NpbmVsbGUgc3VwcG9ydC4KCkNvY2NpbmVsbGUgZm9yIHN0cm5jcHkgaXMgZGlmZmljdWx0 IHNpbmNlIGVhY2ggc2V0IG9mIGNhbGxlcnMgdGVuZHMgdG8KbmVlZCBjYXJlZnVsIGV4YW1pbmF0 aW9uLiBCdXQgdGhlIGdvb2QgbmV3cyBoZXJlIGlzIHRoYXQgYXQgdGhlIGN1cnJlbnQKcmF0ZSwg dGhlIGtlcm5lbCBtYXkgYmUgc3RybmNweS1mcmVlIHByZXR0eSBzb29uLiA6KQoKLS0gCktlZXMg Q29vawpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC13aXJlZC1sYW4gbWFpbGluZyBsaXN0CkludGVsLXdpcmVkLWxhbkBvc3Vvc2wub3JnCmh0dHBz Oi8vbGlzdHMub3N1b3NsLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLXdpcmVkLWxhbgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41A4D32C93 for ; Tue, 10 Oct 2023 23:28:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="motvlJD/" Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AB2694 for ; Tue, 10 Oct 2023 16:28:19 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1bf55a81eeaso43271325ad.0 for ; Tue, 10 Oct 2023 16:28:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1696980498; x=1697585298; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=3ffyVmDvObFUQGm01LEbnK2a/NNSPjFeJ8aUijmhJtI=; b=motvlJD/CCSca8DU/gmwa6KBCkG7scvSfW8COtt2JmDGZqFL+7hZg8Ncynmys9Oa9D QQiwZTGU3Cs7Lm9/NT+Rkj/DIR3yW8sL27MMSnqPUt3lN1uHBtViBlGnuHimFrBSyA9E ITN9X5IRqBHIRf7381IoB+AOJNBElQkcQjKgs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696980498; x=1697585298; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3ffyVmDvObFUQGm01LEbnK2a/NNSPjFeJ8aUijmhJtI=; b=c4otwCdoiG8ZMumSxV0pi0X+MJ41QXKYqccKvoop3e6MxNZn41aumSC4oXJNZp6NOA e2OG5rji88mkJFOkVkp6C6iG2U5mm9mZdJAYT1opuAi4y1Hi4N7GSHCdVRNgbSdcFH2q gzBo/cMrmGErhoxfvxcZNchorGD5irKCLR7g0dc3SV5O5arpahnbLsOcsGFzqxaHPnfS ctzsAYZI8lbnVF7mX34cHDyufvtQj29K8CsSgoYZZSothZlUAkBh7CSLekDyTz8mM62p xZYioKPwoaSCMHE9S2i0G0tIU7EXFfwENELCKW7FOhZh+2sM+JJVNX7sWYIMEP0GNscJ sK4g== X-Gm-Message-State: AOJu0Yz5Y7M2Z//sIT+3cJ6qeIYA57kB/A3eMTHGPBgCEgFu6MB/PWyU 4usGGuw4agLIpyVnVjo0T2D3jQ== X-Google-Smtp-Source: AGHT+IEiG6MkiUeUM4CjFtvjNc39SCT6bmkPmjD94V4ggCDiykYfKvAabgK71CDQRK5wtqaWRWjRvw== X-Received: by 2002:a17:90a:ab87:b0:27b:258f:2843 with SMTP id n7-20020a17090aab8700b0027b258f2843mr12673716pjq.7.1696980498575; Tue, 10 Oct 2023 16:28:18 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id s15-20020a17090a5d0f00b00263cca08d95sm12446269pji.55.2023.10.10.16.28.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 16:28:17 -0700 (PDT) Date: Tue, 10 Oct 2023 16:28:14 -0700 From: Kees Cook To: Justin Stitt Cc: Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-hardening@vger.kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 0/7] net: intel: replace deprecated strncpy uses Message-ID: <202310101625.175D43E7@keescook> References: <20231010-netdev-replace-strncpy-resend-as-series-v1-0-caf9f0f2f021@google.com> Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Tue, Oct 10, 2023 at 04:22:44PM -0700, Justin Stitt wrote: > On Tue, Oct 10, 2023 at 4:19 PM Jesse Brandeburg > wrote: > > > > On 10/10/2023 3:26 PM, Justin Stitt wrote: > > > Hi, > > > > > > This series aims to eliminate uses of strncpy() as it is a deprecated > > > interface [1] with many viable replacements available. > > > > > > Predominantly, strscpy() is the go-to replacement as it guarantees > > > NUL-termination on the destination buffer (which strncpy does not). With > > > that being said, I did not identify any buffer overread problems as the > > > size arguments were carefully measured to leave room for trailing > > > NUL-bytes. Nonetheless, we should favor more robust and less ambiguous > > > interfaces. > > > > > > Previously, each of these patches was sent individually at: > > > 1) https://lore.kernel.org/all/20231009-strncpy-drivers-net-ethernet-intel-e100-c-v1-1-ca0ff96868a3@google.com/ > > > 2) https://lore.kernel.org/all/20231010-strncpy-drivers-net-ethernet-intel-e1000-e1000_main-c-v1-1-b1d64581f983@google.com/ > > > 3) https://lore.kernel.org/all/20231010-strncpy-drivers-net-ethernet-intel-fm10k-fm10k_ethtool-c-v1-1-dbdc4570c5a6@google.com/ > > > 4) https://lore.kernel.org/all/20231010-strncpy-drivers-net-ethernet-intel-i40e-i40e_ddp-c-v1-1-f01a23394eab@google.com/ > > > 5) https://lore.kernel.org/all/20231010-strncpy-drivers-net-ethernet-intel-igb-igb_main-c-v1-1-d796234a8abf@google.com/ > > > 6) https://lore.kernel.org/all/20231010-strncpy-drivers-net-ethernet-intel-igbvf-netdev-c-v1-1-69ccfb2c2aa5@google.com/ > > > 7) https://lore.kernel.org/all/20231010-strncpy-drivers-net-ethernet-intel-igc-igc_main-c-v1-1-f1f507ecc476@google.com/ > > > > > > Consider these dead as this series is their new home :) > > > > > > I found all these instances with: $ rg "strncpy\(" > > > > > > This series may collide in a not-so-nice way with [3]. This series can > > > go in after that one with a rebase. I'll send a v2 if necessary. > > > > > > [3]: https://lore.kernel.org/netdev/20231003183603.3887546-1-jesse.brandeburg@intel.com/ > > > > > > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] > > > Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] > > > Link: https://github.com/KSPP/linux/issues/90 > > > Signed-off-by: Justin Stitt > > > > Thanks Justin for fixing all these! > > > > For the series: > > Reviewed-by: Jesse Brandeburg > > > > PS: have you considered adding a script to scripts/coccinelle/api which > > might catch and try to fix future (ab)users of strncpy? > > There is a checkpatch routine for it. Also, the docs are littered with > aversions to strncpy. With that being said, I would not be opposed > to adding more checks, though. > > Once I'm more caught up on all the outstanding strncpy uses, > I'll look into adding some coccinelle support. Coccinelle for strncpy is difficult since each set of callers tends to need careful examination. But the good news here is that at the current rate, the kernel may be strncpy-free pretty soon. :) -- Kees Cook