From: Tony Lindgren <tony@atomide.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
John Ogness <john.ogness@linutronix.de>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] printk: Check valid console index for preferred console
Date: Wed, 11 Oct 2023 12:18:03 +0300 [thread overview]
Message-ID: <20231011091803.GC34982@atomide.com> (raw)
In-Reply-To: <2023101131-maroon-stubborn-1364@gregkh>
* Greg Kroah-Hartman <gregkh@linuxfoundation.org> [231011 07:53]:
> On Wed, Oct 11, 2023 at 10:43:25AM +0300, Tony Lindgren wrote:
> > Let's check for valid console index values to avoid bogus console index
> > numbers from kernel command line. While struct console uses short for
> > index, and negative index values are used by some device drivers, we do
> > not want to allow negative values for preferred console.
>
> What drivers use a negative index for the console?
This is based on grepping with $ git grep "co->index =" drivers/tty/
Not sure what all might be stopping making struct console index unsigned.
Regards,
Tony
next prev parent reply other threads:[~2023-10-11 9:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 7:43 [PATCH v2 1/2] printk: Check valid console index for preferred console Tony Lindgren
2023-10-11 7:43 ` [PATCH v2 2/2] printk: Constify name for add_preferred_console() Tony Lindgren
2023-10-11 7:53 ` [PATCH v2 1/2] printk: Check valid console index for preferred console Greg Kroah-Hartman
2023-10-11 9:18 ` Tony Lindgren [this message]
2023-10-11 15:26 ` Petr Mladek
2023-10-11 16:17 ` Tony Lindgren
2023-10-12 5:53 ` Jiri Slaby
2023-10-12 6:24 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231011091803.GC34982@atomide.com \
--to=tony@atomide.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.