From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andy@kernel.org>,
Peter Korsgaard <peter.korsgaard@barco.com>,
Peter Rosin <peda@axentia.se>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH 0/3] i2c: mux: don't access GPIOLIB internal structures
Date: Wed, 11 Oct 2023 15:02:01 +0200 [thread overview]
Message-ID: <20231011130204.52265-1-brgl@bgdev.pl> (raw)
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
The backstory for this short series is that we are identyfing and
removing all unauthorized uses of GPIOLIB structures across the kernel.
For example: there are many users that access struct gpio_chip when the
only user allowed to safely do this is the provider of that chip.
We are very close to removing gpiochip_find(). Another function that
poses a similar problem is gpiod_to_chip() which also returns the
address of the underlying gpio_chip without assuring that it will not go
away e.g. due to a hot-unplug event or a device unbind.
We'll need to replace it with gpiod_to_gpio_device() across the entire
tree. Let's start by actually providing it and adding the first user:
the i2c-mux-gpio driver which dereferences the otherwise opaque struct
gpio_desc.
Let's also add a helper that allows to retrieve the address of the
struct device backing the GPIO device as this is another valid use-case.
Finally, let's un-include the GPIO private header and fix the code to
access the device in a safe way.
As the change is pretty minor, it would be best if patch 3/3 could be
acked by the I2C mux maintainers and went through the GPIO tree.
Otherwise, I can apply patches 1 and 2 and provide an immutable branch.
Bartosz Golaszewski (3):
gpiolib: provide gpio_device_to_device()
gpiolib: provide gpiod_to_gpio_device()
i2c: mux: gpio: don't fiddle with GPIOLIB internals
drivers/gpio/gpiolib.c | 38 ++++++++++++++++++++++++++++++++
drivers/i2c/muxes/i2c-mux-gpio.c | 12 +++++-----
include/linux/gpio/driver.h | 3 +++
3 files changed, 47 insertions(+), 6 deletions(-)
--
2.39.2
next reply other threads:[~2023-10-11 13:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 13:02 Bartosz Golaszewski [this message]
2023-10-11 13:02 ` [PATCH 1/3] gpiolib: provide gpio_device_to_device() Bartosz Golaszewski
2023-10-11 14:57 ` Peter Rosin
2023-10-11 15:18 ` Andy Shevchenko
2023-10-11 13:02 ` [PATCH 2/3] gpiolib: provide gpiod_to_gpio_device() Bartosz Golaszewski
2023-10-11 14:58 ` Peter Rosin
2023-10-11 15:23 ` Andy Shevchenko
2023-10-11 15:39 ` Bartosz Golaszewski
2023-10-12 6:57 ` Linus Walleij
2023-10-11 15:28 ` Andy Shevchenko
2023-10-11 13:02 ` [PATCH 3/3] i2c: mux: gpio: don't fiddle with GPIOLIB internals Bartosz Golaszewski
2023-10-11 14:59 ` Peter Rosin
2023-10-11 15:03 ` Bartosz Golaszewski
2023-10-11 16:41 ` Wolfram Sang
2023-10-11 15:18 ` Andy Shevchenko
2023-10-12 6:59 ` [PATCH 0/3] i2c: mux: don't access GPIOLIB internal structures Linus Walleij
2023-10-13 6:50 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231011130204.52265-1-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=andy@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=peter.korsgaard@barco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.