From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8E42CD6E67 for ; Wed, 11 Oct 2023 13:26:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4YrjkmK5upRYwbkDcj+pSMAUrTHwaFr1/OzjFdDvbY8=; b=PTp46rjtm5COlLthfPatD2xSNi TIJB49GUefblvOk9/ot/9i98lEhw9Lb6xQXsdArbjPSvaQY+pAJd3lh4PP7L40O6xMnOu/6b9gFSw +z9t9Oz2b8MoBenzHpEat+bs4Jec+dDa6/qVPMEv+VT9Lbc5MYT+amhm4RGKpLMmDdQ3n6DMotZi4 JupUa+6pQ9xsXKCWRTR5WhghXbiZHA12utBu5BgKU9ZDCAJCk/xXBb6jKzUmiRf5IeA++Q6O7BJMU 80gOedP9h04gkAkiOEEJ6uzkrPKBDsJKx2cFnsLwIl5DjTkIfDIESfWvqnwpAO1WT8mhymPDEFaXn o+SUR6dw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqZEO-00FyBt-2C; Wed, 11 Oct 2023 13:26:32 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qqZEN-00FyAx-0N; Wed, 11 Oct 2023 13:26:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=4YrjkmK5upRYwbkDcj+pSMAUrTHwaFr1/OzjFdDvbY8=; b=aAQZAN+flZxWL8H0Ca9UqhgfV4 W9SfV9Zn5blzAAWfrdp15Js+iKQgYPSrisaRei+aNk+qb4AJCIO3Rq5CGmV0JXbIiPU2Th9EJmu4T iixjwSloJZnVUquxcZuVYNJ9Upto+l4Q6xMJLTGL36lt19m+ACqAb9n1e4lyCNtgFw5FVGfp/p7CC tk/HJ7XOAZs6uKo54rdKZ9PmfG1G7wg6H78NJvCRnTROsQ7NtVAv1moa8w8ljlg3ocAw9qL0y1S0H x9LnP40TxO6q/6TdJJX4yYQF7uRyA+tMOOIbtl03cVzV/h/4FXh6ke4+gi8pEo3VznwxjIZyKpYuB a4hoboFg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qqZEJ-00AzIj-BZ; Wed, 11 Oct 2023 13:26:27 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 0BB0C30026F; Wed, 11 Oct 2023 15:26:27 +0200 (CEST) Date: Wed, 11 Oct 2023 15:26:26 +0200 From: Peter Zijlstra To: Kuyo Chang =?utf-8?B?KOW8teW7uuaWhyk=?= Cc: "dietmar.eggemann@arm.com" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "rostedt@goodmis.org" , wsd_upstream , "vschneid@redhat.com" , "bristot@redhat.com" , "juri.lelli@redhat.com" , "mingo@redhat.com" , "linux-arm-kernel@lists.infradead.org" , "bsegall@google.com" , "mgorman@suse.de" , "matthias.bgg@gmail.com" , "vincent.guittot@linaro.org" , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH] sched: Fix stop_one_cpu_nowait() vs hotplug Message-ID: <20231011132626.GP14330@noisy.programming.kicks-ass.net> References: <20230927033431.12406-1-kuyo.chang@mediatek.com> <20230927080850.GB21824@noisy.programming.kicks-ass.net> <20230929102135.GD6282@noisy.programming.kicks-ass.net> <8ad1b617a1040ce4cc56a5d04e8219b5313a9a6e.camel@mediatek.com> <20231010145747.GQ377@noisy.programming.kicks-ass.net> <20231010200442.GA16515@noisy.programming.kicks-ass.net> <172a3c89d7937725b61721e869eab3e5ae582643.camel@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <172a3c89d7937725b61721e869eab3e5ae582643.camel@mediatek.com> X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, Oct 11, 2023 at 03:24:19AM +0000, Kuyo Chang (張建文) wrote: > On Tue, 2023-10-10 at 22:04 +0200, Peter Zijlstra wrote: > > > > External email : Please do not click links or open attachments until > > you have verified the sender or the content. > > On Tue, Oct 10, 2023 at 04:57:47PM +0200, Peter Zijlstra wrote: > > > On Tue, Oct 10, 2023 at 02:40:22PM +0000, Kuyo Chang (張建文) wrote: > > > > > > It is running good so far(more than a week)on hotplug/set > > affinity > > > > stress test. I will keep it testing and report back if it happens > > > > again. > > > > > > OK, I suppose I should look at writing a coherent Changelog for > > this > > > then... > > > > Something like the below... ? > > > Thanks for illustrate the race scenario. It looks good to me. > But how about RT? Does RT also need this invocations as below? > > --- > kernel/sched/rt.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c > index e93b69ef919b..6aaf0a3d6081 100644 > --- a/kernel/sched/rt.c > +++ b/kernel/sched/rt.c > @@ -2063,9 +2063,11 @@ static int push_rt_task(struct rq *rq, bool > pull) > */ > push_task = get_push_task(rq); > if (push_task) { > + preempt_disable(); > raw_spin_rq_unlock(rq); > stop_one_cpu_nowait(rq->cpu, push_cpu_stop, > push_task, &rq->push_work); > + preempt_enable(); > raw_spin_rq_lock(rq); > } > > @@ -2402,9 +2404,11 @@ static void pull_rt_task(struct rq *this_rq) > double_unlock_balance(this_rq, src_rq); > > if (push_task) { > + preempt_disable(); > raw_spin_rq_unlock(this_rq); > stop_one_cpu_nowait(src_rq->cpu, push_cpu_stop, > push_task, &src_rq- > >push_work); > + preempt_enable(); > raw_spin_rq_lock(this_rq); > } > } bah, clearly git-grep didn't work for me last night, I'll go fix up. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A2C9CD6E67 for ; Wed, 11 Oct 2023 13:27:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CuuIXT7CPjedkWEALI9Fv2x2FOHwKGkfV1WncbS1j24=; b=ZSRYjbxdc8qt0+ Rfi6HuhCkmFUqmFgAt3azpOXC1Yf3TJjgX/utBSOlnTbMsjyIWjPkAG34itpoRfKH0J2CbK5VUp08 NW71r1rJXtmX7VAcimExZKYVjeEsxqMIdl0NyfvwP5ZufYjsXuJpvPT5oTvoQ2qrLbSDU/BTM6Bmn fDHmyauGR6F4aCHBwn9+NFA16L+R1v4mC7Lo50lyFuQGHpRMbbPtNmnJ1K+FiRwm3z0LKlh2qxrQe pQTrAG5tnk5Y/6U8iFNzfZzVQPUc969/mZ5G7Ud747X17GqIADjBxamO+ZXi7Sl//yzRdDSetJb85 JgHM82BTLzebUY+B6ZBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqZEO-00FyBc-0d; Wed, 11 Oct 2023 13:26:32 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qqZEN-00FyAx-0N; Wed, 11 Oct 2023 13:26:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=4YrjkmK5upRYwbkDcj+pSMAUrTHwaFr1/OzjFdDvbY8=; b=aAQZAN+flZxWL8H0Ca9UqhgfV4 W9SfV9Zn5blzAAWfrdp15Js+iKQgYPSrisaRei+aNk+qb4AJCIO3Rq5CGmV0JXbIiPU2Th9EJmu4T iixjwSloJZnVUquxcZuVYNJ9Upto+l4Q6xMJLTGL36lt19m+ACqAb9n1e4lyCNtgFw5FVGfp/p7CC tk/HJ7XOAZs6uKo54rdKZ9PmfG1G7wg6H78NJvCRnTROsQ7NtVAv1moa8w8ljlg3ocAw9qL0y1S0H x9LnP40TxO6q/6TdJJX4yYQF7uRyA+tMOOIbtl03cVzV/h/4FXh6ke4+gi8pEo3VznwxjIZyKpYuB a4hoboFg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qqZEJ-00AzIj-BZ; Wed, 11 Oct 2023 13:26:27 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 0BB0C30026F; Wed, 11 Oct 2023 15:26:27 +0200 (CEST) Date: Wed, 11 Oct 2023 15:26:26 +0200 From: Peter Zijlstra To: Kuyo Chang =?utf-8?B?KOW8teW7uuaWhyk=?= Cc: "dietmar.eggemann@arm.com" , "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "rostedt@goodmis.org" , wsd_upstream , "vschneid@redhat.com" , "bristot@redhat.com" , "juri.lelli@redhat.com" , "mingo@redhat.com" , "linux-arm-kernel@lists.infradead.org" , "bsegall@google.com" , "mgorman@suse.de" , "matthias.bgg@gmail.com" , "vincent.guittot@linaro.org" , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH] sched: Fix stop_one_cpu_nowait() vs hotplug Message-ID: <20231011132626.GP14330@noisy.programming.kicks-ass.net> References: <20230927033431.12406-1-kuyo.chang@mediatek.com> <20230927080850.GB21824@noisy.programming.kicks-ass.net> <20230929102135.GD6282@noisy.programming.kicks-ass.net> <8ad1b617a1040ce4cc56a5d04e8219b5313a9a6e.camel@mediatek.com> <20231010145747.GQ377@noisy.programming.kicks-ass.net> <20231010200442.GA16515@noisy.programming.kicks-ass.net> <172a3c89d7937725b61721e869eab3e5ae582643.camel@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <172a3c89d7937725b61721e869eab3e5ae582643.camel@mediatek.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBPY3QgMTEsIDIwMjMgYXQgMDM6MjQ6MTlBTSArMDAwMCwgS3V5byBDaGFuZyAo5by1 5bu65paHKSB3cm90ZToKPiBPbiBUdWUsIDIwMjMtMTAtMTAgYXQgMjI6MDQgKzAyMDAsIFBldGVy IFppamxzdHJhIHdyb3RlOgo+ID4gIAkgCj4gPiBFeHRlcm5hbCBlbWFpbCA6IFBsZWFzZSBkbyBu b3QgY2xpY2sgbGlua3Mgb3Igb3BlbiBhdHRhY2htZW50cyB1bnRpbAo+ID4geW91IGhhdmUgdmVy aWZpZWQgdGhlIHNlbmRlciBvciB0aGUgY29udGVudC4KPiA+ICBPbiBUdWUsIE9jdCAxMCwgMjAy MyBhdCAwNDo1Nzo0N1BNICswMjAwLCBQZXRlciBaaWpsc3RyYSB3cm90ZToKPiA+ID4gT24gVHVl LCBPY3QgMTAsIDIwMjMgYXQgMDI6NDA6MjJQTSArMDAwMCwgS3V5byBDaGFuZyAo5by15bu65paH KSB3cm90ZToKPiA+IAo+ID4gPiA+IEl0IGlzIHJ1bm5pbmcgZ29vZCBzbyBmYXIobW9yZSB0aGFu IGEgd2VlaylvbiBob3RwbHVnL3NldAo+ID4gYWZmaW5pdHkKPiA+ID4gPiBzdHJlc3MgdGVzdC4g SSB3aWxsIGtlZXAgaXQgdGVzdGluZyBhbmQgcmVwb3J0IGJhY2sgaWYgaXQgaGFwcGVucwo+ID4g PiA+IGFnYWluLgo+ID4gPiAKPiA+ID4gT0ssIEkgc3VwcG9zZSBJIHNob3VsZCBsb29rIGF0IHdy aXRpbmcgYSBjb2hlcmVudCBDaGFuZ2Vsb2cgZm9yCj4gPiB0aGlzCj4gPiA+IHRoZW4uLi4KPiA+ IAo+ID4gU29tZXRoaW5nIGxpa2UgdGhlIGJlbG93Li4uID8KPiA+IAo+IFRoYW5rcyBmb3IgaWxs dXN0cmF0ZSB0aGUgcmFjZSBzY2VuYXJpby4gSXQgbG9va3MgZ29vZCB0byBtZS4KPiBCdXQgaG93 IGFib3V0IFJUPyBEb2VzIFJUIGFsc28gbmVlZCB0aGlzIGludm9jYXRpb25zIGFzIGJlbG93Pwo+ IAo+IC0tLQo+ICBrZXJuZWwvc2NoZWQvcnQuYyB8IDQgKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwg NCBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2tlcm5lbC9zY2hlZC9ydC5jIGIva2Vy bmVsL3NjaGVkL3J0LmMKPiBpbmRleCBlOTNiNjllZjkxOWIuLjZhYWYwYTNkNjA4MSAxMDA2NDQK PiAtLS0gYS9rZXJuZWwvc2NoZWQvcnQuYwo+ICsrKyBiL2tlcm5lbC9zY2hlZC9ydC5jCj4gQEAg LTIwNjMsOSArMjA2MywxMSBAQCBzdGF0aWMgaW50IHB1c2hfcnRfdGFzayhzdHJ1Y3QgcnEgKnJx LCBib29sCj4gcHVsbCkKPiAgICAgICAgICAgICAgICAgICovCj4gICAgICAgICAgICAgICAgIHB1 c2hfdGFzayA9IGdldF9wdXNoX3Rhc2socnEpOwo+ICAgICAgICAgICAgICAgICBpZiAocHVzaF90 YXNrKSB7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgcHJlZW1wdF9kaXNhYmxlKCk7Cj4gICAg ICAgICAgICAgICAgICAgICAgICAgcmF3X3NwaW5fcnFfdW5sb2NrKHJxKTsKPiAgICAgICAgICAg ICAgICAgICAgICAgICBzdG9wX29uZV9jcHVfbm93YWl0KHJxLT5jcHUsIHB1c2hfY3B1X3N0b3As Cj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwdXNoX3Rhc2ss ICZycS0+cHVzaF93b3JrKTsKPiArICAgICAgICAgICAgICAgICAgICAgICBwcmVlbXB0X2VuYWJs ZSgpOwo+ICAgICAgICAgICAgICAgICAgICAgICAgIHJhd19zcGluX3JxX2xvY2socnEpOwo+ICAg ICAgICAgICAgICAgICB9Cj4gCj4gQEAgLTI0MDIsOSArMjQwNCwxMSBAQCBzdGF0aWMgdm9pZCBw dWxsX3J0X3Rhc2soc3RydWN0IHJxICp0aGlzX3JxKQo+ICAgICAgICAgICAgICAgICBkb3VibGVf dW5sb2NrX2JhbGFuY2UodGhpc19ycSwgc3JjX3JxKTsKPiAKPiAgICAgICAgICAgICAgICAgaWYg KHB1c2hfdGFzaykgewo+ICsgICAgICAgICAgICAgICAgICAgICAgIHByZWVtcHRfZGlzYWJsZSgp Owo+ICAgICAgICAgICAgICAgICAgICAgICAgIHJhd19zcGluX3JxX3VubG9jayh0aGlzX3JxKTsK PiAgICAgICAgICAgICAgICAgICAgICAgICBzdG9wX29uZV9jcHVfbm93YWl0KHNyY19ycS0+Y3B1 LCBwdXNoX2NwdV9zdG9wLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgcHVzaF90YXNrLCAmc3JjX3JxLQo+ID5wdXNoX3dvcmspOwo+ICsgICAgICAgICAgICAg ICAgICAgICAgIHByZWVtcHRfZW5hYmxlKCk7Cj4gICAgICAgICAgICAgICAgICAgICAgICAgcmF3 X3NwaW5fcnFfbG9jayh0aGlzX3JxKTsKPiAgICAgICAgICAgICAgICAgfQo+ICAgICAgICAgfQoK YmFoLCBjbGVhcmx5IGdpdC1ncmVwIGRpZG4ndCB3b3JrIGZvciBtZSBsYXN0IG5pZ2h0LCBJJ2xs IGdvIGZpeCB1cC4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFybS1rZXJuZWwK