From: Nam Cao <namcao@linutronix.de>
To: drosdeck <edson.drosdeck@gmail.com>
Cc: gregkh@linuxfoundation.org, hdegoede@redhat.com,
Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs:Fix coding style errors and warning
Date: Wed, 11 Oct 2023 18:39:37 +0200 [thread overview]
Message-ID: <20231011163937.WfJrCwdP@linutronix.de> (raw)
In-Reply-To: <20231011164232.28866-1-edson.drosdeck@gmail.com>
On Wed, Oct 11, 2023 at 01:42:32PM -0300, drosdeck wrote:
> Warning found by checkpatch.pl script. Fixes warning replacing printk to
> pr_crit and fixes conding style.
>
> Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>
You are doing too many different things in a single commit. Try
splitting them up: 1 commit change printk -> pr_crit, 1 commit add
brackets, etc.
Best regards,
Nam
next prev parent reply other threads:[~2023-10-11 16:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 16:42 [PATCH] staging: rtl8723bs:Fix coding style errors and warning drosdeck
2023-10-11 16:39 ` Nam Cao [this message]
2023-10-11 17:30 ` Dan Carpenter
2023-10-11 17:35 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231011163937.WfJrCwdP@linutronix.de \
--to=namcao@linutronix.de \
--cc=Larry.Finger@lwfinger.net \
--cc=edson.drosdeck@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.