From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81B73CDB481 for ; Wed, 11 Oct 2023 19:32:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=LhpvPk1WdO1021bT18BJTiYSNK8TkE1/wtJytVaxzE4=; b=p6mpwomhD15UqJ n/hH+UBzZO4a0d/9F7fvN2hlK0HblYtIUgUlKjAS23+xi40kde28iA7ke8y94Vxc5OAnuYuUfBZfD Pe6iPUHmDmgotQGxTEheygzqMfOoCzYz+Gbmiy6NTMD+FjbaW03loB95vxHqXejMeTVhI91kaaRAL bYRgq8FRrOGZlDcR8cEMY9E6cKLHMT+Qk5BC480bdH6dsGv5iSJKfpz/NRFu32onv6eHl5srQXTi4 bHUWbWn9CpH8BPUlRNcj+kykil8+T0LB7MBClzMPXnFfKZ76Hm8EQ40v/qI0ApoXK6KTkvlU9F5Tx UMZ2V6STFD2zhWG7XHLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqewJ-00GYKA-2D; Wed, 11 Oct 2023 19:32:15 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qqewG-00GYIr-1G; Wed, 11 Oct 2023 19:32:14 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id CAD73CE2527; Wed, 11 Oct 2023 19:32:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9236BC433C7; Wed, 11 Oct 2023 19:32:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697052728; bh=4k1m5qmcSDaP+SZOYD02LNDbpXJtj+6QzJq4iZ0fBT4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=PkSkfYndzZuEdhim2WqdUnaFkJa6/ULgDeXVhLamNMtNqjpEjDLFAOpinVDtpOf9t AUQ8IuXuDRsbGSvvuJcBOkesPKE+B6LOW3w499tPS1H5C+DTTGZEpqDhTJv73Rngtf R8n/q+wpIprV9354P5kNeMO1/5OdiCJZC921zzltoOp4qhTV4cqy8e0kXbMRCaqp4/ wgSGTdLCtZ0E1cvfJh/3oqFSKgGnYoWCp1qvbc5VbvIvmnclEI+2/Ls3QSTesrpdOn 1i9kPgcJmtJ/9DGNbL1W+mb7/ZJBeiArthYq4x+V47gI24Zx4H0qwEfuzJhfUtgURt hjOYzB4aN6mlQ== Date: Wed, 11 Oct 2023 14:32:06 -0500 From: Bjorn Helgaas To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= Cc: linux-pci@vger.kernel.org, Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Lukas Wunner , "Rafael J . Wysocki" , Heiner Kallweit , Emmanuel Grumbach , linux-kernel@vger.kernel.org, Bjorn Helgaas , ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, intel-wired-lan@lists.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-bluetooth@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 04/13] PCI/ASPM: Move L0S/L1/sub states mask calculation into a helper Message-ID: <20231011193206.GA1039708@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230918131103.24119-5-ilpo.jarvinen@linux.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231011_123212_805787_CD3BB6C4 X-CRM114-Status: GOOD ( 19.89 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+ath10k=archiver.kernel.org@lists.infradead.org T24gTW9uLCBTZXAgMTgsIDIwMjMgYXQgMDQ6MTA6NTRQTSArMDMwMCwgSWxwbyBKw6RydmluZW4g d3JvdGU6Cj4gQVNQTSBzZXJ2aWNlIGRyaXZlciBkb2VzIHRoZSBzYW1lIEwwUyAvIEwxUyAvIHN1 YiBzdGF0ZXMgYWxsb3dlZAo+IGNhbGN1bGF0aW9uIGluIF9fcGNpX2Rpc2FibGVfbGlua19zdGF0 ZSgpIGFuZAo+IHBjaV9zZXRfZGVmYXVsdF9saW5rX3N0YXRlKCkuCgpJcyB0aGVyZSBhIHR5cG8g b3Igc29tZXRoaW5nIGhlcmU/ICBUaGlzIHBhdGNoIG9ubHkgYWRkcyBhIGNhbGwgdG8KX19wY2lf ZGlzYWJsZV9saW5rX3N0YXRlKCksIG5vdCB0byBwY2lfc2V0X2RlZmF1bHRfbGlua19zdGF0ZSgp LgoKPiBDcmVhdGUgYSBoZWxwZXIgdG8gY2FsY3VsYXRlIHRoZSBtYXNrIGZvciB0aGUgYWxsb3dl ZCBzdGF0ZXMuCj4gCj4gU2lnbmVkLW9mZi1ieTogSWxwbyBKw6RydmluZW4gPGlscG8uamFydmlu ZW5AbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL3BjaS9wY2llL2FzcG0uYyB8IDMz ICsrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjEg aW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv cGNpL3BjaWUvYXNwbS5jIGIvZHJpdmVycy9wY2kvcGNpZS9hc3BtLmMKPiBpbmRleCBlYzZkN2Ew OTJhYzEuLjkxZGM5NWFjYTkwZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3BjaS9wY2llL2FzcG0u Ywo+ICsrKyBiL2RyaXZlcnMvcGNpL3BjaWUvYXNwbS5jCj4gQEAgLTEwMzQsNiArMTAzNCwyNiBA QCBzdGF0aWMgc3RydWN0IHBjaWVfbGlua19zdGF0ZSAqcGNpZV9hc3BtX2dldF9saW5rKHN0cnVj dCBwY2lfZGV2ICpwZGV2KQo+ICAJcmV0dXJuIGJyaWRnZS0+bGlua19zdGF0ZTsKPiAgfQo+ICAK PiArc3RhdGljIHU4IHBjaV9saW5rX3N0YXRlX21hc2soaW50IHN0YXRlKQo+ICt7Cj4gKwl1OCBy ZXN1bHQgPSAwOwo+ICsKPiArCWlmIChzdGF0ZSAmIFBDSUVfTElOS19TVEFURV9MMFMpCj4gKwkJ cmVzdWx0IHw9IEFTUE1fU1RBVEVfTDBTOwo+ICsJaWYgKHN0YXRlICYgUENJRV9MSU5LX1NUQVRF X0wxKQo+ICsJCXJlc3VsdCB8PSBBU1BNX1NUQVRFX0wxOwo+ICsJaWYgKHN0YXRlICYgUENJRV9M SU5LX1NUQVRFX0wxXzEpCj4gKwkJcmVzdWx0IHw9IEFTUE1fU1RBVEVfTDFfMTsKPiArCWlmIChz dGF0ZSAmIFBDSUVfTElOS19TVEFURV9MMV8yKQo+ICsJCXJlc3VsdCB8PSBBU1BNX1NUQVRFX0wx XzI7Cj4gKwlpZiAoc3RhdGUgJiBQQ0lFX0xJTktfU1RBVEVfTDFfMV9QQ0lQTSkKPiArCQlyZXN1 bHQgfD0gQVNQTV9TVEFURV9MMV8xX1BDSVBNOwo+ICsJaWYgKHN0YXRlICYgUENJRV9MSU5LX1NU QVRFX0wxXzJfUENJUE0pCj4gKwkJcmVzdWx0IHw9IEFTUE1fU1RBVEVfTDFfMl9QQ0lQTTsKPiAr Cj4gKwlyZXR1cm4gcmVzdWx0Owo+ICt9Cj4gKwo+ICBzdGF0aWMgaW50IF9fcGNpX2Rpc2FibGVf bGlua19zdGF0ZShzdHJ1Y3QgcGNpX2RldiAqcGRldiwgaW50IHN0YXRlLCBib29sIHNlbSkKPiAg ewo+ICAJc3RydWN0IHBjaWVfbGlua19zdGF0ZSAqbGluayA9IHBjaWVfYXNwbV9nZXRfbGluayhw ZGV2KTsKPiBAQCAtMTA2MywxOCArMTA4Myw3IEBAIHN0YXRpYyBpbnQgX19wY2lfZGlzYWJsZV9s aW5rX3N0YXRlKHN0cnVjdCBwY2lfZGV2ICpwZGV2LCBpbnQgc3RhdGUsIGJvb2wgc2VtKQo+ICAJ aWYgKHNlbSkKPiAgCQlkb3duX3JlYWQoJnBjaV9idXNfc2VtKTsKPiAgCW11dGV4X2xvY2soJmFz cG1fbG9jayk7Cj4gLQlpZiAoc3RhdGUgJiBQQ0lFX0xJTktfU1RBVEVfTDBTKQo+IC0JCWxpbmst PmFzcG1fZGlzYWJsZSB8PSBBU1BNX1NUQVRFX0wwUzsKPiAtCWlmIChzdGF0ZSAmIFBDSUVfTElO S19TVEFURV9MMSkKPiAtCQlsaW5rLT5hc3BtX2Rpc2FibGUgfD0gQVNQTV9TVEFURV9MMTsKPiAt CWlmIChzdGF0ZSAmIFBDSUVfTElOS19TVEFURV9MMV8xKQo+IC0JCWxpbmstPmFzcG1fZGlzYWJs ZSB8PSBBU1BNX1NUQVRFX0wxXzE7Cj4gLQlpZiAoc3RhdGUgJiBQQ0lFX0xJTktfU1RBVEVfTDFf MikKPiAtCQlsaW5rLT5hc3BtX2Rpc2FibGUgfD0gQVNQTV9TVEFURV9MMV8yOwo+IC0JaWYgKHN0 YXRlICYgUENJRV9MSU5LX1NUQVRFX0wxXzFfUENJUE0pCj4gLQkJbGluay0+YXNwbV9kaXNhYmxl IHw9IEFTUE1fU1RBVEVfTDFfMV9QQ0lQTTsKPiAtCWlmIChzdGF0ZSAmIFBDSUVfTElOS19TVEFU RV9MMV8yX1BDSVBNKQo+IC0JCWxpbmstPmFzcG1fZGlzYWJsZSB8PSBBU1BNX1NUQVRFX0wxXzJf UENJUE07Cj4gKwlsaW5rLT5hc3BtX2Rpc2FibGUgfD0gcGNpX2xpbmtfc3RhdGVfbWFzayhzdGF0 ZSk7Cj4gIAlwY2llX2NvbmZpZ19hc3BtX2xpbmsobGluaywgcG9saWN5X3RvX2FzcG1fc3RhdGUo bGluaykpOwo+ICAKPiAgCWlmIChzdGF0ZSAmIFBDSUVfTElOS19TVEFURV9DTEtQTSkKPiAtLSAK PiAyLjMwLjIKPiAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwo+IGxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cj4gbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCj4gaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwphdGgxMGsgbWFpbGluZyBsaXN0CmF0aDEwa0BsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vYXRo MTBrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 139C8CDB47E for ; Wed, 11 Oct 2023 19:32:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=7fxhBouXjXKL8uywHz9ijM++0OQBnAoHfv51gZJHvN8=; b=Om8Ry+QOsx88Vo XFGlhAw/3l0XIwJgcnZws1Jsnv2D2O5jxKaqq02ZHFxUQSqCM23OGvp61XqHFwBRIlV+Mob6RJjup uLLj34vx+XTc4SCpFIPlUOYk+JCx6JVvxLX1kZKlyHxSLrS34jb87epuusCJLn3VzDjj7ccZuebC1 YAfRCZGZ2OdV35xhF+UqxYi416XUp2SrHw8az0KB+usv7Ek1gJlpDpqdC/bS7yHH35qI1EtLH9pKr KdF9wBdVZoTbM6ck7jEafFLtApjc8VLQ/m8hfOJYR54KgUTL6DGxd2NtCxS0QThG/jvmcEh3Cd/Cl /e27tz0nEBbRpwaabAWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqewK-00GYKu-0u; Wed, 11 Oct 2023 19:32:16 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qqewG-00GYIr-1G; Wed, 11 Oct 2023 19:32:14 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id CAD73CE2527; Wed, 11 Oct 2023 19:32:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9236BC433C7; Wed, 11 Oct 2023 19:32:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697052728; bh=4k1m5qmcSDaP+SZOYD02LNDbpXJtj+6QzJq4iZ0fBT4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=PkSkfYndzZuEdhim2WqdUnaFkJa6/ULgDeXVhLamNMtNqjpEjDLFAOpinVDtpOf9t AUQ8IuXuDRsbGSvvuJcBOkesPKE+B6LOW3w499tPS1H5C+DTTGZEpqDhTJv73Rngtf R8n/q+wpIprV9354P5kNeMO1/5OdiCJZC921zzltoOp4qhTV4cqy8e0kXbMRCaqp4/ wgSGTdLCtZ0E1cvfJh/3oqFSKgGnYoWCp1qvbc5VbvIvmnclEI+2/Ls3QSTesrpdOn 1i9kPgcJmtJ/9DGNbL1W+mb7/ZJBeiArthYq4x+V47gI24Zx4H0qwEfuzJhfUtgURt hjOYzB4aN6mlQ== Date: Wed, 11 Oct 2023 14:32:06 -0500 From: Bjorn Helgaas To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= Cc: linux-pci@vger.kernel.org, Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Lukas Wunner , "Rafael J . Wysocki" , Heiner Kallweit , Emmanuel Grumbach , linux-kernel@vger.kernel.org, Bjorn Helgaas , ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, intel-wired-lan@lists.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-bluetooth@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 04/13] PCI/ASPM: Move L0S/L1/sub states mask calculation into a helper Message-ID: <20231011193206.GA1039708@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230918131103.24119-5-ilpo.jarvinen@linux.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231011_123212_805787_CD3BB6C4 X-CRM114-Status: GOOD ( 19.89 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org T24gTW9uLCBTZXAgMTgsIDIwMjMgYXQgMDQ6MTA6NTRQTSArMDMwMCwgSWxwbyBKw6RydmluZW4g d3JvdGU6Cj4gQVNQTSBzZXJ2aWNlIGRyaXZlciBkb2VzIHRoZSBzYW1lIEwwUyAvIEwxUyAvIHN1 YiBzdGF0ZXMgYWxsb3dlZAo+IGNhbGN1bGF0aW9uIGluIF9fcGNpX2Rpc2FibGVfbGlua19zdGF0 ZSgpIGFuZAo+IHBjaV9zZXRfZGVmYXVsdF9saW5rX3N0YXRlKCkuCgpJcyB0aGVyZSBhIHR5cG8g b3Igc29tZXRoaW5nIGhlcmU/ICBUaGlzIHBhdGNoIG9ubHkgYWRkcyBhIGNhbGwgdG8KX19wY2lf ZGlzYWJsZV9saW5rX3N0YXRlKCksIG5vdCB0byBwY2lfc2V0X2RlZmF1bHRfbGlua19zdGF0ZSgp LgoKPiBDcmVhdGUgYSBoZWxwZXIgdG8gY2FsY3VsYXRlIHRoZSBtYXNrIGZvciB0aGUgYWxsb3dl ZCBzdGF0ZXMuCj4gCj4gU2lnbmVkLW9mZi1ieTogSWxwbyBKw6RydmluZW4gPGlscG8uamFydmlu ZW5AbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL3BjaS9wY2llL2FzcG0uYyB8IDMz ICsrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjEg aW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv cGNpL3BjaWUvYXNwbS5jIGIvZHJpdmVycy9wY2kvcGNpZS9hc3BtLmMKPiBpbmRleCBlYzZkN2Ew OTJhYzEuLjkxZGM5NWFjYTkwZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3BjaS9wY2llL2FzcG0u Ywo+ICsrKyBiL2RyaXZlcnMvcGNpL3BjaWUvYXNwbS5jCj4gQEAgLTEwMzQsNiArMTAzNCwyNiBA QCBzdGF0aWMgc3RydWN0IHBjaWVfbGlua19zdGF0ZSAqcGNpZV9hc3BtX2dldF9saW5rKHN0cnVj dCBwY2lfZGV2ICpwZGV2KQo+ICAJcmV0dXJuIGJyaWRnZS0+bGlua19zdGF0ZTsKPiAgfQo+ICAK PiArc3RhdGljIHU4IHBjaV9saW5rX3N0YXRlX21hc2soaW50IHN0YXRlKQo+ICt7Cj4gKwl1OCBy ZXN1bHQgPSAwOwo+ICsKPiArCWlmIChzdGF0ZSAmIFBDSUVfTElOS19TVEFURV9MMFMpCj4gKwkJ cmVzdWx0IHw9IEFTUE1fU1RBVEVfTDBTOwo+ICsJaWYgKHN0YXRlICYgUENJRV9MSU5LX1NUQVRF X0wxKQo+ICsJCXJlc3VsdCB8PSBBU1BNX1NUQVRFX0wxOwo+ICsJaWYgKHN0YXRlICYgUENJRV9M SU5LX1NUQVRFX0wxXzEpCj4gKwkJcmVzdWx0IHw9IEFTUE1fU1RBVEVfTDFfMTsKPiArCWlmIChz dGF0ZSAmIFBDSUVfTElOS19TVEFURV9MMV8yKQo+ICsJCXJlc3VsdCB8PSBBU1BNX1NUQVRFX0wx XzI7Cj4gKwlpZiAoc3RhdGUgJiBQQ0lFX0xJTktfU1RBVEVfTDFfMV9QQ0lQTSkKPiArCQlyZXN1 bHQgfD0gQVNQTV9TVEFURV9MMV8xX1BDSVBNOwo+ICsJaWYgKHN0YXRlICYgUENJRV9MSU5LX1NU QVRFX0wxXzJfUENJUE0pCj4gKwkJcmVzdWx0IHw9IEFTUE1fU1RBVEVfTDFfMl9QQ0lQTTsKPiAr Cj4gKwlyZXR1cm4gcmVzdWx0Owo+ICt9Cj4gKwo+ICBzdGF0aWMgaW50IF9fcGNpX2Rpc2FibGVf bGlua19zdGF0ZShzdHJ1Y3QgcGNpX2RldiAqcGRldiwgaW50IHN0YXRlLCBib29sIHNlbSkKPiAg ewo+ICAJc3RydWN0IHBjaWVfbGlua19zdGF0ZSAqbGluayA9IHBjaWVfYXNwbV9nZXRfbGluayhw ZGV2KTsKPiBAQCAtMTA2MywxOCArMTA4Myw3IEBAIHN0YXRpYyBpbnQgX19wY2lfZGlzYWJsZV9s aW5rX3N0YXRlKHN0cnVjdCBwY2lfZGV2ICpwZGV2LCBpbnQgc3RhdGUsIGJvb2wgc2VtKQo+ICAJ aWYgKHNlbSkKPiAgCQlkb3duX3JlYWQoJnBjaV9idXNfc2VtKTsKPiAgCW11dGV4X2xvY2soJmFz cG1fbG9jayk7Cj4gLQlpZiAoc3RhdGUgJiBQQ0lFX0xJTktfU1RBVEVfTDBTKQo+IC0JCWxpbmst PmFzcG1fZGlzYWJsZSB8PSBBU1BNX1NUQVRFX0wwUzsKPiAtCWlmIChzdGF0ZSAmIFBDSUVfTElO S19TVEFURV9MMSkKPiAtCQlsaW5rLT5hc3BtX2Rpc2FibGUgfD0gQVNQTV9TVEFURV9MMTsKPiAt CWlmIChzdGF0ZSAmIFBDSUVfTElOS19TVEFURV9MMV8xKQo+IC0JCWxpbmstPmFzcG1fZGlzYWJs ZSB8PSBBU1BNX1NUQVRFX0wxXzE7Cj4gLQlpZiAoc3RhdGUgJiBQQ0lFX0xJTktfU1RBVEVfTDFf MikKPiAtCQlsaW5rLT5hc3BtX2Rpc2FibGUgfD0gQVNQTV9TVEFURV9MMV8yOwo+IC0JaWYgKHN0 YXRlICYgUENJRV9MSU5LX1NUQVRFX0wxXzFfUENJUE0pCj4gLQkJbGluay0+YXNwbV9kaXNhYmxl IHw9IEFTUE1fU1RBVEVfTDFfMV9QQ0lQTTsKPiAtCWlmIChzdGF0ZSAmIFBDSUVfTElOS19TVEFU RV9MMV8yX1BDSVBNKQo+IC0JCWxpbmstPmFzcG1fZGlzYWJsZSB8PSBBU1BNX1NUQVRFX0wxXzJf UENJUE07Cj4gKwlsaW5rLT5hc3BtX2Rpc2FibGUgfD0gcGNpX2xpbmtfc3RhdGVfbWFzayhzdGF0 ZSk7Cj4gIAlwY2llX2NvbmZpZ19hc3BtX2xpbmsobGluaywgcG9saWN5X3RvX2FzcG1fc3RhdGUo bGluaykpOwo+ICAKPiAgCWlmIChzdGF0ZSAmIFBDSUVfTElOS19TVEFURV9DTEtQTSkKPiAtLSAK PiAyLjMwLjIKPiAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwo+IGxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cj4gbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCj4gaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCgotLSAKYXRoMTFrIG1haWxpbmcgbGlzdAphdGgx MWtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2F0aDExawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60305CDB485 for ; Wed, 11 Oct 2023 19:32:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=cRxRR6DO8dv+DzhWyaB0nPS6A9F9y2yFL1278GiyS+4=; b=i0tfyRpO3Knz5i mAB8GhR+6sQOylmkyGwBD8He/H2rNOcgcEvvTqtrM636fZZBMLzV9sMUMToddiPwcV6u5hFIt4XDz lQ5bEO3FTBiw0DSJE78+u3W3HoZCmxWqb9BW7BvX2ICNKSrpTR/a++2i7wde0gekWF40qJ2Gq4euw nVUIMiTqO0q72MfpFssQoy42Tl4WVH1Pkovt/Q9pWlB08l7+frAGDo3OWvuYZSiR6yjZYaXRmPSJ8 XRMAPIRrfx+FliWyj1YzSWmfcuDa0wlKq1wG7bQd3AYQkD7uw5FC2TC+bh6rSwhMrU6PI8o2yNFxi aFUXbSe8oTBMibrbtB3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqewK-00GYLL-2t for ath12k@archiver.kernel.org; Wed, 11 Oct 2023 19:32:16 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qqewG-00GYIr-1G; Wed, 11 Oct 2023 19:32:14 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id CAD73CE2527; Wed, 11 Oct 2023 19:32:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9236BC433C7; Wed, 11 Oct 2023 19:32:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697052728; bh=4k1m5qmcSDaP+SZOYD02LNDbpXJtj+6QzJq4iZ0fBT4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=PkSkfYndzZuEdhim2WqdUnaFkJa6/ULgDeXVhLamNMtNqjpEjDLFAOpinVDtpOf9t AUQ8IuXuDRsbGSvvuJcBOkesPKE+B6LOW3w499tPS1H5C+DTTGZEpqDhTJv73Rngtf R8n/q+wpIprV9354P5kNeMO1/5OdiCJZC921zzltoOp4qhTV4cqy8e0kXbMRCaqp4/ wgSGTdLCtZ0E1cvfJh/3oqFSKgGnYoWCp1qvbc5VbvIvmnclEI+2/Ls3QSTesrpdOn 1i9kPgcJmtJ/9DGNbL1W+mb7/ZJBeiArthYq4x+V47gI24Zx4H0qwEfuzJhfUtgURt hjOYzB4aN6mlQ== Date: Wed, 11 Oct 2023 14:32:06 -0500 From: Bjorn Helgaas To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= Cc: linux-pci@vger.kernel.org, Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Lukas Wunner , "Rafael J . Wysocki" , Heiner Kallweit , Emmanuel Grumbach , linux-kernel@vger.kernel.org, Bjorn Helgaas , ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, intel-wired-lan@lists.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-bluetooth@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 04/13] PCI/ASPM: Move L0S/L1/sub states mask calculation into a helper Message-ID: <20231011193206.GA1039708@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230918131103.24119-5-ilpo.jarvinen@linux.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231011_123212_805787_CD3BB6C4 X-CRM114-Status: GOOD ( 19.89 ) X-BeenThere: ath12k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath12k" Errors-To: ath12k-bounces+ath12k=archiver.kernel.org@lists.infradead.org T24gTW9uLCBTZXAgMTgsIDIwMjMgYXQgMDQ6MTA6NTRQTSArMDMwMCwgSWxwbyBKw6RydmluZW4g d3JvdGU6Cj4gQVNQTSBzZXJ2aWNlIGRyaXZlciBkb2VzIHRoZSBzYW1lIEwwUyAvIEwxUyAvIHN1 YiBzdGF0ZXMgYWxsb3dlZAo+IGNhbGN1bGF0aW9uIGluIF9fcGNpX2Rpc2FibGVfbGlua19zdGF0 ZSgpIGFuZAo+IHBjaV9zZXRfZGVmYXVsdF9saW5rX3N0YXRlKCkuCgpJcyB0aGVyZSBhIHR5cG8g b3Igc29tZXRoaW5nIGhlcmU/ICBUaGlzIHBhdGNoIG9ubHkgYWRkcyBhIGNhbGwgdG8KX19wY2lf ZGlzYWJsZV9saW5rX3N0YXRlKCksIG5vdCB0byBwY2lfc2V0X2RlZmF1bHRfbGlua19zdGF0ZSgp LgoKPiBDcmVhdGUgYSBoZWxwZXIgdG8gY2FsY3VsYXRlIHRoZSBtYXNrIGZvciB0aGUgYWxsb3dl ZCBzdGF0ZXMuCj4gCj4gU2lnbmVkLW9mZi1ieTogSWxwbyBKw6RydmluZW4gPGlscG8uamFydmlu ZW5AbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL3BjaS9wY2llL2FzcG0uYyB8IDMz ICsrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjEg aW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv cGNpL3BjaWUvYXNwbS5jIGIvZHJpdmVycy9wY2kvcGNpZS9hc3BtLmMKPiBpbmRleCBlYzZkN2Ew OTJhYzEuLjkxZGM5NWFjYTkwZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3BjaS9wY2llL2FzcG0u Ywo+ICsrKyBiL2RyaXZlcnMvcGNpL3BjaWUvYXNwbS5jCj4gQEAgLTEwMzQsNiArMTAzNCwyNiBA QCBzdGF0aWMgc3RydWN0IHBjaWVfbGlua19zdGF0ZSAqcGNpZV9hc3BtX2dldF9saW5rKHN0cnVj dCBwY2lfZGV2ICpwZGV2KQo+ICAJcmV0dXJuIGJyaWRnZS0+bGlua19zdGF0ZTsKPiAgfQo+ICAK PiArc3RhdGljIHU4IHBjaV9saW5rX3N0YXRlX21hc2soaW50IHN0YXRlKQo+ICt7Cj4gKwl1OCBy ZXN1bHQgPSAwOwo+ICsKPiArCWlmIChzdGF0ZSAmIFBDSUVfTElOS19TVEFURV9MMFMpCj4gKwkJ cmVzdWx0IHw9IEFTUE1fU1RBVEVfTDBTOwo+ICsJaWYgKHN0YXRlICYgUENJRV9MSU5LX1NUQVRF X0wxKQo+ICsJCXJlc3VsdCB8PSBBU1BNX1NUQVRFX0wxOwo+ICsJaWYgKHN0YXRlICYgUENJRV9M SU5LX1NUQVRFX0wxXzEpCj4gKwkJcmVzdWx0IHw9IEFTUE1fU1RBVEVfTDFfMTsKPiArCWlmIChz dGF0ZSAmIFBDSUVfTElOS19TVEFURV9MMV8yKQo+ICsJCXJlc3VsdCB8PSBBU1BNX1NUQVRFX0wx XzI7Cj4gKwlpZiAoc3RhdGUgJiBQQ0lFX0xJTktfU1RBVEVfTDFfMV9QQ0lQTSkKPiArCQlyZXN1 bHQgfD0gQVNQTV9TVEFURV9MMV8xX1BDSVBNOwo+ICsJaWYgKHN0YXRlICYgUENJRV9MSU5LX1NU QVRFX0wxXzJfUENJUE0pCj4gKwkJcmVzdWx0IHw9IEFTUE1fU1RBVEVfTDFfMl9QQ0lQTTsKPiAr Cj4gKwlyZXR1cm4gcmVzdWx0Owo+ICt9Cj4gKwo+ICBzdGF0aWMgaW50IF9fcGNpX2Rpc2FibGVf bGlua19zdGF0ZShzdHJ1Y3QgcGNpX2RldiAqcGRldiwgaW50IHN0YXRlLCBib29sIHNlbSkKPiAg ewo+ICAJc3RydWN0IHBjaWVfbGlua19zdGF0ZSAqbGluayA9IHBjaWVfYXNwbV9nZXRfbGluayhw ZGV2KTsKPiBAQCAtMTA2MywxOCArMTA4Myw3IEBAIHN0YXRpYyBpbnQgX19wY2lfZGlzYWJsZV9s aW5rX3N0YXRlKHN0cnVjdCBwY2lfZGV2ICpwZGV2LCBpbnQgc3RhdGUsIGJvb2wgc2VtKQo+ICAJ aWYgKHNlbSkKPiAgCQlkb3duX3JlYWQoJnBjaV9idXNfc2VtKTsKPiAgCW11dGV4X2xvY2soJmFz cG1fbG9jayk7Cj4gLQlpZiAoc3RhdGUgJiBQQ0lFX0xJTktfU1RBVEVfTDBTKQo+IC0JCWxpbmst PmFzcG1fZGlzYWJsZSB8PSBBU1BNX1NUQVRFX0wwUzsKPiAtCWlmIChzdGF0ZSAmIFBDSUVfTElO S19TVEFURV9MMSkKPiAtCQlsaW5rLT5hc3BtX2Rpc2FibGUgfD0gQVNQTV9TVEFURV9MMTsKPiAt CWlmIChzdGF0ZSAmIFBDSUVfTElOS19TVEFURV9MMV8xKQo+IC0JCWxpbmstPmFzcG1fZGlzYWJs ZSB8PSBBU1BNX1NUQVRFX0wxXzE7Cj4gLQlpZiAoc3RhdGUgJiBQQ0lFX0xJTktfU1RBVEVfTDFf MikKPiAtCQlsaW5rLT5hc3BtX2Rpc2FibGUgfD0gQVNQTV9TVEFURV9MMV8yOwo+IC0JaWYgKHN0 YXRlICYgUENJRV9MSU5LX1NUQVRFX0wxXzFfUENJUE0pCj4gLQkJbGluay0+YXNwbV9kaXNhYmxl IHw9IEFTUE1fU1RBVEVfTDFfMV9QQ0lQTTsKPiAtCWlmIChzdGF0ZSAmIFBDSUVfTElOS19TVEFU RV9MMV8yX1BDSVBNKQo+IC0JCWxpbmstPmFzcG1fZGlzYWJsZSB8PSBBU1BNX1NUQVRFX0wxXzJf UENJUE07Cj4gKwlsaW5rLT5hc3BtX2Rpc2FibGUgfD0gcGNpX2xpbmtfc3RhdGVfbWFzayhzdGF0 ZSk7Cj4gIAlwY2llX2NvbmZpZ19hc3BtX2xpbmsobGluaywgcG9saWN5X3RvX2FzcG1fc3RhdGUo bGluaykpOwo+ICAKPiAgCWlmIChzdGF0ZSAmIFBDSUVfTElOS19TVEFURV9DTEtQTSkKPiAtLSAK PiAyLjMwLjIKPiAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwo+IGxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cj4gbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCj4gaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCgotLSAKYXRoMTJrIG1haWxpbmcgbGlzdAphdGgx MmtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9hdGgxMmsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A21ACDB47E for ; Wed, 11 Oct 2023 19:32:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id CD317610D1; Wed, 11 Oct 2023 19:32:20 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org CD317610D1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1697052740; bh=Tr4RdKMfXr/N4nYQNkO09MKTkwiOnWd4ejPYFfBUsy8=; h=Date:From:To:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:Cc:From; b=h0Qagmi78f33ly34x1CIgkNImO3fyHT6GHphtBnWz3bPilBkV/JbcWobyIDDrj/e+ s+7dPOdyXztlcWaVlanZiG0AxTjDdyhqmoSrgZApUrSB1vpGpIR0rmqNEk4H/Yi5H1 h/Ho4O5IEJWHyDOo6LEB4sV29RUfLKwZAMxhOyRXlZ7PDnqBafZxcScPUZjD5aZaQu X43p4CbOPCgZk1H9qpA+qWrcQxxAo0Ceahe+S8Cc6ZmThQ+2zi5Io1sfw2lJvuLegY J2oyJZfgMwXo4CQhxEldkhVvAdVrwQYJrCpJY/li2wFofUbQhxCrf6TWtEudT3bUX9 u1Ut2f/89sQwg== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 59xbWsVaBx9v; Wed, 11 Oct 2023 19:32:16 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 986E760E6B; Wed, 11 Oct 2023 19:32:16 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 986E760E6B Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id C50F11BF3E9 for ; Wed, 11 Oct 2023 19:32:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 96F574154D for ; Wed, 11 Oct 2023 19:32:15 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 96F574154D X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YL6aIckrnOGX for ; Wed, 11 Oct 2023 19:32:14 +0000 (UTC) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by smtp4.osuosl.org (Postfix) with ESMTPS id 0C7754154E for ; Wed, 11 Oct 2023 19:32:13 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 0C7754154E Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id CAD73CE2527; Wed, 11 Oct 2023 19:32:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9236BC433C7; Wed, 11 Oct 2023 19:32:08 +0000 (UTC) Date: Wed, 11 Oct 2023 14:32:06 -0500 From: Bjorn Helgaas To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= Message-ID: <20231011193206.GA1039708@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230918131103.24119-5-ilpo.jarvinen@linux.intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697052728; bh=4k1m5qmcSDaP+SZOYD02LNDbpXJtj+6QzJq4iZ0fBT4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=PkSkfYndzZuEdhim2WqdUnaFkJa6/ULgDeXVhLamNMtNqjpEjDLFAOpinVDtpOf9t AUQ8IuXuDRsbGSvvuJcBOkesPKE+B6LOW3w499tPS1H5C+DTTGZEpqDhTJv73Rngtf R8n/q+wpIprV9354P5kNeMO1/5OdiCJZC921zzltoOp4qhTV4cqy8e0kXbMRCaqp4/ wgSGTdLCtZ0E1cvfJh/3oqFSKgGnYoWCp1qvbc5VbvIvmnclEI+2/Ls3QSTesrpdOn 1i9kPgcJmtJ/9DGNbL1W+mb7/ZJBeiArthYq4x+V47gI24Zx4H0qwEfuzJhfUtgURt hjOYzB4aN6mlQ== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=PkSkfYnd Subject: Re: [Intel-wired-lan] [PATCH v2 04/13] PCI/ASPM: Move L0S/L1/sub states mask calculation into a helper X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , linux-rdma@vger.kernel.org, Lorenzo Pieralisi , "Rafael J . Wysocki" , ath12k@lists.infradead.org, linux-pci@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, Emmanuel Grumbach , linux-bluetooth@vger.kernel.org, Lukas Wunner , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Bjorn Helgaas , linux-mediatek@lists.infradead.org, Rob Herring , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" T24gTW9uLCBTZXAgMTgsIDIwMjMgYXQgMDQ6MTA6NTRQTSArMDMwMCwgSWxwbyBKw6RydmluZW4g d3JvdGU6Cj4gQVNQTSBzZXJ2aWNlIGRyaXZlciBkb2VzIHRoZSBzYW1lIEwwUyAvIEwxUyAvIHN1 YiBzdGF0ZXMgYWxsb3dlZAo+IGNhbGN1bGF0aW9uIGluIF9fcGNpX2Rpc2FibGVfbGlua19zdGF0 ZSgpIGFuZAo+IHBjaV9zZXRfZGVmYXVsdF9saW5rX3N0YXRlKCkuCgpJcyB0aGVyZSBhIHR5cG8g b3Igc29tZXRoaW5nIGhlcmU/ICBUaGlzIHBhdGNoIG9ubHkgYWRkcyBhIGNhbGwgdG8KX19wY2lf ZGlzYWJsZV9saW5rX3N0YXRlKCksIG5vdCB0byBwY2lfc2V0X2RlZmF1bHRfbGlua19zdGF0ZSgp LgoKPiBDcmVhdGUgYSBoZWxwZXIgdG8gY2FsY3VsYXRlIHRoZSBtYXNrIGZvciB0aGUgYWxsb3dl ZCBzdGF0ZXMuCj4gCj4gU2lnbmVkLW9mZi1ieTogSWxwbyBKw6RydmluZW4gPGlscG8uamFydmlu ZW5AbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL3BjaS9wY2llL2FzcG0uYyB8IDMz ICsrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjEg aW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv cGNpL3BjaWUvYXNwbS5jIGIvZHJpdmVycy9wY2kvcGNpZS9hc3BtLmMKPiBpbmRleCBlYzZkN2Ew OTJhYzEuLjkxZGM5NWFjYTkwZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3BjaS9wY2llL2FzcG0u Ywo+ICsrKyBiL2RyaXZlcnMvcGNpL3BjaWUvYXNwbS5jCj4gQEAgLTEwMzQsNiArMTAzNCwyNiBA QCBzdGF0aWMgc3RydWN0IHBjaWVfbGlua19zdGF0ZSAqcGNpZV9hc3BtX2dldF9saW5rKHN0cnVj dCBwY2lfZGV2ICpwZGV2KQo+ICAJcmV0dXJuIGJyaWRnZS0+bGlua19zdGF0ZTsKPiAgfQo+ICAK PiArc3RhdGljIHU4IHBjaV9saW5rX3N0YXRlX21hc2soaW50IHN0YXRlKQo+ICt7Cj4gKwl1OCBy ZXN1bHQgPSAwOwo+ICsKPiArCWlmIChzdGF0ZSAmIFBDSUVfTElOS19TVEFURV9MMFMpCj4gKwkJ cmVzdWx0IHw9IEFTUE1fU1RBVEVfTDBTOwo+ICsJaWYgKHN0YXRlICYgUENJRV9MSU5LX1NUQVRF X0wxKQo+ICsJCXJlc3VsdCB8PSBBU1BNX1NUQVRFX0wxOwo+ICsJaWYgKHN0YXRlICYgUENJRV9M SU5LX1NUQVRFX0wxXzEpCj4gKwkJcmVzdWx0IHw9IEFTUE1fU1RBVEVfTDFfMTsKPiArCWlmIChz dGF0ZSAmIFBDSUVfTElOS19TVEFURV9MMV8yKQo+ICsJCXJlc3VsdCB8PSBBU1BNX1NUQVRFX0wx XzI7Cj4gKwlpZiAoc3RhdGUgJiBQQ0lFX0xJTktfU1RBVEVfTDFfMV9QQ0lQTSkKPiArCQlyZXN1 bHQgfD0gQVNQTV9TVEFURV9MMV8xX1BDSVBNOwo+ICsJaWYgKHN0YXRlICYgUENJRV9MSU5LX1NU QVRFX0wxXzJfUENJUE0pCj4gKwkJcmVzdWx0IHw9IEFTUE1fU1RBVEVfTDFfMl9QQ0lQTTsKPiAr Cj4gKwlyZXR1cm4gcmVzdWx0Owo+ICt9Cj4gKwo+ICBzdGF0aWMgaW50IF9fcGNpX2Rpc2FibGVf bGlua19zdGF0ZShzdHJ1Y3QgcGNpX2RldiAqcGRldiwgaW50IHN0YXRlLCBib29sIHNlbSkKPiAg ewo+ICAJc3RydWN0IHBjaWVfbGlua19zdGF0ZSAqbGluayA9IHBjaWVfYXNwbV9nZXRfbGluayhw ZGV2KTsKPiBAQCAtMTA2MywxOCArMTA4Myw3IEBAIHN0YXRpYyBpbnQgX19wY2lfZGlzYWJsZV9s aW5rX3N0YXRlKHN0cnVjdCBwY2lfZGV2ICpwZGV2LCBpbnQgc3RhdGUsIGJvb2wgc2VtKQo+ICAJ aWYgKHNlbSkKPiAgCQlkb3duX3JlYWQoJnBjaV9idXNfc2VtKTsKPiAgCW11dGV4X2xvY2soJmFz cG1fbG9jayk7Cj4gLQlpZiAoc3RhdGUgJiBQQ0lFX0xJTktfU1RBVEVfTDBTKQo+IC0JCWxpbmst PmFzcG1fZGlzYWJsZSB8PSBBU1BNX1NUQVRFX0wwUzsKPiAtCWlmIChzdGF0ZSAmIFBDSUVfTElO S19TVEFURV9MMSkKPiAtCQlsaW5rLT5hc3BtX2Rpc2FibGUgfD0gQVNQTV9TVEFURV9MMTsKPiAt CWlmIChzdGF0ZSAmIFBDSUVfTElOS19TVEFURV9MMV8xKQo+IC0JCWxpbmstPmFzcG1fZGlzYWJs ZSB8PSBBU1BNX1NUQVRFX0wxXzE7Cj4gLQlpZiAoc3RhdGUgJiBQQ0lFX0xJTktfU1RBVEVfTDFf MikKPiAtCQlsaW5rLT5hc3BtX2Rpc2FibGUgfD0gQVNQTV9TVEFURV9MMV8yOwo+IC0JaWYgKHN0 YXRlICYgUENJRV9MSU5LX1NUQVRFX0wxXzFfUENJUE0pCj4gLQkJbGluay0+YXNwbV9kaXNhYmxl IHw9IEFTUE1fU1RBVEVfTDFfMV9QQ0lQTTsKPiAtCWlmIChzdGF0ZSAmIFBDSUVfTElOS19TVEFU RV9MMV8yX1BDSVBNKQo+IC0JCWxpbmstPmFzcG1fZGlzYWJsZSB8PSBBU1BNX1NUQVRFX0wxXzJf UENJUE07Cj4gKwlsaW5rLT5hc3BtX2Rpc2FibGUgfD0gcGNpX2xpbmtfc3RhdGVfbWFzayhzdGF0 ZSk7Cj4gIAlwY2llX2NvbmZpZ19hc3BtX2xpbmsobGluaywgcG9saWN5X3RvX2FzcG1fc3RhdGUo bGluaykpOwo+ICAKPiAgCWlmIChzdGF0ZSAmIFBDSUVfTElOS19TVEFURV9DTEtQTSkKPiAtLSAK PiAyLjMwLjIKPiAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwo+IGxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cj4gbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCj4gaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLXdpcmVkLWxhbiBtYWlsaW5nIGxpc3QKSW50ZWwtd2ly ZWQtbGFuQG9zdW9zbC5vcmcKaHR0cHM6Ly9saXN0cy5vc3Vvc2wub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtd2lyZWQtbGFuCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B106CDB47E for ; Wed, 11 Oct 2023 19:32:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233330AbjJKTcL (ORCPT ); Wed, 11 Oct 2023 15:32:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233109AbjJKTcK (ORCPT ); Wed, 11 Oct 2023 15:32:10 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4251C8F; Wed, 11 Oct 2023 12:32:09 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9236BC433C7; Wed, 11 Oct 2023 19:32:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697052728; bh=4k1m5qmcSDaP+SZOYD02LNDbpXJtj+6QzJq4iZ0fBT4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=PkSkfYndzZuEdhim2WqdUnaFkJa6/ULgDeXVhLamNMtNqjpEjDLFAOpinVDtpOf9t AUQ8IuXuDRsbGSvvuJcBOkesPKE+B6LOW3w499tPS1H5C+DTTGZEpqDhTJv73Rngtf R8n/q+wpIprV9354P5kNeMO1/5OdiCJZC921zzltoOp4qhTV4cqy8e0kXbMRCaqp4/ wgSGTdLCtZ0E1cvfJh/3oqFSKgGnYoWCp1qvbc5VbvIvmnclEI+2/Ls3QSTesrpdOn 1i9kPgcJmtJ/9DGNbL1W+mb7/ZJBeiArthYq4x+V47gI24Zx4H0qwEfuzJhfUtgURt hjOYzB4aN6mlQ== Date: Wed, 11 Oct 2023 14:32:06 -0500 From: Bjorn Helgaas To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= Cc: linux-pci@vger.kernel.org, Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Lukas Wunner , "Rafael J . Wysocki" , Heiner Kallweit , Emmanuel Grumbach , linux-kernel@vger.kernel.org, Bjorn Helgaas , ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, intel-wired-lan@lists.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-bluetooth@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 04/13] PCI/ASPM: Move L0S/L1/sub states mask calculation into a helper Message-ID: <20231011193206.GA1039708@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230918131103.24119-5-ilpo.jarvinen@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On Mon, Sep 18, 2023 at 04:10:54PM +0300, Ilpo Järvinen wrote: > ASPM service driver does the same L0S / L1S / sub states allowed > calculation in __pci_disable_link_state() and > pci_set_default_link_state(). Is there a typo or something here? This patch only adds a call to __pci_disable_link_state(), not to pci_set_default_link_state(). > Create a helper to calculate the mask for the allowed states. > > Signed-off-by: Ilpo Järvinen > --- > drivers/pci/pcie/aspm.c | 33 +++++++++++++++++++++------------ > 1 file changed, 21 insertions(+), 12 deletions(-) > > diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c > index ec6d7a092ac1..91dc95aca90f 100644 > --- a/drivers/pci/pcie/aspm.c > +++ b/drivers/pci/pcie/aspm.c > @@ -1034,6 +1034,26 @@ static struct pcie_link_state *pcie_aspm_get_link(struct pci_dev *pdev) > return bridge->link_state; > } > > +static u8 pci_link_state_mask(int state) > +{ > + u8 result = 0; > + > + if (state & PCIE_LINK_STATE_L0S) > + result |= ASPM_STATE_L0S; > + if (state & PCIE_LINK_STATE_L1) > + result |= ASPM_STATE_L1; > + if (state & PCIE_LINK_STATE_L1_1) > + result |= ASPM_STATE_L1_1; > + if (state & PCIE_LINK_STATE_L1_2) > + result |= ASPM_STATE_L1_2; > + if (state & PCIE_LINK_STATE_L1_1_PCIPM) > + result |= ASPM_STATE_L1_1_PCIPM; > + if (state & PCIE_LINK_STATE_L1_2_PCIPM) > + result |= ASPM_STATE_L1_2_PCIPM; > + > + return result; > +} > + > static int __pci_disable_link_state(struct pci_dev *pdev, int state, bool sem) > { > struct pcie_link_state *link = pcie_aspm_get_link(pdev); > @@ -1063,18 +1083,7 @@ static int __pci_disable_link_state(struct pci_dev *pdev, int state, bool sem) > if (sem) > down_read(&pci_bus_sem); > mutex_lock(&aspm_lock); > - if (state & PCIE_LINK_STATE_L0S) > - link->aspm_disable |= ASPM_STATE_L0S; > - if (state & PCIE_LINK_STATE_L1) > - link->aspm_disable |= ASPM_STATE_L1; > - if (state & PCIE_LINK_STATE_L1_1) > - link->aspm_disable |= ASPM_STATE_L1_1; > - if (state & PCIE_LINK_STATE_L1_2) > - link->aspm_disable |= ASPM_STATE_L1_2; > - if (state & PCIE_LINK_STATE_L1_1_PCIPM) > - link->aspm_disable |= ASPM_STATE_L1_1_PCIPM; > - if (state & PCIE_LINK_STATE_L1_2_PCIPM) > - link->aspm_disable |= ASPM_STATE_L1_2_PCIPM; > + link->aspm_disable |= pci_link_state_mask(state); > pcie_config_aspm_link(link, policy_to_aspm_state(link)); > > if (state & PCIE_LINK_STATE_CLKPM) > -- > 2.30.2 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7C7DCDB47E for ; Wed, 11 Oct 2023 19:32:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=VzRtiZ0jWsjsW/Ony7U4JdJ51kJd6l8lUwwyE4cCbYc=; b=xTEly3OQ3ykF+9 CpiwIRCP+bBIK/GF7qhut+YhkEVnrWCwFzockpyHV77M0v9r8iGf1WR03AS7S0mSxhfSV9lJ63hGj ltZC0k0bCIn3dbj1s9UJkrd/jeEC8QZwLhZd3Z5ic/6yIudOHa7sCklAXNmKm/k34jUD2t1YMNhrq OtY5pshQFDDhTELc+/+/eEWib/EG3bpU2avxRBPoIpjvY08KC0AL4q4khx19zoK9BTZEVwv5XRk7E HY/Hn5DmFNjfjNIPvO6RbVp0LYhENgHOeFWKPnCb+0QQeNdGPOIAQ7KO7ehzfPPMGYErqqxmr6FTG RbKqY/GFqUj9IfvjkBzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqewL-00GYLZ-1D; Wed, 11 Oct 2023 19:32:17 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qqewG-00GYIr-1G; Wed, 11 Oct 2023 19:32:14 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id CAD73CE2527; Wed, 11 Oct 2023 19:32:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9236BC433C7; Wed, 11 Oct 2023 19:32:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697052728; bh=4k1m5qmcSDaP+SZOYD02LNDbpXJtj+6QzJq4iZ0fBT4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=PkSkfYndzZuEdhim2WqdUnaFkJa6/ULgDeXVhLamNMtNqjpEjDLFAOpinVDtpOf9t AUQ8IuXuDRsbGSvvuJcBOkesPKE+B6LOW3w499tPS1H5C+DTTGZEpqDhTJv73Rngtf R8n/q+wpIprV9354P5kNeMO1/5OdiCJZC921zzltoOp4qhTV4cqy8e0kXbMRCaqp4/ wgSGTdLCtZ0E1cvfJh/3oqFSKgGnYoWCp1qvbc5VbvIvmnclEI+2/Ls3QSTesrpdOn 1i9kPgcJmtJ/9DGNbL1W+mb7/ZJBeiArthYq4x+V47gI24Zx4H0qwEfuzJhfUtgURt hjOYzB4aN6mlQ== Date: Wed, 11 Oct 2023 14:32:06 -0500 From: Bjorn Helgaas To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= Cc: linux-pci@vger.kernel.org, Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Lukas Wunner , "Rafael J . Wysocki" , Heiner Kallweit , Emmanuel Grumbach , linux-kernel@vger.kernel.org, Bjorn Helgaas , ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, intel-wired-lan@lists.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-bluetooth@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 04/13] PCI/ASPM: Move L0S/L1/sub states mask calculation into a helper Message-ID: <20231011193206.GA1039708@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230918131103.24119-5-ilpo.jarvinen@linux.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231011_123212_805787_CD3BB6C4 X-CRM114-Status: GOOD ( 19.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBTZXAgMTgsIDIwMjMgYXQgMDQ6MTA6NTRQTSArMDMwMCwgSWxwbyBKw6RydmluZW4g d3JvdGU6Cj4gQVNQTSBzZXJ2aWNlIGRyaXZlciBkb2VzIHRoZSBzYW1lIEwwUyAvIEwxUyAvIHN1 YiBzdGF0ZXMgYWxsb3dlZAo+IGNhbGN1bGF0aW9uIGluIF9fcGNpX2Rpc2FibGVfbGlua19zdGF0 ZSgpIGFuZAo+IHBjaV9zZXRfZGVmYXVsdF9saW5rX3N0YXRlKCkuCgpJcyB0aGVyZSBhIHR5cG8g b3Igc29tZXRoaW5nIGhlcmU/ICBUaGlzIHBhdGNoIG9ubHkgYWRkcyBhIGNhbGwgdG8KX19wY2lf ZGlzYWJsZV9saW5rX3N0YXRlKCksIG5vdCB0byBwY2lfc2V0X2RlZmF1bHRfbGlua19zdGF0ZSgp LgoKPiBDcmVhdGUgYSBoZWxwZXIgdG8gY2FsY3VsYXRlIHRoZSBtYXNrIGZvciB0aGUgYWxsb3dl ZCBzdGF0ZXMuCj4gCj4gU2lnbmVkLW9mZi1ieTogSWxwbyBKw6RydmluZW4gPGlscG8uamFydmlu ZW5AbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL3BjaS9wY2llL2FzcG0uYyB8IDMz ICsrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjEg aW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv cGNpL3BjaWUvYXNwbS5jIGIvZHJpdmVycy9wY2kvcGNpZS9hc3BtLmMKPiBpbmRleCBlYzZkN2Ew OTJhYzEuLjkxZGM5NWFjYTkwZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3BjaS9wY2llL2FzcG0u Ywo+ICsrKyBiL2RyaXZlcnMvcGNpL3BjaWUvYXNwbS5jCj4gQEAgLTEwMzQsNiArMTAzNCwyNiBA QCBzdGF0aWMgc3RydWN0IHBjaWVfbGlua19zdGF0ZSAqcGNpZV9hc3BtX2dldF9saW5rKHN0cnVj dCBwY2lfZGV2ICpwZGV2KQo+ICAJcmV0dXJuIGJyaWRnZS0+bGlua19zdGF0ZTsKPiAgfQo+ICAK PiArc3RhdGljIHU4IHBjaV9saW5rX3N0YXRlX21hc2soaW50IHN0YXRlKQo+ICt7Cj4gKwl1OCBy ZXN1bHQgPSAwOwo+ICsKPiArCWlmIChzdGF0ZSAmIFBDSUVfTElOS19TVEFURV9MMFMpCj4gKwkJ cmVzdWx0IHw9IEFTUE1fU1RBVEVfTDBTOwo+ICsJaWYgKHN0YXRlICYgUENJRV9MSU5LX1NUQVRF X0wxKQo+ICsJCXJlc3VsdCB8PSBBU1BNX1NUQVRFX0wxOwo+ICsJaWYgKHN0YXRlICYgUENJRV9M SU5LX1NUQVRFX0wxXzEpCj4gKwkJcmVzdWx0IHw9IEFTUE1fU1RBVEVfTDFfMTsKPiArCWlmIChz dGF0ZSAmIFBDSUVfTElOS19TVEFURV9MMV8yKQo+ICsJCXJlc3VsdCB8PSBBU1BNX1NUQVRFX0wx XzI7Cj4gKwlpZiAoc3RhdGUgJiBQQ0lFX0xJTktfU1RBVEVfTDFfMV9QQ0lQTSkKPiArCQlyZXN1 bHQgfD0gQVNQTV9TVEFURV9MMV8xX1BDSVBNOwo+ICsJaWYgKHN0YXRlICYgUENJRV9MSU5LX1NU QVRFX0wxXzJfUENJUE0pCj4gKwkJcmVzdWx0IHw9IEFTUE1fU1RBVEVfTDFfMl9QQ0lQTTsKPiAr Cj4gKwlyZXR1cm4gcmVzdWx0Owo+ICt9Cj4gKwo+ICBzdGF0aWMgaW50IF9fcGNpX2Rpc2FibGVf bGlua19zdGF0ZShzdHJ1Y3QgcGNpX2RldiAqcGRldiwgaW50IHN0YXRlLCBib29sIHNlbSkKPiAg ewo+ICAJc3RydWN0IHBjaWVfbGlua19zdGF0ZSAqbGluayA9IHBjaWVfYXNwbV9nZXRfbGluayhw ZGV2KTsKPiBAQCAtMTA2MywxOCArMTA4Myw3IEBAIHN0YXRpYyBpbnQgX19wY2lfZGlzYWJsZV9s aW5rX3N0YXRlKHN0cnVjdCBwY2lfZGV2ICpwZGV2LCBpbnQgc3RhdGUsIGJvb2wgc2VtKQo+ICAJ aWYgKHNlbSkKPiAgCQlkb3duX3JlYWQoJnBjaV9idXNfc2VtKTsKPiAgCW11dGV4X2xvY2soJmFz cG1fbG9jayk7Cj4gLQlpZiAoc3RhdGUgJiBQQ0lFX0xJTktfU1RBVEVfTDBTKQo+IC0JCWxpbmst PmFzcG1fZGlzYWJsZSB8PSBBU1BNX1NUQVRFX0wwUzsKPiAtCWlmIChzdGF0ZSAmIFBDSUVfTElO S19TVEFURV9MMSkKPiAtCQlsaW5rLT5hc3BtX2Rpc2FibGUgfD0gQVNQTV9TVEFURV9MMTsKPiAt CWlmIChzdGF0ZSAmIFBDSUVfTElOS19TVEFURV9MMV8xKQo+IC0JCWxpbmstPmFzcG1fZGlzYWJs ZSB8PSBBU1BNX1NUQVRFX0wxXzE7Cj4gLQlpZiAoc3RhdGUgJiBQQ0lFX0xJTktfU1RBVEVfTDFf MikKPiAtCQlsaW5rLT5hc3BtX2Rpc2FibGUgfD0gQVNQTV9TVEFURV9MMV8yOwo+IC0JaWYgKHN0 YXRlICYgUENJRV9MSU5LX1NUQVRFX0wxXzFfUENJUE0pCj4gLQkJbGluay0+YXNwbV9kaXNhYmxl IHw9IEFTUE1fU1RBVEVfTDFfMV9QQ0lQTTsKPiAtCWlmIChzdGF0ZSAmIFBDSUVfTElOS19TVEFU RV9MMV8yX1BDSVBNKQo+IC0JCWxpbmstPmFzcG1fZGlzYWJsZSB8PSBBU1BNX1NUQVRFX0wxXzJf UENJUE07Cj4gKwlsaW5rLT5hc3BtX2Rpc2FibGUgfD0gcGNpX2xpbmtfc3RhdGVfbWFzayhzdGF0 ZSk7Cj4gIAlwY2llX2NvbmZpZ19hc3BtX2xpbmsobGluaywgcG9saWN5X3RvX2FzcG1fc3RhdGUo bGluaykpOwo+ICAKPiAgCWlmIChzdGF0ZSAmIFBDSUVfTElOS19TVEFURV9DTEtQTSkKPiAtLSAK PiAyLjMwLjIKPiAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwo+IGxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cj4gbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCj4gaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1h cm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==