From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FE82CDB486 for ; Wed, 11 Oct 2023 21:53:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=dhqgQ8xQO02C5B9khGCwhDbvq8kVskgTa3TNTo475AI=; b=1/vPkX+oRmQLuk iJq58nHmEJ+JxcsueObYAyUFLihwOMHIUeBIHwUEb2V3fctmTtbk/uiU6ICu5mAogwjs5x+2d70QF Ci2Slyx+qM3funf97JxXDKTlHvtuJbSxQ1d0gy7NNFBu5Sk7WRcncsSxMXjFoYaPAkoo7jhzm+a7d P5p16SD/cdsQ+1g8o0PvPAjRCnvlOTCupgEZkhNUmfkd9TEV6vHZDSuSOTyXuHEI4qkWmKslDbCZ4 lueXTb12j3qQLpJjsFbVLWqPPiwrgn6NV5yvW+xeZDOO0v/fKufA5ZmZ8oAmTgPS1On4V/Nb75SbH f4wHILsZpiOOdym5o6bQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqh94-00GmOT-3C; Wed, 11 Oct 2023 21:53:34 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qqh92-00GmMv-09; Wed, 11 Oct 2023 21:53:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 8399AB8201E; Wed, 11 Oct 2023 21:53:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87540C433C9; Wed, 11 Oct 2023 21:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697061209; bh=qY9Rp5zkRIt2DsQivgERNNESbVTGEul4kS5s7/dIoho=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=EAwNFrclnTWEuXdB+Z8mt3u3kuEAAoUwY82PbS8J18XDNC6E3OiHHHxAFbbd17IOO T6KemaFOH4w9WVID23kFc5vCnMeXYebhs7yahyg9gnbxexaaSqR+KOEgoCrxijFWyG dnCiAysL1ttbyJnzXZGaT8aqz/DwQbEhhDfWR38iscslUEL9bLiDHhVjMYSwKPoaYH vE7EY6dncxhXQ4FluROOjHz7swY5mrWHaRm0x+YRj0w+mEnls2n/6+o4Mg69zLynhg wf5HljSZ4OwbmmK2VZKj4KXyrtee/VgZ11v8Vna96PUYyaJ2T6vmKgYUE3ho/7KBKo bDWaoqyCH5pFQ== Date: Wed, 11 Oct 2023 16:53:27 -0500 From: Bjorn Helgaas To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= Cc: linux-pci@vger.kernel.org, Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Lukas Wunner , "Rafael J . Wysocki" , Heiner Kallweit , Emmanuel Grumbach , linux-kernel@vger.kernel.org, Bjorn Helgaas , ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, intel-wired-lan@lists.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-bluetooth@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 05/13] PCI/ASPM: Add pci_enable_link_state() Message-ID: <20231011215327.GA1043654@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230918131103.24119-6-ilpo.jarvinen@linux.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231011_145332_354395_3D1F5816 X-CRM114-Status: GOOD ( 30.80 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+ath10k=archiver.kernel.org@lists.infradead.org T24gTW9uLCBTZXAgMTgsIDIwMjMgYXQgMDQ6MTA6NTVQTSArMDMwMCwgSWxwbyBKw6RydmluZW4g d3JvdGU6Cj4gcGNpX2Rpc2FibGVfbGlua19zdGF0ZSgpIGxhY2tzIGEgc3ltbWV0cmljIHBhaXIu IFNvbWUgZHJpdmVycyB3YW50IHRvCj4gZGlzYWJsZSBBU1BNIGR1cmluZyBjZXJ0YWluIHBoYXNl cyBvZiB0aGVpciBvcGVyYXRpb24gYnV0IHRoZW4KPiByZS1lbmFibGUgaXQgbGF0ZXIgb24uIElm IHBjaV9kaXNhYmxlX2xpbmtfc3RhdGUoKSBpcyBtYWRlIGZvciB0aGUKPiBkZXZpY2UsIHRoZXJl IGlzIGN1cnJlbnRseSBubyB3YXkgdG8gcmUtZW5hYmxlIHRoZSBzdGF0ZXMgdGhhdCB3ZXJlCj4g ZGlzYWJsZWQuCgpwY2lfZGlzYWJsZV9saW5rX3N0YXRlKCkgZ2l2ZXMgZHJpdmVycyBhIHdheSB0 byBkaXNhYmxlIHNwZWNpZmllZCBBU1BNCnN0YXRlcyB1c2luZyBhIGJpdG1hc2sgKFBDSUVfTElO S19TVEFURV9MMFMsIFBDSUVfTElOS19TVEFURV9MMSwKUENJRV9MSU5LX1NUQVRFX0wxXzEsIGV0 YyksIGJ1dCBJSVVDIHRoZSBkcml2ZXIgY2FuJ3QgdGVsbCBleGFjdGx5CndoYXQgY2hhbmdlZCBh bmQgY2FuJ3QgZGlyZWN0bHkgcmVzdG9yZSB0aGUgb3JpZ2luYWwgc3RhdGUsIGUuZy4sCgogIC0g UENJRV9MSU5LX1NUQVRFX0wxIGVuYWJsZWQgaW5pdGlhbGx5CiAgLSBkcml2ZXIgY2FsbHMgcGNp X2Rpc2FibGVfbGlua19zdGF0ZShQQ0lFX0xJTktfU1RBVEVfTDBTKQogIC0gZHJpdmVyIGNhbGxz IHBjaV9lbmFibGVfbGlua19zdGF0ZShQQ0lFX0xJTktfU1RBVEVfTDBTKQogIC0gUENJRV9MSU5L X1NUQVRFX0wwUyBhbmQgUENJRV9MSU5LX1NUQVRFX0wxIGFyZSBlbmFibGVkIG5vdwoKTm93IFBD SUVfTElOS19TVEFURV9MMFMgaXMgZW5hYmxlZCBldmVuIHRob3VnaCBpdCB3YXMgbm90IGluaXRp YWxseQplbmFibGVkLiAgTWF5YmUgdGhhdCdzIHdoYXQgd2Ugd2FudDsgSSBkdW5uby4KCnBjaV9k aXNhYmxlX2xpbmtfc3RhdGUoKSBjdXJyZW50bHkgcmV0dXJucyBzdWNjZXNzL2ZhaWx1cmUsIGJ1 dCBvbmx5CnI4MTY5IGFuZCBtdDc2IGV2ZW4gY2hlY2ssIGFuZCBvbmx5IHJ0bF9pbml0X29uZSgp IChyODE2OSkgaGFzIGEKbm9uLXRyaXZpYWwgcmVhc29uLCBzbyBpdCdzIGNvbmNlaXZhYmxlIHRo YXQgaXQgY291bGQgcmV0dXJuIGEgYml0bWFzawppbnN0ZWFkLgoKPiBBZGQgcGNpX2VuYWJsZV9s aW5rX3N0YXRlKCkgdG8gcmVtb3ZlIEFTUE0gc3RhdGVzIGZyb20gdGhlIHN0YXRlCj4gZGlzYWJs ZSBtYXNrLgo+IAo+IFNpZ25lZC1vZmYtYnk6IElscG8gSsOkcnZpbmVuIDxpbHBvLmphcnZpbmVu QGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9wY2kvcGNpZS9hc3BtLmMgfCA0MiAr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICBpbmNsdWRlL2xpbnV4 L3BjaS5oICAgICB8ICAyICsrCj4gIDIgZmlsZXMgY2hhbmdlZCwgNDQgaW5zZXJ0aW9ucygrKQo+ IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9wY2llL2FzcG0uYyBiL2RyaXZlcnMvcGNpL3Bj aWUvYXNwbS5jCj4gaW5kZXggOTFkYzk1YWNhOTBmLi5mNDVkMThkNDdjMjAgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9wY2kvcGNpZS9hc3BtLmMKPiArKysgYi9kcml2ZXJzL3BjaS9wY2llL2FzcG0u Ywo+IEBAIC0xMTE3LDYgKzExMTcsNDggQEAgaW50IHBjaV9kaXNhYmxlX2xpbmtfc3RhdGUoc3Ry dWN0IHBjaV9kZXYgKnBkZXYsIGludCBzdGF0ZSkKPiAgfQo+ICBFWFBPUlRfU1lNQk9MKHBjaV9k aXNhYmxlX2xpbmtfc3RhdGUpOwo+ICAKPiArLyoqCj4gKyAqIHBjaV9lbmFibGVfbGlua19zdGF0 ZSAtIFJlLWVuYWJsZSBkZXZpY2UncyBsaW5rIHN0YXRlCj4gKyAqIEBwZGV2OiBQQ0kgZGV2aWNl Cj4gKyAqIEBzdGF0ZTogQVNQTSBsaW5rIHN0YXRlcyB0byByZS1lbmFibGUKPiArICoKPiArICog RW5hYmxlIGRldmljZSdzIGxpbmsgc3RhdGUgdGhhdCB3ZXJlIHByZXZpb3VzbHkgZGlzYWJsZSBz byB0aGUgbGluayBpcwoKInN0YXRlW3NdIHRoYXQgd2VyZSBwcmV2aW91c2x5IGRpc2FibGVbZF0i IGFsbHVkZXMgdG8gdGhlIHVzZSBjYXNlIHlvdQpoYXZlIGluIG1pbmQsIGJ1dCBJIGRvbid0IHRo aW5rIGl0IGRlc2NyaWJlcyBob3cgdGhpcyBmdW5jdGlvbgphY3R1YWxseSB3b3Jrcy4gIFRoaXMg ZnVuY3Rpb24ganVzdCBtYWtlcyBpdCBwb3NzaWJsZSB0byBlbmFibGUgdGhlCnNwZWNpZmllZCBz dGF0ZXMuICBUaGUgQHN0YXRlIHBhcmFtZXRlciBtYXkgaGF2ZSBub3RoaW5nIHRvIGRvIHdpdGgK YW55IHByZXZpb3VzbHkgZGlzYWJsZWQgc3RhdGVzLgoKPiArICogYWxsb3dlZCB0byBlbnRlciB0 aGUgc3BlY2lmaWMgc3RhdGVzLiBOb3RlIHRoYXQgaWYgdGhlIEJJT1MgZGlkbid0IGdyYW50Cj4g KyAqIEFTUE0gY29udHJvbCB0byB0aGUgT1MsIHRoaXMgZG9lcyBub3RoaW5nIGJlY2F1c2Ugd2Ug Y2FuJ3QgdG91Y2ggdGhlCj4gKyAqIExOS0NUTCByZWdpc3Rlci4KPiArICoKPiArICogUmV0dXJu OiAwIG9yIGEgbmVnYXRpdmUgZXJybm8uCj4gKyAqLwo+ICtpbnQgcGNpX2VuYWJsZV9saW5rX3N0 YXRlKHN0cnVjdCBwY2lfZGV2ICpwZGV2LCBpbnQgc3RhdGUpCj4gK3sKPiArCXN0cnVjdCBwY2ll X2xpbmtfc3RhdGUgKmxpbmsgPSBwY2llX2FzcG1fZ2V0X2xpbmsocGRldik7Cj4gKwo+ICsJaWYg KCFsaW5rKQo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsJLyoKPiArCSAqIEEgZHJpdmVyIHJlcXVl c3RlZCB0aGF0IEFTUE0gYmUgZW5hYmxlZCBvbiB0aGlzIGRldmljZSwgYnV0Cj4gKwkgKiBpZiB3 ZSBkb24ndCBoYXZlIHBlcm1pc3Npb24gdG8gbWFuYWdlIEFTUE0gKGUuZy4sIG9uIEFDUEkKPiAr CSAqIHN5c3RlbXMgd2UgaGF2ZSB0byBvYnNlcnZlIHRoZSBGQURUIEFDUElfRkFEVF9OT19BU1BN IGJpdCBhbmQKPiArCSAqIHRoZSBfT1NDIG1ldGhvZCksIHdlIGNhbid0IGhvbm9yIHRoYXQgcmVx dWVzdC4KPiArCSAqLwo+ICsJaWYgKGFzcG1fZGlzYWJsZWQpIHsKPiArCQlwY2lfd2FybihwZGV2 LCAiY2FuJ3QgZW5hYmxlIEFTUE07IE9TIGRvZXNuJ3QgaGF2ZSBBU1BNIGNvbnRyb2xcbiIpOwo+ ICsJCXJldHVybiAtRVBFUk07Cj4gKwl9Cj4gKwo+ICsJbXV0ZXhfbG9jaygmYXNwbV9sb2NrKTsK PiArCWxpbmstPmFzcG1fZGlzYWJsZSAmPSB+cGNpX2xpbmtfc3RhdGVfbWFzayhzdGF0ZSk7Cj4g KwlwY2llX2NvbmZpZ19hc3BtX2xpbmsobGluaywgcG9saWN5X3RvX2FzcG1fc3RhdGUobGluaykp Owo+ICsKPiArCWlmIChzdGF0ZSAmIFBDSUVfTElOS19TVEFURV9DTEtQTSkKPiArCQlsaW5rLT5j bGtwbV9kaXNhYmxlID0gMDsKPiArCXBjaWVfc2V0X2Nsa3BtKGxpbmssIHBvbGljeV90b19jbGtw bV9zdGF0ZShsaW5rKSk7Cj4gKwltdXRleF91bmxvY2soJmFzcG1fbG9jayk7Cj4gKwo+ICsJcmV0 dXJuIDA7Cj4gK30KPiArRVhQT1JUX1NZTUJPTChwY2lfZW5hYmxlX2xpbmtfc3RhdGUpOwo+ICsK PiAgLyoqCj4gICAqIHBjaV9zZXRfZGVmYXVsdF9saW5rX3N0YXRlIC0gU2V0IHRoZSBkZWZhdWx0 IGRldmljZSBsaW5rIHN0YXRlCj4gICAqIEBwZGV2OiBQQ0kgZGV2aWNlCj4gZGlmZiAtLWdpdCBh L2luY2x1ZGUvbGludXgvcGNpLmggYi9pbmNsdWRlL2xpbnV4L3BjaS5oCj4gaW5kZXggM2MyNGNh MTY0MTA0Li44NDRkMDkyMzAyNjQgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9saW51eC9wY2kuaAo+ ICsrKyBiL2luY2x1ZGUvbGludXgvcGNpLmgKPiBAQCAtMTc3NiwxMSArMTc3NiwxMyBAQCBleHRl cm4gYm9vbCBwY2llX3BvcnRzX25hdGl2ZTsKPiAgaW50IHBjaV9kaXNhYmxlX2xpbmtfc3RhdGUo c3RydWN0IHBjaV9kZXYgKnBkZXYsIGludCBzdGF0ZSk7Cj4gIGludCBwY2lfZGlzYWJsZV9saW5r X3N0YXRlX2xvY2tlZChzdHJ1Y3QgcGNpX2RldiAqcGRldiwgaW50IHN0YXRlKTsKPiAgI2lmZGVm IENPTkZJR19QQ0lFQVNQTQo+ICtpbnQgcGNpX2VuYWJsZV9saW5rX3N0YXRlKHN0cnVjdCBwY2lf ZGV2ICpwZGV2LCBpbnQgc3RhdGUpOwo+ICBpbnQgcGNpX3NldF9kZWZhdWx0X2xpbmtfc3RhdGUo c3RydWN0IHBjaV9kZXYgKnBkZXYsIGludCBzdGF0ZSk7Cj4gIHZvaWQgcGNpZV9ub19hc3BtKHZv aWQpOwo+ICBib29sIHBjaWVfYXNwbV9zdXBwb3J0X2VuYWJsZWQodm9pZCk7Cj4gIGJvb2wgcGNp ZV9hc3BtX2VuYWJsZWQoc3RydWN0IHBjaV9kZXYgKnBkZXYpOwo+ICAjZWxzZQo+ICtzdGF0aWMg aW5saW5lIGludCBwY2lfZW5hYmxlX2xpbmtfc3RhdGUoc3RydWN0IHBjaV9kZXYgKnBkZXYsIGlu dCBzdGF0ZSkgeyByZXR1cm4gLUVPUE5PVFNVUFA7IH0KPiAgc3RhdGljIGlubGluZSBpbnQgcGNp X3NldF9kZWZhdWx0X2xpbmtfc3RhdGUoc3RydWN0IHBjaV9kZXYgKnBkZXYsIGludCBzdGF0ZSkK PiAgeyByZXR1cm4gMDsgfQo+ICBzdGF0aWMgaW5saW5lIHZvaWQgcGNpZV9ub19hc3BtKHZvaWQp IHsgfQo+IC0tIAo+IDIuMzAuMgo+IAo+IAo+IC0tIAo+IGF0aDEyayBtYWlsaW5nIGxpc3QKPiBh dGgxMmtAbGlzdHMuaW5mcmFkZWFkLm9yZwo+IGh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2F0aDEyawoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KYXRoMTBrIG1haWxpbmcgbGlzdAphdGgxMGtAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2F0aDEwawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2403CDB488 for ; Wed, 11 Oct 2023 21:53:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=2wDihO+IJZRDn8cEeCV3gT8wHVDW2paApuQHPIQKEH4=; b=vglT0vQbo6tFpI p6rFZo7ug/Kf2idhxHIB8Erhv3YdvzvwzBM+/ZYsvjLx3C06ko8+jmB4VTls74PhOVkjgU5Tp9i0h E6ozU3MX0wWbJ8PYn6TlBWf3W7MocVgK7vfx1PF7T7FfnMTgblUcEsio1faY3FwrRoIDqCOzjsz0z Vp0JavmmFztDSWy4knS+q7BcQXgP0wsSUJ2PjGZX9Vpa4TecHbtu8rg0U+YN0TeXI3lUgO95K/mjf wWdsLDv853Ckczyxot44rITcAUwoYRL7Fbi2Pl22o4ZfGweNqFaTc/sjRZQpEDie67aJYm9z3B/vg C7986GZC5Pp6CExX+INw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqh95-00GmP4-2A; Wed, 11 Oct 2023 21:53:35 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qqh92-00GmMv-09; Wed, 11 Oct 2023 21:53:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 8399AB8201E; Wed, 11 Oct 2023 21:53:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87540C433C9; Wed, 11 Oct 2023 21:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697061209; bh=qY9Rp5zkRIt2DsQivgERNNESbVTGEul4kS5s7/dIoho=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=EAwNFrclnTWEuXdB+Z8mt3u3kuEAAoUwY82PbS8J18XDNC6E3OiHHHxAFbbd17IOO T6KemaFOH4w9WVID23kFc5vCnMeXYebhs7yahyg9gnbxexaaSqR+KOEgoCrxijFWyG dnCiAysL1ttbyJnzXZGaT8aqz/DwQbEhhDfWR38iscslUEL9bLiDHhVjMYSwKPoaYH vE7EY6dncxhXQ4FluROOjHz7swY5mrWHaRm0x+YRj0w+mEnls2n/6+o4Mg69zLynhg wf5HljSZ4OwbmmK2VZKj4KXyrtee/VgZ11v8Vna96PUYyaJ2T6vmKgYUE3ho/7KBKo bDWaoqyCH5pFQ== Date: Wed, 11 Oct 2023 16:53:27 -0500 From: Bjorn Helgaas To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= Cc: linux-pci@vger.kernel.org, Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Lukas Wunner , "Rafael J . Wysocki" , Heiner Kallweit , Emmanuel Grumbach , linux-kernel@vger.kernel.org, Bjorn Helgaas , ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, intel-wired-lan@lists.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-bluetooth@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 05/13] PCI/ASPM: Add pci_enable_link_state() Message-ID: <20231011215327.GA1043654@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230918131103.24119-6-ilpo.jarvinen@linux.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231011_145332_354395_3D1F5816 X-CRM114-Status: GOOD ( 30.80 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org T24gTW9uLCBTZXAgMTgsIDIwMjMgYXQgMDQ6MTA6NTVQTSArMDMwMCwgSWxwbyBKw6RydmluZW4g d3JvdGU6Cj4gcGNpX2Rpc2FibGVfbGlua19zdGF0ZSgpIGxhY2tzIGEgc3ltbWV0cmljIHBhaXIu IFNvbWUgZHJpdmVycyB3YW50IHRvCj4gZGlzYWJsZSBBU1BNIGR1cmluZyBjZXJ0YWluIHBoYXNl cyBvZiB0aGVpciBvcGVyYXRpb24gYnV0IHRoZW4KPiByZS1lbmFibGUgaXQgbGF0ZXIgb24uIElm IHBjaV9kaXNhYmxlX2xpbmtfc3RhdGUoKSBpcyBtYWRlIGZvciB0aGUKPiBkZXZpY2UsIHRoZXJl IGlzIGN1cnJlbnRseSBubyB3YXkgdG8gcmUtZW5hYmxlIHRoZSBzdGF0ZXMgdGhhdCB3ZXJlCj4g ZGlzYWJsZWQuCgpwY2lfZGlzYWJsZV9saW5rX3N0YXRlKCkgZ2l2ZXMgZHJpdmVycyBhIHdheSB0 byBkaXNhYmxlIHNwZWNpZmllZCBBU1BNCnN0YXRlcyB1c2luZyBhIGJpdG1hc2sgKFBDSUVfTElO S19TVEFURV9MMFMsIFBDSUVfTElOS19TVEFURV9MMSwKUENJRV9MSU5LX1NUQVRFX0wxXzEsIGV0 YyksIGJ1dCBJSVVDIHRoZSBkcml2ZXIgY2FuJ3QgdGVsbCBleGFjdGx5CndoYXQgY2hhbmdlZCBh bmQgY2FuJ3QgZGlyZWN0bHkgcmVzdG9yZSB0aGUgb3JpZ2luYWwgc3RhdGUsIGUuZy4sCgogIC0g UENJRV9MSU5LX1NUQVRFX0wxIGVuYWJsZWQgaW5pdGlhbGx5CiAgLSBkcml2ZXIgY2FsbHMgcGNp X2Rpc2FibGVfbGlua19zdGF0ZShQQ0lFX0xJTktfU1RBVEVfTDBTKQogIC0gZHJpdmVyIGNhbGxz IHBjaV9lbmFibGVfbGlua19zdGF0ZShQQ0lFX0xJTktfU1RBVEVfTDBTKQogIC0gUENJRV9MSU5L X1NUQVRFX0wwUyBhbmQgUENJRV9MSU5LX1NUQVRFX0wxIGFyZSBlbmFibGVkIG5vdwoKTm93IFBD SUVfTElOS19TVEFURV9MMFMgaXMgZW5hYmxlZCBldmVuIHRob3VnaCBpdCB3YXMgbm90IGluaXRp YWxseQplbmFibGVkLiAgTWF5YmUgdGhhdCdzIHdoYXQgd2Ugd2FudDsgSSBkdW5uby4KCnBjaV9k aXNhYmxlX2xpbmtfc3RhdGUoKSBjdXJyZW50bHkgcmV0dXJucyBzdWNjZXNzL2ZhaWx1cmUsIGJ1 dCBvbmx5CnI4MTY5IGFuZCBtdDc2IGV2ZW4gY2hlY2ssIGFuZCBvbmx5IHJ0bF9pbml0X29uZSgp IChyODE2OSkgaGFzIGEKbm9uLXRyaXZpYWwgcmVhc29uLCBzbyBpdCdzIGNvbmNlaXZhYmxlIHRo YXQgaXQgY291bGQgcmV0dXJuIGEgYml0bWFzawppbnN0ZWFkLgoKPiBBZGQgcGNpX2VuYWJsZV9s aW5rX3N0YXRlKCkgdG8gcmVtb3ZlIEFTUE0gc3RhdGVzIGZyb20gdGhlIHN0YXRlCj4gZGlzYWJs ZSBtYXNrLgo+IAo+IFNpZ25lZC1vZmYtYnk6IElscG8gSsOkcnZpbmVuIDxpbHBvLmphcnZpbmVu QGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9wY2kvcGNpZS9hc3BtLmMgfCA0MiAr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICBpbmNsdWRlL2xpbnV4 L3BjaS5oICAgICB8ICAyICsrCj4gIDIgZmlsZXMgY2hhbmdlZCwgNDQgaW5zZXJ0aW9ucygrKQo+ IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9wY2llL2FzcG0uYyBiL2RyaXZlcnMvcGNpL3Bj aWUvYXNwbS5jCj4gaW5kZXggOTFkYzk1YWNhOTBmLi5mNDVkMThkNDdjMjAgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9wY2kvcGNpZS9hc3BtLmMKPiArKysgYi9kcml2ZXJzL3BjaS9wY2llL2FzcG0u Ywo+IEBAIC0xMTE3LDYgKzExMTcsNDggQEAgaW50IHBjaV9kaXNhYmxlX2xpbmtfc3RhdGUoc3Ry dWN0IHBjaV9kZXYgKnBkZXYsIGludCBzdGF0ZSkKPiAgfQo+ICBFWFBPUlRfU1lNQk9MKHBjaV9k aXNhYmxlX2xpbmtfc3RhdGUpOwo+ICAKPiArLyoqCj4gKyAqIHBjaV9lbmFibGVfbGlua19zdGF0 ZSAtIFJlLWVuYWJsZSBkZXZpY2UncyBsaW5rIHN0YXRlCj4gKyAqIEBwZGV2OiBQQ0kgZGV2aWNl Cj4gKyAqIEBzdGF0ZTogQVNQTSBsaW5rIHN0YXRlcyB0byByZS1lbmFibGUKPiArICoKPiArICog RW5hYmxlIGRldmljZSdzIGxpbmsgc3RhdGUgdGhhdCB3ZXJlIHByZXZpb3VzbHkgZGlzYWJsZSBz byB0aGUgbGluayBpcwoKInN0YXRlW3NdIHRoYXQgd2VyZSBwcmV2aW91c2x5IGRpc2FibGVbZF0i IGFsbHVkZXMgdG8gdGhlIHVzZSBjYXNlIHlvdQpoYXZlIGluIG1pbmQsIGJ1dCBJIGRvbid0IHRo aW5rIGl0IGRlc2NyaWJlcyBob3cgdGhpcyBmdW5jdGlvbgphY3R1YWxseSB3b3Jrcy4gIFRoaXMg ZnVuY3Rpb24ganVzdCBtYWtlcyBpdCBwb3NzaWJsZSB0byBlbmFibGUgdGhlCnNwZWNpZmllZCBz dGF0ZXMuICBUaGUgQHN0YXRlIHBhcmFtZXRlciBtYXkgaGF2ZSBub3RoaW5nIHRvIGRvIHdpdGgK YW55IHByZXZpb3VzbHkgZGlzYWJsZWQgc3RhdGVzLgoKPiArICogYWxsb3dlZCB0byBlbnRlciB0 aGUgc3BlY2lmaWMgc3RhdGVzLiBOb3RlIHRoYXQgaWYgdGhlIEJJT1MgZGlkbid0IGdyYW50Cj4g KyAqIEFTUE0gY29udHJvbCB0byB0aGUgT1MsIHRoaXMgZG9lcyBub3RoaW5nIGJlY2F1c2Ugd2Ug Y2FuJ3QgdG91Y2ggdGhlCj4gKyAqIExOS0NUTCByZWdpc3Rlci4KPiArICoKPiArICogUmV0dXJu OiAwIG9yIGEgbmVnYXRpdmUgZXJybm8uCj4gKyAqLwo+ICtpbnQgcGNpX2VuYWJsZV9saW5rX3N0 YXRlKHN0cnVjdCBwY2lfZGV2ICpwZGV2LCBpbnQgc3RhdGUpCj4gK3sKPiArCXN0cnVjdCBwY2ll X2xpbmtfc3RhdGUgKmxpbmsgPSBwY2llX2FzcG1fZ2V0X2xpbmsocGRldik7Cj4gKwo+ICsJaWYg KCFsaW5rKQo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsJLyoKPiArCSAqIEEgZHJpdmVyIHJlcXVl c3RlZCB0aGF0IEFTUE0gYmUgZW5hYmxlZCBvbiB0aGlzIGRldmljZSwgYnV0Cj4gKwkgKiBpZiB3 ZSBkb24ndCBoYXZlIHBlcm1pc3Npb24gdG8gbWFuYWdlIEFTUE0gKGUuZy4sIG9uIEFDUEkKPiAr CSAqIHN5c3RlbXMgd2UgaGF2ZSB0byBvYnNlcnZlIHRoZSBGQURUIEFDUElfRkFEVF9OT19BU1BN IGJpdCBhbmQKPiArCSAqIHRoZSBfT1NDIG1ldGhvZCksIHdlIGNhbid0IGhvbm9yIHRoYXQgcmVx dWVzdC4KPiArCSAqLwo+ICsJaWYgKGFzcG1fZGlzYWJsZWQpIHsKPiArCQlwY2lfd2FybihwZGV2 LCAiY2FuJ3QgZW5hYmxlIEFTUE07IE9TIGRvZXNuJ3QgaGF2ZSBBU1BNIGNvbnRyb2xcbiIpOwo+ ICsJCXJldHVybiAtRVBFUk07Cj4gKwl9Cj4gKwo+ICsJbXV0ZXhfbG9jaygmYXNwbV9sb2NrKTsK PiArCWxpbmstPmFzcG1fZGlzYWJsZSAmPSB+cGNpX2xpbmtfc3RhdGVfbWFzayhzdGF0ZSk7Cj4g KwlwY2llX2NvbmZpZ19hc3BtX2xpbmsobGluaywgcG9saWN5X3RvX2FzcG1fc3RhdGUobGluaykp Owo+ICsKPiArCWlmIChzdGF0ZSAmIFBDSUVfTElOS19TVEFURV9DTEtQTSkKPiArCQlsaW5rLT5j bGtwbV9kaXNhYmxlID0gMDsKPiArCXBjaWVfc2V0X2Nsa3BtKGxpbmssIHBvbGljeV90b19jbGtw bV9zdGF0ZShsaW5rKSk7Cj4gKwltdXRleF91bmxvY2soJmFzcG1fbG9jayk7Cj4gKwo+ICsJcmV0 dXJuIDA7Cj4gK30KPiArRVhQT1JUX1NZTUJPTChwY2lfZW5hYmxlX2xpbmtfc3RhdGUpOwo+ICsK PiAgLyoqCj4gICAqIHBjaV9zZXRfZGVmYXVsdF9saW5rX3N0YXRlIC0gU2V0IHRoZSBkZWZhdWx0 IGRldmljZSBsaW5rIHN0YXRlCj4gICAqIEBwZGV2OiBQQ0kgZGV2aWNlCj4gZGlmZiAtLWdpdCBh L2luY2x1ZGUvbGludXgvcGNpLmggYi9pbmNsdWRlL2xpbnV4L3BjaS5oCj4gaW5kZXggM2MyNGNh MTY0MTA0Li44NDRkMDkyMzAyNjQgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9saW51eC9wY2kuaAo+ ICsrKyBiL2luY2x1ZGUvbGludXgvcGNpLmgKPiBAQCAtMTc3NiwxMSArMTc3NiwxMyBAQCBleHRl cm4gYm9vbCBwY2llX3BvcnRzX25hdGl2ZTsKPiAgaW50IHBjaV9kaXNhYmxlX2xpbmtfc3RhdGUo c3RydWN0IHBjaV9kZXYgKnBkZXYsIGludCBzdGF0ZSk7Cj4gIGludCBwY2lfZGlzYWJsZV9saW5r X3N0YXRlX2xvY2tlZChzdHJ1Y3QgcGNpX2RldiAqcGRldiwgaW50IHN0YXRlKTsKPiAgI2lmZGVm IENPTkZJR19QQ0lFQVNQTQo+ICtpbnQgcGNpX2VuYWJsZV9saW5rX3N0YXRlKHN0cnVjdCBwY2lf ZGV2ICpwZGV2LCBpbnQgc3RhdGUpOwo+ICBpbnQgcGNpX3NldF9kZWZhdWx0X2xpbmtfc3RhdGUo c3RydWN0IHBjaV9kZXYgKnBkZXYsIGludCBzdGF0ZSk7Cj4gIHZvaWQgcGNpZV9ub19hc3BtKHZv aWQpOwo+ICBib29sIHBjaWVfYXNwbV9zdXBwb3J0X2VuYWJsZWQodm9pZCk7Cj4gIGJvb2wgcGNp ZV9hc3BtX2VuYWJsZWQoc3RydWN0IHBjaV9kZXYgKnBkZXYpOwo+ICAjZWxzZQo+ICtzdGF0aWMg aW5saW5lIGludCBwY2lfZW5hYmxlX2xpbmtfc3RhdGUoc3RydWN0IHBjaV9kZXYgKnBkZXYsIGlu dCBzdGF0ZSkgeyByZXR1cm4gLUVPUE5PVFNVUFA7IH0KPiAgc3RhdGljIGlubGluZSBpbnQgcGNp X3NldF9kZWZhdWx0X2xpbmtfc3RhdGUoc3RydWN0IHBjaV9kZXYgKnBkZXYsIGludCBzdGF0ZSkK PiAgeyByZXR1cm4gMDsgfQo+ICBzdGF0aWMgaW5saW5lIHZvaWQgcGNpZV9ub19hc3BtKHZvaWQp IHsgfQo+IC0tIAo+IDIuMzAuMgo+IAo+IAo+IC0tIAo+IGF0aDEyayBtYWlsaW5nIGxpc3QKPiBh dGgxMmtAbGlzdHMuaW5mcmFkZWFkLm9yZwo+IGh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2F0aDEyawoKLS0gCmF0aDExayBtYWlsaW5nIGxpc3QKYXRoMTFrQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9hdGgxMWsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 554D4CDB487 for ; Wed, 11 Oct 2023 21:53:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=gpGg5PjYvNwz2rpAQxTzuPfZhomPyJocSAcRXt19wsU=; b=IRL7xhxk7LAdF+ KQsMYgdS0TxobnJH6kCg6EmuV/1PaPCnXhGtfzAS8FXIlKZFpE4UEJTQgaUWc8RpsZIAiP12grxTs N1sfmHolSbNNHIolV3kT1Nnzd+kBlDe+rApi2OFJnl0Mn0xTLHA5/hKRScxs9Gl9Yu2y4UnFvi89g xNS+xykb24yMJQRux7LIoPPTlisylTdUj1xEtQVjWXloBa6CphBm49ihzH0PTlCTf9+X3TOERn3Im DQuRF2ktvlD06vYPOSmzHKEhj03Ck7kDdiJMk9d7lkY+if59VQEUBkBFe1PQQqIAQAZdCN9zYkx4w BJXlrwVQRWF16ObUzzWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqh96-00GmPd-2x for ath12k@archiver.kernel.org; Wed, 11 Oct 2023 21:53:36 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qqh92-00GmMv-09; Wed, 11 Oct 2023 21:53:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 8399AB8201E; Wed, 11 Oct 2023 21:53:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87540C433C9; Wed, 11 Oct 2023 21:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697061209; bh=qY9Rp5zkRIt2DsQivgERNNESbVTGEul4kS5s7/dIoho=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=EAwNFrclnTWEuXdB+Z8mt3u3kuEAAoUwY82PbS8J18XDNC6E3OiHHHxAFbbd17IOO T6KemaFOH4w9WVID23kFc5vCnMeXYebhs7yahyg9gnbxexaaSqR+KOEgoCrxijFWyG dnCiAysL1ttbyJnzXZGaT8aqz/DwQbEhhDfWR38iscslUEL9bLiDHhVjMYSwKPoaYH vE7EY6dncxhXQ4FluROOjHz7swY5mrWHaRm0x+YRj0w+mEnls2n/6+o4Mg69zLynhg wf5HljSZ4OwbmmK2VZKj4KXyrtee/VgZ11v8Vna96PUYyaJ2T6vmKgYUE3ho/7KBKo bDWaoqyCH5pFQ== Date: Wed, 11 Oct 2023 16:53:27 -0500 From: Bjorn Helgaas To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= Cc: linux-pci@vger.kernel.org, Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Lukas Wunner , "Rafael J . Wysocki" , Heiner Kallweit , Emmanuel Grumbach , linux-kernel@vger.kernel.org, Bjorn Helgaas , ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, intel-wired-lan@lists.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-bluetooth@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 05/13] PCI/ASPM: Add pci_enable_link_state() Message-ID: <20231011215327.GA1043654@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230918131103.24119-6-ilpo.jarvinen@linux.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231011_145332_354395_3D1F5816 X-CRM114-Status: GOOD ( 30.80 ) X-BeenThere: ath12k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath12k" Errors-To: ath12k-bounces+ath12k=archiver.kernel.org@lists.infradead.org T24gTW9uLCBTZXAgMTgsIDIwMjMgYXQgMDQ6MTA6NTVQTSArMDMwMCwgSWxwbyBKw6RydmluZW4g d3JvdGU6Cj4gcGNpX2Rpc2FibGVfbGlua19zdGF0ZSgpIGxhY2tzIGEgc3ltbWV0cmljIHBhaXIu IFNvbWUgZHJpdmVycyB3YW50IHRvCj4gZGlzYWJsZSBBU1BNIGR1cmluZyBjZXJ0YWluIHBoYXNl cyBvZiB0aGVpciBvcGVyYXRpb24gYnV0IHRoZW4KPiByZS1lbmFibGUgaXQgbGF0ZXIgb24uIElm IHBjaV9kaXNhYmxlX2xpbmtfc3RhdGUoKSBpcyBtYWRlIGZvciB0aGUKPiBkZXZpY2UsIHRoZXJl IGlzIGN1cnJlbnRseSBubyB3YXkgdG8gcmUtZW5hYmxlIHRoZSBzdGF0ZXMgdGhhdCB3ZXJlCj4g ZGlzYWJsZWQuCgpwY2lfZGlzYWJsZV9saW5rX3N0YXRlKCkgZ2l2ZXMgZHJpdmVycyBhIHdheSB0 byBkaXNhYmxlIHNwZWNpZmllZCBBU1BNCnN0YXRlcyB1c2luZyBhIGJpdG1hc2sgKFBDSUVfTElO S19TVEFURV9MMFMsIFBDSUVfTElOS19TVEFURV9MMSwKUENJRV9MSU5LX1NUQVRFX0wxXzEsIGV0 YyksIGJ1dCBJSVVDIHRoZSBkcml2ZXIgY2FuJ3QgdGVsbCBleGFjdGx5CndoYXQgY2hhbmdlZCBh bmQgY2FuJ3QgZGlyZWN0bHkgcmVzdG9yZSB0aGUgb3JpZ2luYWwgc3RhdGUsIGUuZy4sCgogIC0g UENJRV9MSU5LX1NUQVRFX0wxIGVuYWJsZWQgaW5pdGlhbGx5CiAgLSBkcml2ZXIgY2FsbHMgcGNp X2Rpc2FibGVfbGlua19zdGF0ZShQQ0lFX0xJTktfU1RBVEVfTDBTKQogIC0gZHJpdmVyIGNhbGxz IHBjaV9lbmFibGVfbGlua19zdGF0ZShQQ0lFX0xJTktfU1RBVEVfTDBTKQogIC0gUENJRV9MSU5L X1NUQVRFX0wwUyBhbmQgUENJRV9MSU5LX1NUQVRFX0wxIGFyZSBlbmFibGVkIG5vdwoKTm93IFBD SUVfTElOS19TVEFURV9MMFMgaXMgZW5hYmxlZCBldmVuIHRob3VnaCBpdCB3YXMgbm90IGluaXRp YWxseQplbmFibGVkLiAgTWF5YmUgdGhhdCdzIHdoYXQgd2Ugd2FudDsgSSBkdW5uby4KCnBjaV9k aXNhYmxlX2xpbmtfc3RhdGUoKSBjdXJyZW50bHkgcmV0dXJucyBzdWNjZXNzL2ZhaWx1cmUsIGJ1 dCBvbmx5CnI4MTY5IGFuZCBtdDc2IGV2ZW4gY2hlY2ssIGFuZCBvbmx5IHJ0bF9pbml0X29uZSgp IChyODE2OSkgaGFzIGEKbm9uLXRyaXZpYWwgcmVhc29uLCBzbyBpdCdzIGNvbmNlaXZhYmxlIHRo YXQgaXQgY291bGQgcmV0dXJuIGEgYml0bWFzawppbnN0ZWFkLgoKPiBBZGQgcGNpX2VuYWJsZV9s aW5rX3N0YXRlKCkgdG8gcmVtb3ZlIEFTUE0gc3RhdGVzIGZyb20gdGhlIHN0YXRlCj4gZGlzYWJs ZSBtYXNrLgo+IAo+IFNpZ25lZC1vZmYtYnk6IElscG8gSsOkcnZpbmVuIDxpbHBvLmphcnZpbmVu QGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9wY2kvcGNpZS9hc3BtLmMgfCA0MiAr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICBpbmNsdWRlL2xpbnV4 L3BjaS5oICAgICB8ICAyICsrCj4gIDIgZmlsZXMgY2hhbmdlZCwgNDQgaW5zZXJ0aW9ucygrKQo+ IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9wY2llL2FzcG0uYyBiL2RyaXZlcnMvcGNpL3Bj aWUvYXNwbS5jCj4gaW5kZXggOTFkYzk1YWNhOTBmLi5mNDVkMThkNDdjMjAgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9wY2kvcGNpZS9hc3BtLmMKPiArKysgYi9kcml2ZXJzL3BjaS9wY2llL2FzcG0u Ywo+IEBAIC0xMTE3LDYgKzExMTcsNDggQEAgaW50IHBjaV9kaXNhYmxlX2xpbmtfc3RhdGUoc3Ry dWN0IHBjaV9kZXYgKnBkZXYsIGludCBzdGF0ZSkKPiAgfQo+ICBFWFBPUlRfU1lNQk9MKHBjaV9k aXNhYmxlX2xpbmtfc3RhdGUpOwo+ICAKPiArLyoqCj4gKyAqIHBjaV9lbmFibGVfbGlua19zdGF0 ZSAtIFJlLWVuYWJsZSBkZXZpY2UncyBsaW5rIHN0YXRlCj4gKyAqIEBwZGV2OiBQQ0kgZGV2aWNl Cj4gKyAqIEBzdGF0ZTogQVNQTSBsaW5rIHN0YXRlcyB0byByZS1lbmFibGUKPiArICoKPiArICog RW5hYmxlIGRldmljZSdzIGxpbmsgc3RhdGUgdGhhdCB3ZXJlIHByZXZpb3VzbHkgZGlzYWJsZSBz byB0aGUgbGluayBpcwoKInN0YXRlW3NdIHRoYXQgd2VyZSBwcmV2aW91c2x5IGRpc2FibGVbZF0i IGFsbHVkZXMgdG8gdGhlIHVzZSBjYXNlIHlvdQpoYXZlIGluIG1pbmQsIGJ1dCBJIGRvbid0IHRo aW5rIGl0IGRlc2NyaWJlcyBob3cgdGhpcyBmdW5jdGlvbgphY3R1YWxseSB3b3Jrcy4gIFRoaXMg ZnVuY3Rpb24ganVzdCBtYWtlcyBpdCBwb3NzaWJsZSB0byBlbmFibGUgdGhlCnNwZWNpZmllZCBz dGF0ZXMuICBUaGUgQHN0YXRlIHBhcmFtZXRlciBtYXkgaGF2ZSBub3RoaW5nIHRvIGRvIHdpdGgK YW55IHByZXZpb3VzbHkgZGlzYWJsZWQgc3RhdGVzLgoKPiArICogYWxsb3dlZCB0byBlbnRlciB0 aGUgc3BlY2lmaWMgc3RhdGVzLiBOb3RlIHRoYXQgaWYgdGhlIEJJT1MgZGlkbid0IGdyYW50Cj4g KyAqIEFTUE0gY29udHJvbCB0byB0aGUgT1MsIHRoaXMgZG9lcyBub3RoaW5nIGJlY2F1c2Ugd2Ug Y2FuJ3QgdG91Y2ggdGhlCj4gKyAqIExOS0NUTCByZWdpc3Rlci4KPiArICoKPiArICogUmV0dXJu OiAwIG9yIGEgbmVnYXRpdmUgZXJybm8uCj4gKyAqLwo+ICtpbnQgcGNpX2VuYWJsZV9saW5rX3N0 YXRlKHN0cnVjdCBwY2lfZGV2ICpwZGV2LCBpbnQgc3RhdGUpCj4gK3sKPiArCXN0cnVjdCBwY2ll X2xpbmtfc3RhdGUgKmxpbmsgPSBwY2llX2FzcG1fZ2V0X2xpbmsocGRldik7Cj4gKwo+ICsJaWYg KCFsaW5rKQo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsJLyoKPiArCSAqIEEgZHJpdmVyIHJlcXVl c3RlZCB0aGF0IEFTUE0gYmUgZW5hYmxlZCBvbiB0aGlzIGRldmljZSwgYnV0Cj4gKwkgKiBpZiB3 ZSBkb24ndCBoYXZlIHBlcm1pc3Npb24gdG8gbWFuYWdlIEFTUE0gKGUuZy4sIG9uIEFDUEkKPiAr CSAqIHN5c3RlbXMgd2UgaGF2ZSB0byBvYnNlcnZlIHRoZSBGQURUIEFDUElfRkFEVF9OT19BU1BN IGJpdCBhbmQKPiArCSAqIHRoZSBfT1NDIG1ldGhvZCksIHdlIGNhbid0IGhvbm9yIHRoYXQgcmVx dWVzdC4KPiArCSAqLwo+ICsJaWYgKGFzcG1fZGlzYWJsZWQpIHsKPiArCQlwY2lfd2FybihwZGV2 LCAiY2FuJ3QgZW5hYmxlIEFTUE07IE9TIGRvZXNuJ3QgaGF2ZSBBU1BNIGNvbnRyb2xcbiIpOwo+ ICsJCXJldHVybiAtRVBFUk07Cj4gKwl9Cj4gKwo+ICsJbXV0ZXhfbG9jaygmYXNwbV9sb2NrKTsK PiArCWxpbmstPmFzcG1fZGlzYWJsZSAmPSB+cGNpX2xpbmtfc3RhdGVfbWFzayhzdGF0ZSk7Cj4g KwlwY2llX2NvbmZpZ19hc3BtX2xpbmsobGluaywgcG9saWN5X3RvX2FzcG1fc3RhdGUobGluaykp Owo+ICsKPiArCWlmIChzdGF0ZSAmIFBDSUVfTElOS19TVEFURV9DTEtQTSkKPiArCQlsaW5rLT5j bGtwbV9kaXNhYmxlID0gMDsKPiArCXBjaWVfc2V0X2Nsa3BtKGxpbmssIHBvbGljeV90b19jbGtw bV9zdGF0ZShsaW5rKSk7Cj4gKwltdXRleF91bmxvY2soJmFzcG1fbG9jayk7Cj4gKwo+ICsJcmV0 dXJuIDA7Cj4gK30KPiArRVhQT1JUX1NZTUJPTChwY2lfZW5hYmxlX2xpbmtfc3RhdGUpOwo+ICsK PiAgLyoqCj4gICAqIHBjaV9zZXRfZGVmYXVsdF9saW5rX3N0YXRlIC0gU2V0IHRoZSBkZWZhdWx0 IGRldmljZSBsaW5rIHN0YXRlCj4gICAqIEBwZGV2OiBQQ0kgZGV2aWNlCj4gZGlmZiAtLWdpdCBh L2luY2x1ZGUvbGludXgvcGNpLmggYi9pbmNsdWRlL2xpbnV4L3BjaS5oCj4gaW5kZXggM2MyNGNh MTY0MTA0Li44NDRkMDkyMzAyNjQgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9saW51eC9wY2kuaAo+ ICsrKyBiL2luY2x1ZGUvbGludXgvcGNpLmgKPiBAQCAtMTc3NiwxMSArMTc3NiwxMyBAQCBleHRl cm4gYm9vbCBwY2llX3BvcnRzX25hdGl2ZTsKPiAgaW50IHBjaV9kaXNhYmxlX2xpbmtfc3RhdGUo c3RydWN0IHBjaV9kZXYgKnBkZXYsIGludCBzdGF0ZSk7Cj4gIGludCBwY2lfZGlzYWJsZV9saW5r X3N0YXRlX2xvY2tlZChzdHJ1Y3QgcGNpX2RldiAqcGRldiwgaW50IHN0YXRlKTsKPiAgI2lmZGVm IENPTkZJR19QQ0lFQVNQTQo+ICtpbnQgcGNpX2VuYWJsZV9saW5rX3N0YXRlKHN0cnVjdCBwY2lf ZGV2ICpwZGV2LCBpbnQgc3RhdGUpOwo+ICBpbnQgcGNpX3NldF9kZWZhdWx0X2xpbmtfc3RhdGUo c3RydWN0IHBjaV9kZXYgKnBkZXYsIGludCBzdGF0ZSk7Cj4gIHZvaWQgcGNpZV9ub19hc3BtKHZv aWQpOwo+ICBib29sIHBjaWVfYXNwbV9zdXBwb3J0X2VuYWJsZWQodm9pZCk7Cj4gIGJvb2wgcGNp ZV9hc3BtX2VuYWJsZWQoc3RydWN0IHBjaV9kZXYgKnBkZXYpOwo+ICAjZWxzZQo+ICtzdGF0aWMg aW5saW5lIGludCBwY2lfZW5hYmxlX2xpbmtfc3RhdGUoc3RydWN0IHBjaV9kZXYgKnBkZXYsIGlu dCBzdGF0ZSkgeyByZXR1cm4gLUVPUE5PVFNVUFA7IH0KPiAgc3RhdGljIGlubGluZSBpbnQgcGNp X3NldF9kZWZhdWx0X2xpbmtfc3RhdGUoc3RydWN0IHBjaV9kZXYgKnBkZXYsIGludCBzdGF0ZSkK PiAgeyByZXR1cm4gMDsgfQo+ICBzdGF0aWMgaW5saW5lIHZvaWQgcGNpZV9ub19hc3BtKHZvaWQp IHsgfQo+IC0tIAo+IDIuMzAuMgo+IAo+IAo+IC0tIAo+IGF0aDEyayBtYWlsaW5nIGxpc3QKPiBh dGgxMmtAbGlzdHMuaW5mcmFkZWFkLm9yZwo+IGh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2F0aDEyawoKLS0gCmF0aDEyayBtYWlsaW5nIGxpc3QKYXRoMTJrQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vYXRoMTJrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0322FCDB485 for ; Wed, 11 Oct 2023 21:53:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 80AD04149F; Wed, 11 Oct 2023 21:53:36 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 80AD04149F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1697061216; bh=L1f/4/b3so1wRpX0A6SVZni65wWVqV4awCK8qg1PkLY=; h=Date:From:To:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:Cc:From; b=tW/FJYy27aSh5++JCM/bIaFKoTrz5gnPm98/u9caKlDo624YGDMkIDjLvdU7Mo5wu j8xLut6/72GFdMJrHePBQawYnMNaAXjkgsmqsEXJHJsiyoujs7cyOPeuC4X+s0EEAb QZn+8Cy4EDwY0LCdjtW5bPgPwPVLcZvmoxRRLEN3SrvBQ48asvAD06z+J9pP1lQ7Kg ft+Kgxe5XqshSEn0byRVeZZVELUGX0YaMe3m36MosEuzWL9vGGC5QBosplGStaajcJ EazP98KjDvMuwx3BQQ3WMaQP+IL2WKUJ6EhVP0FTlGiyY553xqg7HUJTZD2b/C9YQk wd6uWc3pgDfUg== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rXQncz4a8L9J; Wed, 11 Oct 2023 21:53:35 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 16CF4414A2; Wed, 11 Oct 2023 21:53:35 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 16CF4414A2 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id D7D3E1BF3E8 for ; Wed, 11 Oct 2023 21:53:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id ABDCD82279 for ; Wed, 11 Oct 2023 21:53:33 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org ABDCD82279 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9kuKlObTtG8P for ; Wed, 11 Oct 2023 21:53:32 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by smtp1.osuosl.org (Postfix) with ESMTPS id 6F85A82275 for ; Wed, 11 Oct 2023 21:53:32 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 6F85A82275 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 8399AB8201E; Wed, 11 Oct 2023 21:53:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87540C433C9; Wed, 11 Oct 2023 21:53:29 +0000 (UTC) Date: Wed, 11 Oct 2023 16:53:27 -0500 From: Bjorn Helgaas To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= Message-ID: <20231011215327.GA1043654@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230918131103.24119-6-ilpo.jarvinen@linux.intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697061209; bh=qY9Rp5zkRIt2DsQivgERNNESbVTGEul4kS5s7/dIoho=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=EAwNFrclnTWEuXdB+Z8mt3u3kuEAAoUwY82PbS8J18XDNC6E3OiHHHxAFbbd17IOO T6KemaFOH4w9WVID23kFc5vCnMeXYebhs7yahyg9gnbxexaaSqR+KOEgoCrxijFWyG dnCiAysL1ttbyJnzXZGaT8aqz/DwQbEhhDfWR38iscslUEL9bLiDHhVjMYSwKPoaYH vE7EY6dncxhXQ4FluROOjHz7swY5mrWHaRm0x+YRj0w+mEnls2n/6+o4Mg69zLynhg wf5HljSZ4OwbmmK2VZKj4KXyrtee/VgZ11v8Vna96PUYyaJ2T6vmKgYUE3ho/7KBKo bDWaoqyCH5pFQ== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=EAwNFrcl Subject: Re: [Intel-wired-lan] [PATCH v2 05/13] PCI/ASPM: Add pci_enable_link_state() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , linux-rdma@vger.kernel.org, Lorenzo Pieralisi , "Rafael J . Wysocki" , ath12k@lists.infradead.org, linux-pci@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, Emmanuel Grumbach , linux-bluetooth@vger.kernel.org, Lukas Wunner , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Bjorn Helgaas , linux-mediatek@lists.infradead.org, Rob Herring , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" T24gTW9uLCBTZXAgMTgsIDIwMjMgYXQgMDQ6MTA6NTVQTSArMDMwMCwgSWxwbyBKw6RydmluZW4g d3JvdGU6Cj4gcGNpX2Rpc2FibGVfbGlua19zdGF0ZSgpIGxhY2tzIGEgc3ltbWV0cmljIHBhaXIu IFNvbWUgZHJpdmVycyB3YW50IHRvCj4gZGlzYWJsZSBBU1BNIGR1cmluZyBjZXJ0YWluIHBoYXNl cyBvZiB0aGVpciBvcGVyYXRpb24gYnV0IHRoZW4KPiByZS1lbmFibGUgaXQgbGF0ZXIgb24uIElm IHBjaV9kaXNhYmxlX2xpbmtfc3RhdGUoKSBpcyBtYWRlIGZvciB0aGUKPiBkZXZpY2UsIHRoZXJl IGlzIGN1cnJlbnRseSBubyB3YXkgdG8gcmUtZW5hYmxlIHRoZSBzdGF0ZXMgdGhhdCB3ZXJlCj4g ZGlzYWJsZWQuCgpwY2lfZGlzYWJsZV9saW5rX3N0YXRlKCkgZ2l2ZXMgZHJpdmVycyBhIHdheSB0 byBkaXNhYmxlIHNwZWNpZmllZCBBU1BNCnN0YXRlcyB1c2luZyBhIGJpdG1hc2sgKFBDSUVfTElO S19TVEFURV9MMFMsIFBDSUVfTElOS19TVEFURV9MMSwKUENJRV9MSU5LX1NUQVRFX0wxXzEsIGV0 YyksIGJ1dCBJSVVDIHRoZSBkcml2ZXIgY2FuJ3QgdGVsbCBleGFjdGx5CndoYXQgY2hhbmdlZCBh bmQgY2FuJ3QgZGlyZWN0bHkgcmVzdG9yZSB0aGUgb3JpZ2luYWwgc3RhdGUsIGUuZy4sCgogIC0g UENJRV9MSU5LX1NUQVRFX0wxIGVuYWJsZWQgaW5pdGlhbGx5CiAgLSBkcml2ZXIgY2FsbHMgcGNp X2Rpc2FibGVfbGlua19zdGF0ZShQQ0lFX0xJTktfU1RBVEVfTDBTKQogIC0gZHJpdmVyIGNhbGxz IHBjaV9lbmFibGVfbGlua19zdGF0ZShQQ0lFX0xJTktfU1RBVEVfTDBTKQogIC0gUENJRV9MSU5L X1NUQVRFX0wwUyBhbmQgUENJRV9MSU5LX1NUQVRFX0wxIGFyZSBlbmFibGVkIG5vdwoKTm93IFBD SUVfTElOS19TVEFURV9MMFMgaXMgZW5hYmxlZCBldmVuIHRob3VnaCBpdCB3YXMgbm90IGluaXRp YWxseQplbmFibGVkLiAgTWF5YmUgdGhhdCdzIHdoYXQgd2Ugd2FudDsgSSBkdW5uby4KCnBjaV9k aXNhYmxlX2xpbmtfc3RhdGUoKSBjdXJyZW50bHkgcmV0dXJucyBzdWNjZXNzL2ZhaWx1cmUsIGJ1 dCBvbmx5CnI4MTY5IGFuZCBtdDc2IGV2ZW4gY2hlY2ssIGFuZCBvbmx5IHJ0bF9pbml0X29uZSgp IChyODE2OSkgaGFzIGEKbm9uLXRyaXZpYWwgcmVhc29uLCBzbyBpdCdzIGNvbmNlaXZhYmxlIHRo YXQgaXQgY291bGQgcmV0dXJuIGEgYml0bWFzawppbnN0ZWFkLgoKPiBBZGQgcGNpX2VuYWJsZV9s aW5rX3N0YXRlKCkgdG8gcmVtb3ZlIEFTUE0gc3RhdGVzIGZyb20gdGhlIHN0YXRlCj4gZGlzYWJs ZSBtYXNrLgo+IAo+IFNpZ25lZC1vZmYtYnk6IElscG8gSsOkcnZpbmVuIDxpbHBvLmphcnZpbmVu QGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9wY2kvcGNpZS9hc3BtLmMgfCA0MiAr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICBpbmNsdWRlL2xpbnV4 L3BjaS5oICAgICB8ICAyICsrCj4gIDIgZmlsZXMgY2hhbmdlZCwgNDQgaW5zZXJ0aW9ucygrKQo+ IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9wY2llL2FzcG0uYyBiL2RyaXZlcnMvcGNpL3Bj aWUvYXNwbS5jCj4gaW5kZXggOTFkYzk1YWNhOTBmLi5mNDVkMThkNDdjMjAgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9wY2kvcGNpZS9hc3BtLmMKPiArKysgYi9kcml2ZXJzL3BjaS9wY2llL2FzcG0u Ywo+IEBAIC0xMTE3LDYgKzExMTcsNDggQEAgaW50IHBjaV9kaXNhYmxlX2xpbmtfc3RhdGUoc3Ry dWN0IHBjaV9kZXYgKnBkZXYsIGludCBzdGF0ZSkKPiAgfQo+ICBFWFBPUlRfU1lNQk9MKHBjaV9k aXNhYmxlX2xpbmtfc3RhdGUpOwo+ICAKPiArLyoqCj4gKyAqIHBjaV9lbmFibGVfbGlua19zdGF0 ZSAtIFJlLWVuYWJsZSBkZXZpY2UncyBsaW5rIHN0YXRlCj4gKyAqIEBwZGV2OiBQQ0kgZGV2aWNl Cj4gKyAqIEBzdGF0ZTogQVNQTSBsaW5rIHN0YXRlcyB0byByZS1lbmFibGUKPiArICoKPiArICog RW5hYmxlIGRldmljZSdzIGxpbmsgc3RhdGUgdGhhdCB3ZXJlIHByZXZpb3VzbHkgZGlzYWJsZSBz byB0aGUgbGluayBpcwoKInN0YXRlW3NdIHRoYXQgd2VyZSBwcmV2aW91c2x5IGRpc2FibGVbZF0i IGFsbHVkZXMgdG8gdGhlIHVzZSBjYXNlIHlvdQpoYXZlIGluIG1pbmQsIGJ1dCBJIGRvbid0IHRo aW5rIGl0IGRlc2NyaWJlcyBob3cgdGhpcyBmdW5jdGlvbgphY3R1YWxseSB3b3Jrcy4gIFRoaXMg ZnVuY3Rpb24ganVzdCBtYWtlcyBpdCBwb3NzaWJsZSB0byBlbmFibGUgdGhlCnNwZWNpZmllZCBz dGF0ZXMuICBUaGUgQHN0YXRlIHBhcmFtZXRlciBtYXkgaGF2ZSBub3RoaW5nIHRvIGRvIHdpdGgK YW55IHByZXZpb3VzbHkgZGlzYWJsZWQgc3RhdGVzLgoKPiArICogYWxsb3dlZCB0byBlbnRlciB0 aGUgc3BlY2lmaWMgc3RhdGVzLiBOb3RlIHRoYXQgaWYgdGhlIEJJT1MgZGlkbid0IGdyYW50Cj4g KyAqIEFTUE0gY29udHJvbCB0byB0aGUgT1MsIHRoaXMgZG9lcyBub3RoaW5nIGJlY2F1c2Ugd2Ug Y2FuJ3QgdG91Y2ggdGhlCj4gKyAqIExOS0NUTCByZWdpc3Rlci4KPiArICoKPiArICogUmV0dXJu OiAwIG9yIGEgbmVnYXRpdmUgZXJybm8uCj4gKyAqLwo+ICtpbnQgcGNpX2VuYWJsZV9saW5rX3N0 YXRlKHN0cnVjdCBwY2lfZGV2ICpwZGV2LCBpbnQgc3RhdGUpCj4gK3sKPiArCXN0cnVjdCBwY2ll X2xpbmtfc3RhdGUgKmxpbmsgPSBwY2llX2FzcG1fZ2V0X2xpbmsocGRldik7Cj4gKwo+ICsJaWYg KCFsaW5rKQo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsJLyoKPiArCSAqIEEgZHJpdmVyIHJlcXVl c3RlZCB0aGF0IEFTUE0gYmUgZW5hYmxlZCBvbiB0aGlzIGRldmljZSwgYnV0Cj4gKwkgKiBpZiB3 ZSBkb24ndCBoYXZlIHBlcm1pc3Npb24gdG8gbWFuYWdlIEFTUE0gKGUuZy4sIG9uIEFDUEkKPiAr CSAqIHN5c3RlbXMgd2UgaGF2ZSB0byBvYnNlcnZlIHRoZSBGQURUIEFDUElfRkFEVF9OT19BU1BN IGJpdCBhbmQKPiArCSAqIHRoZSBfT1NDIG1ldGhvZCksIHdlIGNhbid0IGhvbm9yIHRoYXQgcmVx dWVzdC4KPiArCSAqLwo+ICsJaWYgKGFzcG1fZGlzYWJsZWQpIHsKPiArCQlwY2lfd2FybihwZGV2 LCAiY2FuJ3QgZW5hYmxlIEFTUE07IE9TIGRvZXNuJ3QgaGF2ZSBBU1BNIGNvbnRyb2xcbiIpOwo+ ICsJCXJldHVybiAtRVBFUk07Cj4gKwl9Cj4gKwo+ICsJbXV0ZXhfbG9jaygmYXNwbV9sb2NrKTsK PiArCWxpbmstPmFzcG1fZGlzYWJsZSAmPSB+cGNpX2xpbmtfc3RhdGVfbWFzayhzdGF0ZSk7Cj4g KwlwY2llX2NvbmZpZ19hc3BtX2xpbmsobGluaywgcG9saWN5X3RvX2FzcG1fc3RhdGUobGluaykp Owo+ICsKPiArCWlmIChzdGF0ZSAmIFBDSUVfTElOS19TVEFURV9DTEtQTSkKPiArCQlsaW5rLT5j bGtwbV9kaXNhYmxlID0gMDsKPiArCXBjaWVfc2V0X2Nsa3BtKGxpbmssIHBvbGljeV90b19jbGtw bV9zdGF0ZShsaW5rKSk7Cj4gKwltdXRleF91bmxvY2soJmFzcG1fbG9jayk7Cj4gKwo+ICsJcmV0 dXJuIDA7Cj4gK30KPiArRVhQT1JUX1NZTUJPTChwY2lfZW5hYmxlX2xpbmtfc3RhdGUpOwo+ICsK PiAgLyoqCj4gICAqIHBjaV9zZXRfZGVmYXVsdF9saW5rX3N0YXRlIC0gU2V0IHRoZSBkZWZhdWx0 IGRldmljZSBsaW5rIHN0YXRlCj4gICAqIEBwZGV2OiBQQ0kgZGV2aWNlCj4gZGlmZiAtLWdpdCBh L2luY2x1ZGUvbGludXgvcGNpLmggYi9pbmNsdWRlL2xpbnV4L3BjaS5oCj4gaW5kZXggM2MyNGNh MTY0MTA0Li44NDRkMDkyMzAyNjQgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9saW51eC9wY2kuaAo+ ICsrKyBiL2luY2x1ZGUvbGludXgvcGNpLmgKPiBAQCAtMTc3NiwxMSArMTc3NiwxMyBAQCBleHRl cm4gYm9vbCBwY2llX3BvcnRzX25hdGl2ZTsKPiAgaW50IHBjaV9kaXNhYmxlX2xpbmtfc3RhdGUo c3RydWN0IHBjaV9kZXYgKnBkZXYsIGludCBzdGF0ZSk7Cj4gIGludCBwY2lfZGlzYWJsZV9saW5r X3N0YXRlX2xvY2tlZChzdHJ1Y3QgcGNpX2RldiAqcGRldiwgaW50IHN0YXRlKTsKPiAgI2lmZGVm IENPTkZJR19QQ0lFQVNQTQo+ICtpbnQgcGNpX2VuYWJsZV9saW5rX3N0YXRlKHN0cnVjdCBwY2lf ZGV2ICpwZGV2LCBpbnQgc3RhdGUpOwo+ICBpbnQgcGNpX3NldF9kZWZhdWx0X2xpbmtfc3RhdGUo c3RydWN0IHBjaV9kZXYgKnBkZXYsIGludCBzdGF0ZSk7Cj4gIHZvaWQgcGNpZV9ub19hc3BtKHZv aWQpOwo+ICBib29sIHBjaWVfYXNwbV9zdXBwb3J0X2VuYWJsZWQodm9pZCk7Cj4gIGJvb2wgcGNp ZV9hc3BtX2VuYWJsZWQoc3RydWN0IHBjaV9kZXYgKnBkZXYpOwo+ICAjZWxzZQo+ICtzdGF0aWMg aW5saW5lIGludCBwY2lfZW5hYmxlX2xpbmtfc3RhdGUoc3RydWN0IHBjaV9kZXYgKnBkZXYsIGlu dCBzdGF0ZSkgeyByZXR1cm4gLUVPUE5PVFNVUFA7IH0KPiAgc3RhdGljIGlubGluZSBpbnQgcGNp X3NldF9kZWZhdWx0X2xpbmtfc3RhdGUoc3RydWN0IHBjaV9kZXYgKnBkZXYsIGludCBzdGF0ZSkK PiAgeyByZXR1cm4gMDsgfQo+ICBzdGF0aWMgaW5saW5lIHZvaWQgcGNpZV9ub19hc3BtKHZvaWQp IHsgfQo+IC0tIAo+IDIuMzAuMgo+IAo+IAo+IC0tIAo+IGF0aDEyayBtYWlsaW5nIGxpc3QKPiBh dGgxMmtAbGlzdHMuaW5mcmFkZWFkLm9yZwo+IGh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2F0aDEyawpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC13aXJlZC1sYW4gbWFpbGluZyBsaXN0CkludGVsLXdpcmVkLWxh bkBvc3Vvc2wub3JnCmh0dHBzOi8vbGlzdHMub3N1b3NsLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLXdpcmVkLWxhbgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B76ECC41513 for ; Wed, 11 Oct 2023 21:53:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233710AbjJKVxd (ORCPT ); Wed, 11 Oct 2023 17:53:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233451AbjJKVxb (ORCPT ); Wed, 11 Oct 2023 17:53:31 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32E179E; Wed, 11 Oct 2023 14:53:30 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87540C433C9; Wed, 11 Oct 2023 21:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697061209; bh=qY9Rp5zkRIt2DsQivgERNNESbVTGEul4kS5s7/dIoho=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=EAwNFrclnTWEuXdB+Z8mt3u3kuEAAoUwY82PbS8J18XDNC6E3OiHHHxAFbbd17IOO T6KemaFOH4w9WVID23kFc5vCnMeXYebhs7yahyg9gnbxexaaSqR+KOEgoCrxijFWyG dnCiAysL1ttbyJnzXZGaT8aqz/DwQbEhhDfWR38iscslUEL9bLiDHhVjMYSwKPoaYH vE7EY6dncxhXQ4FluROOjHz7swY5mrWHaRm0x+YRj0w+mEnls2n/6+o4Mg69zLynhg wf5HljSZ4OwbmmK2VZKj4KXyrtee/VgZ11v8Vna96PUYyaJ2T6vmKgYUE3ho/7KBKo bDWaoqyCH5pFQ== Date: Wed, 11 Oct 2023 16:53:27 -0500 From: Bjorn Helgaas To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= Cc: linux-pci@vger.kernel.org, Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Lukas Wunner , "Rafael J . Wysocki" , Heiner Kallweit , Emmanuel Grumbach , linux-kernel@vger.kernel.org, Bjorn Helgaas , ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, intel-wired-lan@lists.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-bluetooth@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 05/13] PCI/ASPM: Add pci_enable_link_state() Message-ID: <20231011215327.GA1043654@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230918131103.24119-6-ilpo.jarvinen@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On Mon, Sep 18, 2023 at 04:10:55PM +0300, Ilpo Järvinen wrote: > pci_disable_link_state() lacks a symmetric pair. Some drivers want to > disable ASPM during certain phases of their operation but then > re-enable it later on. If pci_disable_link_state() is made for the > device, there is currently no way to re-enable the states that were > disabled. pci_disable_link_state() gives drivers a way to disable specified ASPM states using a bitmask (PCIE_LINK_STATE_L0S, PCIE_LINK_STATE_L1, PCIE_LINK_STATE_L1_1, etc), but IIUC the driver can't tell exactly what changed and can't directly restore the original state, e.g., - PCIE_LINK_STATE_L1 enabled initially - driver calls pci_disable_link_state(PCIE_LINK_STATE_L0S) - driver calls pci_enable_link_state(PCIE_LINK_STATE_L0S) - PCIE_LINK_STATE_L0S and PCIE_LINK_STATE_L1 are enabled now Now PCIE_LINK_STATE_L0S is enabled even though it was not initially enabled. Maybe that's what we want; I dunno. pci_disable_link_state() currently returns success/failure, but only r8169 and mt76 even check, and only rtl_init_one() (r8169) has a non-trivial reason, so it's conceivable that it could return a bitmask instead. > Add pci_enable_link_state() to remove ASPM states from the state > disable mask. > > Signed-off-by: Ilpo Järvinen > --- > drivers/pci/pcie/aspm.c | 42 +++++++++++++++++++++++++++++++++++++++++ > include/linux/pci.h | 2 ++ > 2 files changed, 44 insertions(+) > > diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c > index 91dc95aca90f..f45d18d47c20 100644 > --- a/drivers/pci/pcie/aspm.c > +++ b/drivers/pci/pcie/aspm.c > @@ -1117,6 +1117,48 @@ int pci_disable_link_state(struct pci_dev *pdev, int state) > } > EXPORT_SYMBOL(pci_disable_link_state); > > +/** > + * pci_enable_link_state - Re-enable device's link state > + * @pdev: PCI device > + * @state: ASPM link states to re-enable > + * > + * Enable device's link state that were previously disable so the link is "state[s] that were previously disable[d]" alludes to the use case you have in mind, but I don't think it describes how this function actually works. This function just makes it possible to enable the specified states. The @state parameter may have nothing to do with any previously disabled states. > + * allowed to enter the specific states. Note that if the BIOS didn't grant > + * ASPM control to the OS, this does nothing because we can't touch the > + * LNKCTL register. > + * > + * Return: 0 or a negative errno. > + */ > +int pci_enable_link_state(struct pci_dev *pdev, int state) > +{ > + struct pcie_link_state *link = pcie_aspm_get_link(pdev); > + > + if (!link) > + return -EINVAL; > + /* > + * A driver requested that ASPM be enabled on this device, but > + * if we don't have permission to manage ASPM (e.g., on ACPI > + * systems we have to observe the FADT ACPI_FADT_NO_ASPM bit and > + * the _OSC method), we can't honor that request. > + */ > + if (aspm_disabled) { > + pci_warn(pdev, "can't enable ASPM; OS doesn't have ASPM control\n"); > + return -EPERM; > + } > + > + mutex_lock(&aspm_lock); > + link->aspm_disable &= ~pci_link_state_mask(state); > + pcie_config_aspm_link(link, policy_to_aspm_state(link)); > + > + if (state & PCIE_LINK_STATE_CLKPM) > + link->clkpm_disable = 0; > + pcie_set_clkpm(link, policy_to_clkpm_state(link)); > + mutex_unlock(&aspm_lock); > + > + return 0; > +} > +EXPORT_SYMBOL(pci_enable_link_state); > + > /** > * pci_set_default_link_state - Set the default device link state > * @pdev: PCI device > diff --git a/include/linux/pci.h b/include/linux/pci.h > index 3c24ca164104..844d09230264 100644 > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -1776,11 +1776,13 @@ extern bool pcie_ports_native; > int pci_disable_link_state(struct pci_dev *pdev, int state); > int pci_disable_link_state_locked(struct pci_dev *pdev, int state); > #ifdef CONFIG_PCIEASPM > +int pci_enable_link_state(struct pci_dev *pdev, int state); > int pci_set_default_link_state(struct pci_dev *pdev, int state); > void pcie_no_aspm(void); > bool pcie_aspm_support_enabled(void); > bool pcie_aspm_enabled(struct pci_dev *pdev); > #else > +static inline int pci_enable_link_state(struct pci_dev *pdev, int state) { return -EOPNOTSUPP; } > static inline int pci_set_default_link_state(struct pci_dev *pdev, int state) > { return 0; } > static inline void pcie_no_aspm(void) { } > -- > 2.30.2 > > > -- > ath12k mailing list > ath12k@lists.infradead.org > https://lists.infradead.org/mailman/listinfo/ath12k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 003A3CDB482 for ; Wed, 11 Oct 2023 21:54:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=wcjDyw8q2MS+ex+Jy5MNLa4RtqsWNKlv6LNse2f2jI0=; b=WxC1/uLpMbLHos EbwY9fZiuENXbOG6FN59DS+82hL6y4ESCMqVuSM0JxPV1/KSgS0400EYQ4aDzx5ZlBSY/wxBYELUw 3hG1uPH9IsJnFS54chl9GFdGIb4KouZ4Lz/atG7RuP0taNZsq9ONtt0eysuG8JtzGnMXCmJbcDUQh myE4CUU7z7fASxAa0qL4r0opmOwj5wHAuOlv5M/v7/RZp3KkVuFzU2fWEb0PvsOxCjC6FgbEQEYZV bye6YAPFgGH5dWla0dXOlJ0mHCSDSL2+Sw4TTXTOlElGIxvH8VsXo211DR1QhyAHBPNDKvqJ6qo0w vYFmpAN7l8+hBdsriiSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqh97-00GmQ2-1a; Wed, 11 Oct 2023 21:53:37 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qqh92-00GmMv-09; Wed, 11 Oct 2023 21:53:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 8399AB8201E; Wed, 11 Oct 2023 21:53:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87540C433C9; Wed, 11 Oct 2023 21:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697061209; bh=qY9Rp5zkRIt2DsQivgERNNESbVTGEul4kS5s7/dIoho=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=EAwNFrclnTWEuXdB+Z8mt3u3kuEAAoUwY82PbS8J18XDNC6E3OiHHHxAFbbd17IOO T6KemaFOH4w9WVID23kFc5vCnMeXYebhs7yahyg9gnbxexaaSqR+KOEgoCrxijFWyG dnCiAysL1ttbyJnzXZGaT8aqz/DwQbEhhDfWR38iscslUEL9bLiDHhVjMYSwKPoaYH vE7EY6dncxhXQ4FluROOjHz7swY5mrWHaRm0x+YRj0w+mEnls2n/6+o4Mg69zLynhg wf5HljSZ4OwbmmK2VZKj4KXyrtee/VgZ11v8Vna96PUYyaJ2T6vmKgYUE3ho/7KBKo bDWaoqyCH5pFQ== Date: Wed, 11 Oct 2023 16:53:27 -0500 From: Bjorn Helgaas To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= Cc: linux-pci@vger.kernel.org, Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Lukas Wunner , "Rafael J . Wysocki" , Heiner Kallweit , Emmanuel Grumbach , linux-kernel@vger.kernel.org, Bjorn Helgaas , ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, intel-wired-lan@lists.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-bluetooth@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 05/13] PCI/ASPM: Add pci_enable_link_state() Message-ID: <20231011215327.GA1043654@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230918131103.24119-6-ilpo.jarvinen@linux.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231011_145332_354395_3D1F5816 X-CRM114-Status: GOOD ( 30.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBTZXAgMTgsIDIwMjMgYXQgMDQ6MTA6NTVQTSArMDMwMCwgSWxwbyBKw6RydmluZW4g d3JvdGU6Cj4gcGNpX2Rpc2FibGVfbGlua19zdGF0ZSgpIGxhY2tzIGEgc3ltbWV0cmljIHBhaXIu IFNvbWUgZHJpdmVycyB3YW50IHRvCj4gZGlzYWJsZSBBU1BNIGR1cmluZyBjZXJ0YWluIHBoYXNl cyBvZiB0aGVpciBvcGVyYXRpb24gYnV0IHRoZW4KPiByZS1lbmFibGUgaXQgbGF0ZXIgb24uIElm IHBjaV9kaXNhYmxlX2xpbmtfc3RhdGUoKSBpcyBtYWRlIGZvciB0aGUKPiBkZXZpY2UsIHRoZXJl IGlzIGN1cnJlbnRseSBubyB3YXkgdG8gcmUtZW5hYmxlIHRoZSBzdGF0ZXMgdGhhdCB3ZXJlCj4g ZGlzYWJsZWQuCgpwY2lfZGlzYWJsZV9saW5rX3N0YXRlKCkgZ2l2ZXMgZHJpdmVycyBhIHdheSB0 byBkaXNhYmxlIHNwZWNpZmllZCBBU1BNCnN0YXRlcyB1c2luZyBhIGJpdG1hc2sgKFBDSUVfTElO S19TVEFURV9MMFMsIFBDSUVfTElOS19TVEFURV9MMSwKUENJRV9MSU5LX1NUQVRFX0wxXzEsIGV0 YyksIGJ1dCBJSVVDIHRoZSBkcml2ZXIgY2FuJ3QgdGVsbCBleGFjdGx5CndoYXQgY2hhbmdlZCBh bmQgY2FuJ3QgZGlyZWN0bHkgcmVzdG9yZSB0aGUgb3JpZ2luYWwgc3RhdGUsIGUuZy4sCgogIC0g UENJRV9MSU5LX1NUQVRFX0wxIGVuYWJsZWQgaW5pdGlhbGx5CiAgLSBkcml2ZXIgY2FsbHMgcGNp X2Rpc2FibGVfbGlua19zdGF0ZShQQ0lFX0xJTktfU1RBVEVfTDBTKQogIC0gZHJpdmVyIGNhbGxz IHBjaV9lbmFibGVfbGlua19zdGF0ZShQQ0lFX0xJTktfU1RBVEVfTDBTKQogIC0gUENJRV9MSU5L X1NUQVRFX0wwUyBhbmQgUENJRV9MSU5LX1NUQVRFX0wxIGFyZSBlbmFibGVkIG5vdwoKTm93IFBD SUVfTElOS19TVEFURV9MMFMgaXMgZW5hYmxlZCBldmVuIHRob3VnaCBpdCB3YXMgbm90IGluaXRp YWxseQplbmFibGVkLiAgTWF5YmUgdGhhdCdzIHdoYXQgd2Ugd2FudDsgSSBkdW5uby4KCnBjaV9k aXNhYmxlX2xpbmtfc3RhdGUoKSBjdXJyZW50bHkgcmV0dXJucyBzdWNjZXNzL2ZhaWx1cmUsIGJ1 dCBvbmx5CnI4MTY5IGFuZCBtdDc2IGV2ZW4gY2hlY2ssIGFuZCBvbmx5IHJ0bF9pbml0X29uZSgp IChyODE2OSkgaGFzIGEKbm9uLXRyaXZpYWwgcmVhc29uLCBzbyBpdCdzIGNvbmNlaXZhYmxlIHRo YXQgaXQgY291bGQgcmV0dXJuIGEgYml0bWFzawppbnN0ZWFkLgoKPiBBZGQgcGNpX2VuYWJsZV9s aW5rX3N0YXRlKCkgdG8gcmVtb3ZlIEFTUE0gc3RhdGVzIGZyb20gdGhlIHN0YXRlCj4gZGlzYWJs ZSBtYXNrLgo+IAo+IFNpZ25lZC1vZmYtYnk6IElscG8gSsOkcnZpbmVuIDxpbHBvLmphcnZpbmVu QGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9wY2kvcGNpZS9hc3BtLmMgfCA0MiAr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICBpbmNsdWRlL2xpbnV4 L3BjaS5oICAgICB8ICAyICsrCj4gIDIgZmlsZXMgY2hhbmdlZCwgNDQgaW5zZXJ0aW9ucygrKQo+ IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9wY2llL2FzcG0uYyBiL2RyaXZlcnMvcGNpL3Bj aWUvYXNwbS5jCj4gaW5kZXggOTFkYzk1YWNhOTBmLi5mNDVkMThkNDdjMjAgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9wY2kvcGNpZS9hc3BtLmMKPiArKysgYi9kcml2ZXJzL3BjaS9wY2llL2FzcG0u Ywo+IEBAIC0xMTE3LDYgKzExMTcsNDggQEAgaW50IHBjaV9kaXNhYmxlX2xpbmtfc3RhdGUoc3Ry dWN0IHBjaV9kZXYgKnBkZXYsIGludCBzdGF0ZSkKPiAgfQo+ICBFWFBPUlRfU1lNQk9MKHBjaV9k aXNhYmxlX2xpbmtfc3RhdGUpOwo+ICAKPiArLyoqCj4gKyAqIHBjaV9lbmFibGVfbGlua19zdGF0 ZSAtIFJlLWVuYWJsZSBkZXZpY2UncyBsaW5rIHN0YXRlCj4gKyAqIEBwZGV2OiBQQ0kgZGV2aWNl Cj4gKyAqIEBzdGF0ZTogQVNQTSBsaW5rIHN0YXRlcyB0byByZS1lbmFibGUKPiArICoKPiArICog RW5hYmxlIGRldmljZSdzIGxpbmsgc3RhdGUgdGhhdCB3ZXJlIHByZXZpb3VzbHkgZGlzYWJsZSBz byB0aGUgbGluayBpcwoKInN0YXRlW3NdIHRoYXQgd2VyZSBwcmV2aW91c2x5IGRpc2FibGVbZF0i IGFsbHVkZXMgdG8gdGhlIHVzZSBjYXNlIHlvdQpoYXZlIGluIG1pbmQsIGJ1dCBJIGRvbid0IHRo aW5rIGl0IGRlc2NyaWJlcyBob3cgdGhpcyBmdW5jdGlvbgphY3R1YWxseSB3b3Jrcy4gIFRoaXMg ZnVuY3Rpb24ganVzdCBtYWtlcyBpdCBwb3NzaWJsZSB0byBlbmFibGUgdGhlCnNwZWNpZmllZCBz dGF0ZXMuICBUaGUgQHN0YXRlIHBhcmFtZXRlciBtYXkgaGF2ZSBub3RoaW5nIHRvIGRvIHdpdGgK YW55IHByZXZpb3VzbHkgZGlzYWJsZWQgc3RhdGVzLgoKPiArICogYWxsb3dlZCB0byBlbnRlciB0 aGUgc3BlY2lmaWMgc3RhdGVzLiBOb3RlIHRoYXQgaWYgdGhlIEJJT1MgZGlkbid0IGdyYW50Cj4g KyAqIEFTUE0gY29udHJvbCB0byB0aGUgT1MsIHRoaXMgZG9lcyBub3RoaW5nIGJlY2F1c2Ugd2Ug Y2FuJ3QgdG91Y2ggdGhlCj4gKyAqIExOS0NUTCByZWdpc3Rlci4KPiArICoKPiArICogUmV0dXJu OiAwIG9yIGEgbmVnYXRpdmUgZXJybm8uCj4gKyAqLwo+ICtpbnQgcGNpX2VuYWJsZV9saW5rX3N0 YXRlKHN0cnVjdCBwY2lfZGV2ICpwZGV2LCBpbnQgc3RhdGUpCj4gK3sKPiArCXN0cnVjdCBwY2ll X2xpbmtfc3RhdGUgKmxpbmsgPSBwY2llX2FzcG1fZ2V0X2xpbmsocGRldik7Cj4gKwo+ICsJaWYg KCFsaW5rKQo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsJLyoKPiArCSAqIEEgZHJpdmVyIHJlcXVl c3RlZCB0aGF0IEFTUE0gYmUgZW5hYmxlZCBvbiB0aGlzIGRldmljZSwgYnV0Cj4gKwkgKiBpZiB3 ZSBkb24ndCBoYXZlIHBlcm1pc3Npb24gdG8gbWFuYWdlIEFTUE0gKGUuZy4sIG9uIEFDUEkKPiAr CSAqIHN5c3RlbXMgd2UgaGF2ZSB0byBvYnNlcnZlIHRoZSBGQURUIEFDUElfRkFEVF9OT19BU1BN IGJpdCBhbmQKPiArCSAqIHRoZSBfT1NDIG1ldGhvZCksIHdlIGNhbid0IGhvbm9yIHRoYXQgcmVx dWVzdC4KPiArCSAqLwo+ICsJaWYgKGFzcG1fZGlzYWJsZWQpIHsKPiArCQlwY2lfd2FybihwZGV2 LCAiY2FuJ3QgZW5hYmxlIEFTUE07IE9TIGRvZXNuJ3QgaGF2ZSBBU1BNIGNvbnRyb2xcbiIpOwo+ ICsJCXJldHVybiAtRVBFUk07Cj4gKwl9Cj4gKwo+ICsJbXV0ZXhfbG9jaygmYXNwbV9sb2NrKTsK PiArCWxpbmstPmFzcG1fZGlzYWJsZSAmPSB+cGNpX2xpbmtfc3RhdGVfbWFzayhzdGF0ZSk7Cj4g KwlwY2llX2NvbmZpZ19hc3BtX2xpbmsobGluaywgcG9saWN5X3RvX2FzcG1fc3RhdGUobGluaykp Owo+ICsKPiArCWlmIChzdGF0ZSAmIFBDSUVfTElOS19TVEFURV9DTEtQTSkKPiArCQlsaW5rLT5j bGtwbV9kaXNhYmxlID0gMDsKPiArCXBjaWVfc2V0X2Nsa3BtKGxpbmssIHBvbGljeV90b19jbGtw bV9zdGF0ZShsaW5rKSk7Cj4gKwltdXRleF91bmxvY2soJmFzcG1fbG9jayk7Cj4gKwo+ICsJcmV0 dXJuIDA7Cj4gK30KPiArRVhQT1JUX1NZTUJPTChwY2lfZW5hYmxlX2xpbmtfc3RhdGUpOwo+ICsK PiAgLyoqCj4gICAqIHBjaV9zZXRfZGVmYXVsdF9saW5rX3N0YXRlIC0gU2V0IHRoZSBkZWZhdWx0 IGRldmljZSBsaW5rIHN0YXRlCj4gICAqIEBwZGV2OiBQQ0kgZGV2aWNlCj4gZGlmZiAtLWdpdCBh L2luY2x1ZGUvbGludXgvcGNpLmggYi9pbmNsdWRlL2xpbnV4L3BjaS5oCj4gaW5kZXggM2MyNGNh MTY0MTA0Li44NDRkMDkyMzAyNjQgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9saW51eC9wY2kuaAo+ ICsrKyBiL2luY2x1ZGUvbGludXgvcGNpLmgKPiBAQCAtMTc3NiwxMSArMTc3NiwxMyBAQCBleHRl cm4gYm9vbCBwY2llX3BvcnRzX25hdGl2ZTsKPiAgaW50IHBjaV9kaXNhYmxlX2xpbmtfc3RhdGUo c3RydWN0IHBjaV9kZXYgKnBkZXYsIGludCBzdGF0ZSk7Cj4gIGludCBwY2lfZGlzYWJsZV9saW5r X3N0YXRlX2xvY2tlZChzdHJ1Y3QgcGNpX2RldiAqcGRldiwgaW50IHN0YXRlKTsKPiAgI2lmZGVm IENPTkZJR19QQ0lFQVNQTQo+ICtpbnQgcGNpX2VuYWJsZV9saW5rX3N0YXRlKHN0cnVjdCBwY2lf ZGV2ICpwZGV2LCBpbnQgc3RhdGUpOwo+ICBpbnQgcGNpX3NldF9kZWZhdWx0X2xpbmtfc3RhdGUo c3RydWN0IHBjaV9kZXYgKnBkZXYsIGludCBzdGF0ZSk7Cj4gIHZvaWQgcGNpZV9ub19hc3BtKHZv aWQpOwo+ICBib29sIHBjaWVfYXNwbV9zdXBwb3J0X2VuYWJsZWQodm9pZCk7Cj4gIGJvb2wgcGNp ZV9hc3BtX2VuYWJsZWQoc3RydWN0IHBjaV9kZXYgKnBkZXYpOwo+ICAjZWxzZQo+ICtzdGF0aWMg aW5saW5lIGludCBwY2lfZW5hYmxlX2xpbmtfc3RhdGUoc3RydWN0IHBjaV9kZXYgKnBkZXYsIGlu dCBzdGF0ZSkgeyByZXR1cm4gLUVPUE5PVFNVUFA7IH0KPiAgc3RhdGljIGlubGluZSBpbnQgcGNp X3NldF9kZWZhdWx0X2xpbmtfc3RhdGUoc3RydWN0IHBjaV9kZXYgKnBkZXYsIGludCBzdGF0ZSkK PiAgeyByZXR1cm4gMDsgfQo+ICBzdGF0aWMgaW5saW5lIHZvaWQgcGNpZV9ub19hc3BtKHZvaWQp IHsgfQo+IC0tIAo+IDIuMzAuMgo+IAo+IAo+IC0tIAo+IGF0aDEyayBtYWlsaW5nIGxpc3QKPiBh dGgxMmtAbGlzdHMuaW5mcmFkZWFkLm9yZwo+IGh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2F0aDEyawoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=