From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alexander Potapenko <glider@google.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Donnellan <ajd@linux.ibm.com>,
Xiaoke Wang <xkernel.wang@foxmail.com>,
stable@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] lib/test_meminit: fix off-by-one error in test_pages()
Date: Thu, 12 Oct 2023 12:26:58 +0200 [thread overview]
Message-ID: <2023101201-grasp-smartly-2085@gregkh> (raw)
In-Reply-To: <CAG_fn=X-dnc06r0Yik24jBaL-f7ZzrUQiUJmMHeN9CaSa3ZveQ@mail.gmail.com>
On Thu, Oct 12, 2023 at 10:40:14AM +0200, Alexander Potapenko wrote:
> On Thu, Oct 12, 2023 at 10:17 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > In commit efb78fa86e95 ("lib/test_meminit: allocate pages up to order
> > MAX_ORDER"), the loop for testing pages is set to "<= MAX_ORDER" which
> > causes crashes in systems when run. Fix this to "< MAX_ORDER" to fix
> > the test to work properly.
>
> What are the crashes you are seeing? Are those OOMs?
They are WARN_ON() triggers. They are burried in the Android build
system, let me see if I can uncover them.
> IIUC it should be valid to allocate with MAX_ORDER.
"should", but I no longer get runtime warnings with this patch applied,
so something is wrong :)
Let me go dig for the logs again...
next prev parent reply other threads:[~2023-10-12 10:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 8:17 [PATCH] lib/test_meminit: fix off-by-one error in test_pages() Greg Kroah-Hartman
2023-10-12 8:40 ` Alexander Potapenko
2023-10-12 10:26 ` Greg Kroah-Hartman [this message]
2023-10-12 10:37 ` Greg Kroah-Hartman
2023-10-12 11:14 ` Alexander Potapenko
2023-10-12 11:24 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023101201-grasp-smartly-2085@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=ajd@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=glider@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=xkernel.wang@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.