From: Mike Rapoport <rppt@kernel.org>
To: Yajun Deng <yajun.deng@linux.dev>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] memblock: don't run loop in memblock_add_range() twice
Date: Thu, 12 Oct 2023 12:24:42 +0300 [thread overview]
Message-ID: <20231012092442.GR3303@kernel.org> (raw)
In-Reply-To: <df623d80-befb-09e0-04eb-3c93ecfa9f2e@linux.dev>
On Thu, Oct 05, 2023 at 11:20:19PM +0800, Yajun Deng wrote:
>
> On 2023/10/5 13:19, Mike Rapoport wrote:
>
> > I don't see this micro-optimization is worth the churn and potential bugs.
> > NAK.
>
> There are many handouts that tell people it needs to run twice in
> memblock_add_range().
>
> I think it's time to change this. I'm trying to tell people that running
> twice is unnecessary.
It might be unnecessary, but it's still simpler than the solutions you
proposed. And, again, removing the second loop is not worth the churn and
potential bugs.
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2023-10-12 9:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 16:30 [PATCH v3] memblock: don't run loop in memblock_add_range() twice Yajun Deng
2023-10-05 5:19 ` Mike Rapoport
2023-10-05 15:20 ` Yajun Deng
2023-10-12 9:24 ` Mike Rapoport [this message]
2023-10-12 9:28 ` Yajun Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231012092442.GR3303@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.