Re: [joro-iommu:x86/amd 16/19] drivers/iommu/amd/iommu.c:829:21: warning: variable 'entry' set but not used

[Jason Gunthorpe <jgg@nvidia.com>]

On Thu, Oct 12, 2023 at 10:56:27AM +0530, Vasant Hegde wrote:
> Hi,
> 
> 
> On 10/7/2023 8:50 AM, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git x86/amd
> > head:   189116d5ad54eee2bab82c5f12e837912fc0b4c4
> > commit: d55b0d2e075ad32d560cdd35a2016973fda52ed6 [16/19] iommu/amd: Remove PPR support
> > config: x86_64-randconfig-003-20231007 (https://download.01.org/0day-ci/archive/20231007/202310071103.BYatoc0b-lkp@intel.com/config)
> > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231007/202310071103.BYatoc0b-lkp@intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202310071103.BYatoc0b-lkp@intel.com/
> > 
> > All warnings (new ones prefixed by >>):
> > 
> >    drivers/iommu/amd/iommu.c: In function 'iommu_poll_ppr_log':
> >>> drivers/iommu/amd/iommu.c:829:21: warning: variable 'entry' set but not used [-Wunused-but-set-variable]
> >      829 |                 u64 entry[2];
> >          |                     ^~~~~
> 
> 
> Commit d55b0d2e075 (iommu/next branch), removed PPR support. Hence this become
> unused variable. But soon we will be adding PPR support for SVA [1]. Hence I
> just added comment and left it as is (instead of removing and adding it back again).

You should remove it, best practice is that every commit compiles
without warnings. People build with -Werror so this will create a
problem

Jason