From: Tony Lindgren <tony@atomide.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: "Michael Turquette" <mturquette@baylibre.com>,
"Tero Kristo" <kristo@kernel.org>,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-omap@vger.kernel.org,
"Andreas Kemnade" <andreas@kemnade.info>,
"Péter Ujfalusi" <peter.ujfalusi@gmail.com>,
"H. Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: [PATCH 1/2] clk: ti: Fix missing omap4 mcbsp functional clock and aliases
Date: Fri, 13 Oct 2023 11:03:55 +0300 [thread overview]
Message-ID: <20231013080355.GH34982@atomide.com> (raw)
In-Reply-To: <879d697a9b1a816c75566c111c28ae01.sboyd@kernel.org>
* Stephen Boyd <sboyd@kernel.org> [231012 22:42]:
> Quoting Tony Lindgren (2023-10-11 00:18:55)
> > We are using a wrong mcbsp functional clock. The interconnect target module
> > driver provided clock for mcbsp is not same as the mcbsp functional clock
> > known as the gfclk main_clk. The mcbsp functional clocks for mcbsp should
> > have been added before we dropped the legacy platform data.
> >
> > Additionally we are also missing the clock aliases for the clocks used by
> > the audio driver if reparenting is needed. This causes audio driver errors
> > like "CLKS: could not clk_get() prcm_fck" for mcbsp as reported by Andreas.
> > The mcbsp clock aliases too should have been added before we dropped the
> > legacy platform data.
> >
> > Let's add the clocks and aliases with a single patch to fix the issue.
> >
> > Fixes: 349355ce3a05 ("ARM: OMAP2+: Drop legacy platform data for omap4 mcbsp")
> > Reported-by: Andreas Kemnade <andreas@kemnade.info>
> > Reported-by: Péter Ujfalusi <peter.ujfalusi@gmail.com>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > ---
>
> Acked-by: Stephen Boyd <sboyd@kernel.org>
Thanks applying both patches into my fixes branch.
Regards,
Tony
prev parent reply other threads:[~2023-10-13 8:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 7:18 [PATCH 1/2] clk: ti: Fix missing omap4 mcbsp functional clock and aliases Tony Lindgren
2023-10-11 7:18 ` [PATCH 2/2] clk: ti: Fix missing omap5 " Tony Lindgren
2023-10-12 22:43 ` Stephen Boyd
2023-10-12 22:42 ` [PATCH 1/2] clk: ti: Fix missing omap4 " Stephen Boyd
2023-10-13 8:03 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231013080355.GH34982@atomide.com \
--to=tony@atomide.com \
--cc=andreas@kemnade.info \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=kristo@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peter.ujfalusi@gmail.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.