From: Simon Horman <horms@kernel.org>
To: Shinas Rasheed <srasheed@marvell.com>
Cc: pabeni@redhat.com, linux-kernel@vger.kernel.org,
davem@davemloft.net, edumazet@google.com, egallen@redhat.com,
hgani@marvell.com, kuba@kernel.org, mschmidt@redhat.com,
netdev@vger.kernel.org, sedara@marvell.com, vburru@marvell.com,
vimleshk@marvell.com
Subject: Re: [net-next PATCH v2] octeon_ep: pack hardware structures
Date: Fri, 13 Oct 2023 13:15:05 +0200 [thread overview]
Message-ID: <20231013111505.GE29570@kernel.org> (raw)
In-Reply-To: <20231010194026.2284786-1-srasheed@marvell.com>
On Tue, Oct 10, 2023 at 12:40:26PM -0700, Shinas Rasheed wrote:
> Add packed attribute to structures correlating to hardware
> data, as padding is not allowed by hardware.
Hi Shinas,
in the v1 you stated that this is bot a bugfix.
So I am assuming, that by some happy coincidence,
the layout of the structures is the same before and after
this patch. And this patch is thus a cleanup.
If so I think it would be worth noting in the patch description.
prev parent reply other threads:[~2023-10-13 11:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 12:02 [net-next PATCH] octeon_ep: pack hardware structures Shinas Rasheed
2023-10-10 9:28 ` Paolo Abeni
2023-10-10 19:20 ` [EXT] " Shinas Rasheed
2023-10-10 19:40 ` [net-next PATCH v2] " Shinas Rasheed
2023-10-13 11:15 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231013111505.GE29570@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=egallen@redhat.com \
--cc=hgani@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sedara@marvell.com \
--cc=srasheed@marvell.com \
--cc=vburru@marvell.com \
--cc=vimleshk@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.