From: Jakub Kicinski <kuba@kernel.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, jhs@mojatatu.com,
victor@mojatatu.com, martin.lau@linux.dev, dxu@dxuuu.xyz,
xiyou.wangcong@gmail.com
Subject: Re: [PATCH net-next v2 1/2] net, sched: Make tc-related drop reason more flexible
Date: Fri, 13 Oct 2023 14:17:22 -0700 [thread overview]
Message-ID: <20231013141722.21165ef3@kernel.org> (raw)
In-Reply-To: <20231009092655.22025-1-daniel@iogearbox.net>
On Mon, 9 Oct 2023 11:26:54 +0200 Daniel Borkmann wrote:
> Currently, the kfree_skb_reason() in sch_handle_{ingress,egress}() can only
> express a basic SKB_DROP_REASON_TC_INGRESS or SKB_DROP_REASON_TC_EGRESS reason.
>
> Victor kicked-off an initial proposal to make this more flexible by disambiguating
> verdict from return code by moving the verdict into struct tcf_result and
> letting tcf_classify() return a negative error. If hit, then two new drop
> reasons were added in the proposal, that is SKB_DROP_REASON_TC_INGRESS_ERROR
> as well as SKB_DROP_REASON_TC_EGRESS_ERROR. Further analysis of the actual
> error codes would have required to attach to tcf_classify via kprobe/kretprobe
> to more deeply debug skb and the returned error.
I guess Jamal said "this week" so he has two more days? :)
While we wait:
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2023-10-13 21:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 9:26 [PATCH net-next v2 1/2] net, sched: Make tc-related drop reason more flexible Daniel Borkmann
2023-10-09 9:26 ` [PATCH net-next v2 2/2] net, sched: Add tcf_set_drop_reason for {__,}tcf_classify Daniel Borkmann
2023-10-09 14:03 ` [PATCH net-next v2 1/2] net, sched: Make tc-related drop reason more flexible Jamal Hadi Salim
2023-10-13 21:17 ` Jakub Kicinski [this message]
2023-10-16 20:10 ` patchwork-bot+netdevbpf
2023-10-25 8:59 ` Ido Schimmel
2023-10-25 10:01 ` Daniel Borkmann
2023-10-25 11:05 ` Jamal Hadi Salim
2023-10-25 11:52 ` Daniel Borkmann
2023-10-25 13:21 ` Jamal Hadi Salim
2023-10-25 13:46 ` Daniel Borkmann
2023-10-25 23:13 ` Jamal Hadi Salim
2023-10-27 14:01 ` Daniel Borkmann
2023-10-27 17:37 ` Jamal Hadi Salim
2023-10-27 18:29 ` Daniel Borkmann
2023-10-25 13:53 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231013141722.21165ef3@kernel.org \
--to=kuba@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dxu@dxuuu.xyz \
--cc=jhs@mojatatu.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=victor@mojatatu.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.