All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: Xiao Ni <xni@redhat.com>
Cc: jes@trained-monkey.org, linux-raid@vger.kernel.org,
	colyli@suse.de, neilb@suse.de
Subject: Re: [PATCH 1/1] mdadm/super1: Add MD_FEATURE_RAID0_LAYOUT if sb->layout is set
Date: Fri, 13 Oct 2023 15:44:02 +0200	[thread overview]
Message-ID: <20231013154402.00003976@linux.intel.com> (raw)
In-Reply-To: <CALTww29C_kS9e9hxbz+GFWVvAci1CZSfHxWTigD3zCYdZghmYw@mail.gmail.com>

On Fri, 13 Oct 2023 20:12:38 +0800
Xiao Ni <xni@redhat.com> wrote:

> > > > So, it forces the calculations made by Neil back but I think that we can
> > > > simply compare dev_size and data_offset between members.  
> > >
> > > We don't need to consider the compatibility anymore in future?
> > >  
> > Not sure if I get your question correctly. This property is supported now so
> > why we should? It is already there so we are safe to set it.  
> 
> I asked because you said we can remove the check in future. So I don't
> know why we don't need the check in future. The check here should be
> the kernel version check, right?


We are not supporting old kernels forever. At some point of time, we would
decide that kernels older than 5.5 are no longer a valid case and then we will
free to remove verification. If we are not supporting something older than the
version where it was added, we can assume that MD_RAID0_LAYOUT is always
available and we don't need to care anymore, right?

Here a recent example:
https://git.kernel.org/pub/scm/utils/mdadm/mdadm.git/commit/?id=f8d2c4286a

Thanks,
Mariusz

  reply	other threads:[~2023-10-13 13:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-11 13:05 [PATCH 1/1] mdadm/super1: Add MD_FEATURE_RAID0_LAYOUT if sb->layout is set Xiao Ni
2023-10-13  9:30 ` Mariusz Tkaczyk
2023-10-13 10:59   ` Xiao Ni
2023-10-13 11:59     ` Mariusz Tkaczyk
2023-10-13 12:12       ` Xiao Ni
2023-10-13 13:44         ` Mariusz Tkaczyk [this message]
2023-10-13 15:54           ` Coly Li
2023-10-16  8:13             ` Xiao Ni
2023-10-16  8:13       ` Xiao Ni
2023-10-16  8:50         ` Mariusz Tkaczyk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231013154402.00003976@linux.intel.com \
    --to=mariusz.tkaczyk@linux.intel.com \
    --cc=colyli@suse.de \
    --cc=jes@trained-monkey.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=xni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.