From: Jakub Kicinski <kuba@kernel.org>
To: Ma Ke <make_ruc2021@163.com>
Cc: jmaloy@redhat.com, ying.xue@windriver.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org,
tipc-discussion@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tipc: Fix uninit-value access in tipc_nl_node_get_link()
Date: Fri, 13 Oct 2023 17:17:12 -0700 [thread overview]
Message-ID: <20231013171712.0817d810@kernel.org> (raw)
In-Reply-To: <20231013070408.1979343-1-make_ruc2021@163.com>
On Fri, 13 Oct 2023 15:04:08 +0800 Ma Ke wrote:
> Names must be null-terminated strings. If a name which is not
> null-terminated is passed through netlink, strstr() and similar
> functions can cause buffer overrun. This patch fixes this issue
> by returning -EINVAL if a non-null-terminated name is passed.
>
> Signed-off-by: Ma Ke <make_ruc2021@163.com>
You have now sent 14 incorrect fixes to Linux networking.
And not a single correct one.
I would like to politely ask you to stop.
prev parent reply other threads:[~2023-10-14 0:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 7:04 [PATCH] tipc: Fix uninit-value access in tipc_nl_node_get_link() Ma Ke
2023-10-13 8:56 ` Vadim Fedorenko
2023-10-13 9:20 ` Florian Westphal
2023-10-14 0:17 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231013171712.0817d810@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jmaloy@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=make_ruc2021@163.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.