From: Jakub Kicinski <kuba@kernel.org>
To: Heng Qi <hengqi@linux.alibaba.com>
Cc: Jason Wang <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Simon Horman <horms@kernel.org>,
"Liu, Yujie" <yujie.liu@intel.com>
Subject: Re: [PATCH net-next 2/5] virtio-net: separate rx/tx coalescing moderation cmds
Date: Fri, 13 Oct 2023 18:11:48 -0700 [thread overview]
Message-ID: <20231013181148.3fd252dc@kernel.org> (raw)
In-Reply-To: <dc171e2288d2755b1805afde6b394d2d443a134d.1697093455.git.hengqi@linux.alibaba.com>
On Thu, 12 Oct 2023 15:44:06 +0800 Heng Qi wrote:
> +
> +static int virtnet_send_rx_notf_coal_cmds(struct virtnet_info *vi,
> + struct ethtool_coalesce *ec)
> +{
> + struct scatterlist sgs_rx;
> +
../drivers/net/virtio_net.c: In function ‘virtnet_send_rx_notf_coal_cmds’:
../drivers/net/virtio_net.c:3306:14: error: ‘i’ undeclared (first use in this function); did you mean ‘vi’?
3306 | for (i = 0; i < vi->max_queue_pairs; i++) {
| ^
| vi
next prev parent reply other threads:[~2023-10-14 1:11 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 7:44 [PATCH net-next 0/5] virtio-net: support dynamic coalescing moderation Heng Qi
2023-10-12 7:44 ` [PATCH net-next 1/5] virtio-net: returns whether napi is complete Heng Qi
2023-10-25 2:43 ` Jason Wang
2023-10-25 2:43 ` Jason Wang
2023-10-12 7:44 ` [PATCH net-next 2/5] virtio-net: separate rx/tx coalescing moderation cmds Heng Qi
2023-10-14 1:11 ` Jakub Kicinski [this message]
2023-10-16 7:45 ` Heng Qi
2023-10-16 7:51 ` Michael S. Tsirkin
2023-10-16 7:51 ` Michael S. Tsirkin
2023-10-12 7:44 ` [PATCH net-next 3/5] virtio-net: extract virtqueue coalescig cmd for reuse Heng Qi
2023-10-25 3:03 ` Jason Wang
2023-10-25 3:03 ` Jason Wang
2023-10-12 7:44 ` [PATCH net-next 4/5] virtio-net: support rx netdim Heng Qi
2023-10-25 3:34 ` Jason Wang
2023-10-25 3:34 ` Jason Wang
2023-11-01 10:55 ` Heng Qi
2023-11-02 4:31 ` Jason Wang
2023-11-02 4:31 ` Jason Wang
2023-11-02 4:46 ` Heng Qi
2023-10-12 7:44 ` [PATCH net-next 5/5] virtio-net: support tx netdim Heng Qi
2023-10-25 3:35 ` Jason Wang
2023-10-25 3:35 ` Jason Wang
2023-10-25 5:50 ` Michael S. Tsirkin
2023-10-25 5:50 ` Michael S. Tsirkin
2023-10-12 8:29 ` [PATCH net-next 0/5] virtio-net: support dynamic coalescing moderation Jason Wang
2023-10-12 8:29 ` Jason Wang
2023-10-13 1:53 ` Jason Wang
2023-10-13 1:53 ` Jason Wang
2023-10-16 7:35 ` Heng Qi
2023-10-24 12:02 ` Heng Qi
2023-10-25 1:18 ` Jason Wang
2023-10-25 1:18 ` Jason Wang
2023-10-25 5:53 ` Michael S. Tsirkin
2023-10-25 5:53 ` Michael S. Tsirkin
2023-11-01 11:03 ` Heng Qi
2023-11-02 4:33 ` Jason Wang
2023-11-02 4:33 ` Jason Wang
2023-11-02 4:47 ` Heng Qi
2023-11-01 9:38 ` Heng Qi
2023-11-02 4:34 ` Jason Wang
2023-11-02 4:34 ` Jason Wang
2023-11-02 4:51 ` Heng Qi
2023-11-02 4:53 ` Heng Qi
2023-10-25 5:49 ` Michael S. Tsirkin
2023-10-25 5:49 ` Michael S. Tsirkin
2023-11-01 9:40 ` Heng Qi
2023-11-01 10:44 ` Michael S. Tsirkin
2023-11-01 10:44 ` Michael S. Tsirkin
2023-11-01 10:57 ` Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231013181148.3fd252dc@kernel.org \
--to=kuba@kernel.org \
--cc=ast@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=hengqi@linux.alibaba.com \
--cc=horms@kernel.org \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yujie.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.