All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Edward AD <twuufnxlz@gmail.com>
Cc: bpf@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, netdev@vger.kernel.org,
	pabeni@redhat.com,
	syzbot+225bfad78b079744fd5e@syzkaller.appspotmail.com,
	syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] media: imon: fix stall in worker_thread
Date: Sat, 14 Oct 2023 09:28:24 +0200	[thread overview]
Message-ID: <20231014072824.GU29570@kernel.org> (raw)
In-Reply-To: <20231014035114.1057686-2-twuufnxlz@gmail.com>

On Sat, Oct 14, 2023 at 11:51:15AM +0800, Edward AD wrote:
> On Fri, 13 Oct 2023 12:59:09 +0200 Simon Horman wrote:
> > The code is already switching based on urb->status,
> > so unless the warning message is really desired,
> > perhaps this is more appropriate?
> > 
> > diff --git a/drivers/media/rc/imon.c b/drivers/media/rc/imon.c
> > index 74546f7e3469..0e2f06f2f456 100644
> > --- a/drivers/media/rc/imon.c
> > +++ b/drivers/media/rc/imon.c
> > @@ -1799,6 +1799,7 @@ static void usb_rx_callback_intf1(struct urb *urb)
> > 
> >  	switch (urb->status) {
> >  	case -ENOENT:		/* usbcore unlink successful! */
> > +	case -EPROTO:		/* XXX: something goes here */
> >  		return;
> > 
> >  	case -ESHUTDOWN:	/* transport endpoint was shut down */
> 
> Hi Simon Horman, 
> 
> Who added the above code where?

Maybe I misunderstand your question but
I am suggesting the above change as an alternative approach.

  reply	other threads:[~2023-10-14  7:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-07 18:33 [syzbot] [net?] [usb?] INFO: rcu detected stall in worker_thread (9) syzbot
2023-10-10  5:36 ` [PATCH] media: imon: fix stall in worker_thread Edward AD
2023-10-13 10:59   ` Simon Horman
2023-10-14  3:51     ` Edward AD
2023-10-14  7:28       ` Simon Horman [this message]
2023-11-02  0:14 ` [syzbot] [net?] [usb?] INFO: rcu detected stall in worker_thread (9) syzbot
2023-11-14 18:18 ` [syzbot] [batman?] " syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231014072824.GU29570@kernel.org \
    --to=horms@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=syzbot+225bfad78b079744fd5e@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=twuufnxlz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.