From: Herve Codina <herve.codina@bootlin.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Rob Herring <robh@kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Wang Yufen <wangyufen@huawei.com>,
Aidan MacDonald <aidanmacdonald.0x0@gmail.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Astrid Rost <astrid.rost@axis.com>,
Robert Hancock <robert.hancock@calian.com>,
Sameer Pujar <spujar@nvidia.com>,
alsa-devel@alsa-project.org, kernel@pengutronix.de,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH 4/7] ASoC: simple-card-utils: Make simple_util_remove() return void
Date: Sat, 14 Oct 2023 14:23:22 +0200 [thread overview]
Message-ID: <20231014142322.30039db9@bootlin.com> (raw)
In-Reply-To: <20231013221945.1489203-13-u.kleine-koenig@pengutronix.de>
On Sat, 14 Oct 2023 00:19:50 +0200
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> simple_util_remove() returned zero unconditionally. Make it return void
> instead and convert all users to struct platform_device::remove_new().
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Herve Codina <herve.codina@bootlin.com>
Best regards,
Hervé
next prev parent reply other threads:[~2023-10-14 12:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 22:19 [PATCH 0/7] ASoc: Another series to convert to struct platform_driver:remove_new() Uwe Kleine-König
2023-10-13 22:19 ` Uwe Kleine-König
2023-10-13 22:19 ` Uwe Kleine-König
2023-10-13 22:19 ` Uwe Kleine-König
2023-10-13 22:19 ` [PATCH 1/7] ASoC: rockchip: i2s_tdm: Convert to platform remove callback returning void Uwe Kleine-König
2023-10-13 22:19 ` Uwe Kleine-König
2023-10-13 22:19 ` Uwe Kleine-König
2023-10-13 22:19 ` [PATCH 2/7] ASoC: cs42l43: " Uwe Kleine-König
2023-10-24 8:43 ` Charles Keepax
2023-10-13 22:19 ` [PATCH 3/7] ASoC: starfive/jh7110-pwmdac: " Uwe Kleine-König
2023-10-13 22:19 ` [PATCH 4/7] ASoC: simple-card-utils: Make simple_util_remove() return void Uwe Kleine-König
2023-10-14 12:23 ` Herve Codina [this message]
2023-10-13 22:19 ` [PATCH 5/7] ASoC: meson: Make meson_card_remove() " Uwe Kleine-König
2023-10-13 22:19 ` Uwe Kleine-König
2023-10-13 22:19 ` Uwe Kleine-König
2023-10-17 14:40 ` Jerome Brunet
2023-10-17 14:40 ` Jerome Brunet
2023-10-17 14:40 ` Jerome Brunet
2023-10-13 22:19 ` [PATCH 6/7] ASoC: qcom: lpass: Make asoc_qcom_lpass_cpu_platform_remove() " Uwe Kleine-König
2023-10-13 22:19 ` [PATCH 7/7] ASoC: uniphier: Make uniphier_aio_remove() " Uwe Kleine-König
2023-10-13 22:19 ` Uwe Kleine-König
2023-10-24 13:54 ` [PATCH 0/7] ASoc: Another series to convert to struct platform_driver:remove_new() Mark Brown
2023-10-24 13:54 ` Mark Brown
2023-10-24 13:54 ` Mark Brown
2023-10-24 13:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231014142322.30039db9@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=aidanmacdonald.0x0@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=astrid.rost@axis.com \
--cc=broonie@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=jernej.skrabec@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-tegra@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robert.hancock@calian.com \
--cc=robh@kernel.org \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wangyufen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.