Re: [PATCH v3 1/2] net: page_pool: check page pool ethtool stats

[Leon Romanovsky <leon@kernel.org>]

On Sun, Oct 15, 2023 at 02:37:27PM +0200, Sven Auhagen wrote:
> If the page_pool variable is null while passing it to
> the page_pool_get_stats function we receive a kernel error.
> 
> Check if the page_pool variable is at least valid.
> 
> Signed-off-by: Sven Auhagen <sven.auhagen@voleatech.de>
> Reported-by: Paulo Da Silva <Paulo.DaSilva@kyberna.com>
> ---
>  net/core/page_pool.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/net/core/page_pool.c b/net/core/page_pool.c
> index 2396c99bedea..4c5dca6b4a16 100644
> --- a/net/core/page_pool.c
> +++ b/net/core/page_pool.c
> @@ -65,6 +65,9 @@ bool page_pool_get_stats(struct page_pool *pool,
>  	if (!stats)
>  		return false;
>  
> +	if (!pool)
> +		return false;
> +

I would argue that both pool and stats shouldn't be NULL and must be
checked by caller. This API call named get-stats-from-pool.

Thanks

>  	/* The caller is responsible to initialize stats. */
>  	stats->alloc_stats.fast += pool->alloc_stats.fast;
>  	stats->alloc_stats.slow += pool->alloc_stats.slow;
> -- 
> 2.42.0
> 
>