All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Liansen Zhai <zhailiansen@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, yuwang@kuaishou.com,
	wushukun@kuaishou.com, Liansen Zhai <zhailiansen@kuaishou.com>
Subject: Re: [PATCH net-next,v2] cgroup, netclassid: on modifying netclassid in cgroup, only consider the main process.
Date: Mon, 16 Oct 2023 11:28:32 +0200	[thread overview]
Message-ID: <20231016092832.GI1501712@kernel.org> (raw)
In-Reply-To: <20231012090330.29636-1-zhailiansen@kuaishou.com>

On Thu, Oct 12, 2023 at 05:03:30PM +0800, Liansen Zhai wrote:
> When modifying netclassid, the command("echo 0x100001 > net_cls.classid")
> will take more time on many threads of one process, because the process
> create many fds.
> for example, one process exists 28000 fds and 60000 threads, echo command
> will task 45 seconds.
> Now, we only consider the main process when exec "iterate_fd", and the
> time is about 52 milliseconds.
> 
> Signed-off-by: Liansen Zhai <zhailiansen@kuaishou.com>

Thanks for addressing my review of v1.

Reviewed-by: Simon Horman <horms@kernel.org>

  reply	other threads:[~2023-10-16  9:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-12  9:03 [PATCH net-next,v2] cgroup, netclassid: on modifying netclassid in cgroup, only consider the main process Liansen Zhai
2023-10-16  9:28 ` Simon Horman [this message]
2023-10-16 23:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231016092832.GI1501712@kernel.org \
    --to=horms@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=wushukun@kuaishou.com \
    --cc=yuwang@kuaishou.com \
    --cc=zhailiansen@gmail.com \
    --cc=zhailiansen@kuaishou.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.