From: Stephen Hemminger <stephen@networkplumber.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
syzbot <syzkaller@googlegroups.com>
Subject: Re: [PATCH net] tun: prevent negative ifindex
Date: Mon, 16 Oct 2023 13:57:29 -0700 [thread overview]
Message-ID: <20231016135729.492ae9e2@hermes.local> (raw)
In-Reply-To: <CANn89iJdhqOtvoGsquYbicThdUGFEzLFmKR5v7wXryKz6Rw3=Q@mail.gmail.com>
On Mon, 16 Oct 2023 21:42:10 +0200
Eric Dumazet <edumazet@google.com> wrote:
> Setting tfile->ifindex to zero should be a NOP ?
>
> This means dev_index_reserve() will allocate a ifindex for us.
>
> Not sure we want to prevent something that was working properly in the past.
That makes sense. did not read ahead to see what happens
next prev parent reply other threads:[~2023-10-16 20:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 18:08 [PATCH net] tun: prevent negative ifindex Eric Dumazet
2023-10-16 19:33 ` Stephen Hemminger
2023-10-16 19:42 ` Eric Dumazet
2023-10-16 20:57 ` Stephen Hemminger [this message]
2023-10-17 0:55 ` Willem de Bruijn
2023-10-17 2:40 ` Jason Wang
2023-10-18 1:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231016135729.492ae9e2@hermes.local \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.